The alignment of the #defines at the top of the file is not consistent.
This changes all of the defines to use consistent alignment to improve
the code readability.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

isl29028_chip_init() contains the device driver defaults and
two I2C calls that detect the presence of the chip. This patch
moves these into isl29028_probe() so that this function can
be used by the power management runtinme in a followup patch. This
patch also renames isl29028_chip_init() to
isl29028_chip_init_and_power_on().
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

There are two callers to the function isl29028_set_als_ir_mode() and
both instances use a nested if statement to only change the chip state
if it is not in the proper mode. This patch moves this check into the
isl29028_set_als_ir_mode() function to remove the nested if
statements.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

At the end of function ad7150_write_event_config(), directly returns 0.
As a result, the errors will be ignored by the callers. It may be better
to return variable "ret".
Signed-off-by: NPan Bian <bianpan2016@163.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

In function cm3232_reg_init(), it returns 0 even if the last call to
i2c_smbus_write_byte_data() returns a negative value (indicates error).
As a result, the return value may be inconsistent with the execution
status, and the caller of cm3232_reg_init() will not be able to detect
the error. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188641Signed-off-by: NPan Bian <bianpan2016@163.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch fixes the following checkpatch.pl warning in ad7150.c
WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred
Occured during build.
Signed-off-by: NAmit Kushwaha <kushwaha.a@samsung.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Added timestamp channel. With this change, each sample has a timestamp.
This timestamp can be from the sensor hub when present or local kernel
timestamp. HID sensors can send timestamp with input data using usage id
HID_USAGE_SENSOR_TIME_TIMESTAMP. This timestamp value is converted to
nano seconds before pushing this sample to the iio core.
Signed-off-by: NSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This adds a new driver for the TI ADS7950 family of ADC chips. These
communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel
varieties.
Signed-off-by: NDavid Lechner <david@lechnology.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

msleep(1~20) may not do what the caller intends, and will often sleep longer.
(~20 ms actual sleep for any value given in the 1~20ms range)
This is not the desired behaviour for many cases like device resume time,
device suspend time, device enable time, data reading time, etc.
Thus, change msleep to usleep_range for precise wakeups.
Signed-off-by: NAniroop Mathur <a.mathur@samsung.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The copyright year can not be in the future.
Signed-off-by: NReto Schneider <code@reto-schneider.ch>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The module descriptions for the ADIS 16201, 16203 and 16209 drivers do not
match the actual function of the devices. Update them accordingly to fix
this.
Signed-off-by: NReto Schneider <code@reto-schneider.ch>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

smatch warned:
	sval_binop_signed: invalid divide LLONG_MIN/-1

and this fixes it. It's actually good to have, in order to avoid accidental
checking for negative return values here.
Signed-off-by: NMartin Kepplinger <martink@posteo.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Support driver probe by reading unique HID on systems based on ACPI instead
of DT compatible strings.
Signed-off-by: NShrirang Bagul <shrirang.bagul@canonical.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Compatible strings are not available on ACPI based systems. This patch adds
support to use DSDT information read from platform BIOS instead for probing
st pressure sensors.
Signed-off-by: NShrirang Bagul <shrirang.bagul@canonical.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add support to probe st_accel sensors on i2c bus using ACPI. Compatible
strings are not avaialable on ACPI based systems.
Signed-off-by: NShrirang Bagul <shrirang.bagul@canonical.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add support to match st sensors using information passed from ACPI DST
tables.
Signed-off-by: NShrirang Bagul <shrirang.bagul@canonical.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Remove two passthrough macros that are only called from a single
location and make the resultant vmcall directly.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use the already defined DIAG_SEVERITY values directly instead of special
postcode macro names.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

There were two instances of FAILURE being misspelled in the s-Par
firmware postcode event enum that are fixed.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove guestlinuxdebug enum values that are no longer being used and
renumber remaining values accordingly.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The visorchipset.c functionality was moved into the visorbus driver
previously. This patch updates the s-Par firmware postcode values to
reflect this status.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_4.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_3.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Call POSTCODE_LINUX directly instead of passing through POSTCODE_LINUX_2.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Use CURRENT_FILE_PC directly in the POSTCODE_LINUX macro instead of
relying on passthrough macros to provide it.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Leverage the 3 existing s-Par postcode macros to do a bit more work
and provide only 1 base postcode macro.
Signed-off-by: NBryan Thompson <bryan.thompson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes all the unused pound defines currently in
vbuschannel.h.
Signed-off-by: NErik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes all the unused pound defines currently in
vmcallinterface.h.
Signed-off-by: NErik Arfvidson <erik.arfvidson@unisys.com>
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The dgnc driver has no business creating "custom" sysfs files just for a
single tty driver.  Combined with the odd way they are created, it's
just a mess, so remove them entirely as I am tired of tripping over them
when doing driver core changes.

Cc: Lidza Louina <lidza.louina@gmail.com>
Cc: Mark Hounschell <markh@compro.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixes sm750fb tabstop style warning
found by checkpatch.pl tool
Signed-off-by: NAndrea Ghittino <aghittino@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The scripts to replace NULL test got confused with the
macro parenthesis so the unlikely test in libcfs_private.h
ended up incorrect. This fixes this error.
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NJames Simmons <jsimmons@infradead.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Trivial fix to spelling mistake "oustanding" to "outstanding".
Signed-off-by: NColin Ian King <colin.king@canonical.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove one blank line in sequence of two empty lines.
Signed-off-by: NDawid Kurek <dawikur@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Align parameters to open parenthesis.
Signed-off-by: NDawid Kurek <dawikur@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

"revId" needs to be unsigned because we use it to test:

	if (revId == SM750LE_REVISION_ID) {

and SM750LE_REVISION_ID is ((unsigned char )0xfe).

Fixes: 81dee67e ("staging: sm750fb: add sm750 to staging")
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The driver was actually released with BSD license. It also gained GPL
when it was submitted to be included in the kernel.

Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Cc: gzhou1 <guojian.zhou@windriver.com>
Signed-off-by: NSudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes UPDATE_STATS_GB macro in slic.h header file
and just inline code. This improve readability.
Signed-off-by: NSergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch remove UPDATE_STATS macro from
header slic.h which is not being used.
Signed-off-by: NSergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixed checkpatch.pl warnings related to {} brace warnings for single
statement blocks.
Signed-off-by: NYamanappagouda Patil <goudapatilk@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch warnings regarding the use of symbolic permissions.

Where the MOST_CHANNEL_ATTR macro is used, convert to octal
permissions over symbolic.

Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and
update the show/store function names appropriately.
Signed-off-by: NJason Litzinger <jlitzingerdev@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>