1. 03 2月, 2008 2 次提交
  2. 02 2月, 2008 3 次提交
  3. 27 1月, 2008 15 次提交
  4. 26 1月, 2008 15 次提交
    • B
      ide-disk: use do_rw_taskfile() (take 2) · f6e29e35
      Bartlomiej Zolnierkiewicz 提交于
      * Add IDE_TFLAG_DMA_PIO_FALLBACK taskfile flag to indicate the need
        to skip loading taskfile registers in do_rw_taskfile().
      
      * Export do_rw_taskfile().
      
      * Convert __ide_do_rw_disk() to use do_rw_taskfile().
      
      * Unexport ide_tf_load().
      
      * Unexport {pre_task_out,task_in}_intr() and make it static.
      
      * Remove incorrect comment about do_rw_taskfile() from <linux/ide.h>.
      
      There should be no functionality changes caused by this patch.
      
      v2:
      * Add missing blk_fs_request() check to task_dma_ok() (for VDMA).
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      f6e29e35
    • B
      ide: remove 'handler' field from ide_task_t (take 2) · 57d7366b
      Bartlomiej Zolnierkiewicz 提交于
      * Add IDE_TFLAG_CUSTOM_HANDLER taskfile flag and use it for internal requests
        which require custom handlers.  Check the flag in do_rw_taskfile() and set
        handler accordingly.
      
      * Cleanup ide_init_{specify,restore,setmult}_cmd() and rename it to
        ide_tf_set_{specify,restore,setmult}_cmd().
      
      * Make {set_geometry,recal,set_multmode}_intr() static.
      
      * Remove no longer needed 'handler' field from ide_task_t.
      
      v2:
      * 'handler' in do_rw_taskfile() must be set to NULL initially.
      
      There should be no functionality changes caused by this patch.
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      57d7366b
    • B
      ide: use ->data_phase to set ->handler in do_rw_taskfile() · 1192e528
      Bartlomiej Zolnierkiewicz 提交于
      * Use ->data_phase to set ->handler in do_rw_taskfile() instead of
        setting ->handler in callers of ide_raw_taskfile()/do_rw_taskfile().
      
      * Unexport task_no_data_intr() and make it static.
      
      There should be no functionality changes caused by this patch.
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      1192e528
    • B
      ide: convert do_rw_taskfile() to use ->data_phase · 10d90157
      Bartlomiej Zolnierkiewicz 提交于
      * Use task->data_phase in do_rw_taskfile() to decide what to do.
      
      * task->prehandler is only used by TASKFILE[_MULTI]_OUT so just
        use pre_task_out_intr() directly and remove no longer needed
        'prehandler' field from ide_task_t.
      
      * Remove no longer needed ide_pre_handler_t type.
      
      There should be no functionality changes caused by this patch.
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      10d90157
    • B
      ide: merge flagged_taskfile() into do_rw_taskfile() · 1edee60e
      Bartlomiej Zolnierkiewicz 提交于
      Based on the earlier work by Tejun Heo.
      
      task->data_phase == TASKFILE_MULTI_{IN,OUT} vs drive->mult_count == 0
      check is needed also for ide_taskfile_ioctl() requests that don't have
      IDE_TFLAG_FLAGGED taskfile flag set.
      
      Cc: Tejun Heo <htejun@gmail.com>
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      1edee60e
    • B
      ide: remove 'tf_in_flags' field from ide_task_t · 866e2ec9
      Bartlomiej Zolnierkiewicz 提交于
      * Add IDE_TFLAG_IN_DATA taskfile flag to indicate the need of reading
        IDE_DATA_REG in ide_end_drive_cmd().
      
        Set the new flag in ide_taskfile_ioctl() if ->in_flags.b.data is set.
      
      * Add IDE_TFLAG_FLAGGED_SET_IN_FLAGS taskfile flag to indicate the
        need of modifying ->in_flags in ide_taskfile_ioctl().
      
        Set the new flag in flagged_taskfile() and move the code modifying
        ->tf_in_flags to ide_taskfile_ioctl().
      
        While at it remove the bogus comment: ->tf_in_flags (except .b.data)
        have no effect on selection of registers to read.
      
      * Remove no longer needed 'tf_in_flags' field from ide_task_t.
      
      As the result we finally have the internals of HDIO_DRIVE_TASKFILE ioctl
      separated from the core IDE code.
      
      There should be no functionality changes caused by this patch.
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      866e2ec9
    • B
      ide: remove 'command_type' field from ide_task_t · ac026ff2
      Bartlomiej Zolnierkiewicz 提交于
      * Add 'data_buf' and 'nsect' variables in ide_taskfile_ioctl()
        to cache data buffer pointer and number of sectors to transfer
        (this allows us to have only one ide_diag_taskfile() call).
      
      * Add IDE_TFLAG_WRITE taskfile flag and use it to check whether
        the REQ_RW request flag should be set.
      
      * Move ->command_type handling from ide_diag_taskfile() to
        ide_taskfile_ioctl() and use ->req_cmd instead of ->command_type.
      
      * Add 'nsect' parameter to ide_raw_taskfile().
      
      * Merge ide_diag_taskfile() into ide_raw_taskfile().
      
      * Initialize ->data_phase explicitly in idedisk_prepare_flush(),
        ide_start_power_step() and ide_disk_special().
      
      * Remove no longer needed 'command_type' field from ide_task_t.
      
      * Add #ifndef/#endif __KERNEL__ to <linux/hdreg.h> around no
        longer used by kernel IDE_DRIVE_TASK_* and TASKFILE_* defines.
      
      There should be no functionality changes caused by this patch.
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      ac026ff2
    • B
      ide: switch ide_task_ioctl() to use REQ_TYPE_ATA_TASKFILE requests · 14b89ef9
      Bartlomiej Zolnierkiewicz 提交于
      Based on the earlier work by Tejun Heo.
      
      There should be no functionality changes caused by this patch.
      
      Cc: Tejun Heo <htejun@gmail.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      14b89ef9
    • B
      ide: remove unnecessary writes to HOB taskfile registers · a3bbb9d8
      Bartlomiej Zolnierkiewicz 提交于
      * Set taskfile flags for REQ_TYPE_ATA_TASKFILE requests before
        adding the request to the queue.
      
      * Cleanup execute_drive_cmd().
      
      * Remove unnecessary writes to HOB taskfile registers when using
        LBA48 disk for the following cases:
      
        - Power Management requests
          (WIN_FLUSH_CACHE[_EXT], WIN_STANDBYNOW1, WIN_IDLEIMMEDIATE commands)
      
        - special commands (WIN_SPECIFY, WIN_RESTORE, WIN_SETMULT)
      
        - Host Protected Area support (WIN_READ_NATIVE_MAX, WIN_SET_MAX)
      
        - /proc/ide/ SMART support (WIN_SMART with SMART_ENABLE,
          SMART_READ_VALUES and SMART_READ_THRESHOLDS subcommands)
      
        - write cache enabling/disabling in ide-disk
          (WIN_SETFEATURES with SETFEATURES_{EN,DIS}_WCACHE)
      
        - write cache flushing in ide-disk (WIN_FLUSH_CACHE[_EXT])
      
        - acoustic management in ide-disk
          (WIN_SETFEATURES with SETFEATURES_{EN,DIS}_AAM)
      
        - door (un)locking in ide-disk (WIN_DOORLOCK, WIN_DOORUNLOCK)
      
        - /proc/ide/hd?/identify support (WIN_IDENTIFY)
      
        - ACPI _GTF taskfiles
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      a3bbb9d8
    • B
      ide: use ide_tf_load() in execute_drive_cmd() · 807e35d6
      Bartlomiej Zolnierkiewicz 提交于
      * Add IDE_TFLAG_OUT_DEVICE taskfile flag to indicate the need of writing
        the Device register and handle it in ide_tf_load().
      
        Update ide_tf_load() and {do_rw,flagged}_taskfile() users accordingly.
      
      * Use struct ide_taskfile and ide_tf_load() in execute_drive_cmd().
      
      * Make the debugging code dump all taskfile registers for both
        REQ_ATA_TYPE_{CMD,TASK} requests and move it to ide_tf_load()
        so it also covers REQ_ATA_TYPE_TASKFILE requests.
      
      There should be no functionality changes caused by this patch
      (unless DEBUG is defined).
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      807e35d6
    • B
      ide: use do_rw_taskfile() in flagged_taskfile() · 74095a91
      Bartlomiej Zolnierkiewicz 提交于
      Based on the earlier work by Tejun Heo.
      
      * Move setting IDE_TFLAG_LBA48 taskfile flag from do_rw_taskfile()
        function to the callers.
      
      * Add IDE_TFLAG_FLAGGED taskfile flag for flagged taskfiles coming
        from ide_taskfile_ioctl().  Check it instead of ->tf_out_flags.all.
      
      * Add IDE_TFLAG_OUT_DATA taskfile flag to indicate the need to load
        IDE data register in ide_tf_load().
      
      * Add IDE_TFLAG_OUT_* taskfile flags to indicate the need to load
        particular IDE taskfile registers in ide_tf_load().
      
      * Update do_rw_taskfile() and ide_tf_load() users to set respective
        IDE_TFLAG_OUT_* taksfile flags.
      
      * Add task_dma_ok() helper.
      
      * Use IDE_TFLAG_FLAGGED taskfile flag to select HIHI mask in ide_tf_load().
      
      * Use do_rw_taskfile() in flagged_taskfile().
      
      * Remove no longer needed 'tf_out_flags' field from ide_task_t.
      
      There should be no functionality changes caused by this patch.
      
      Cc: Tejun Heo <htejun@gmail.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      74095a91
    • B
      ide: add ide_no_data_taskfile() helper · 9a3c49be
      Bartlomiej Zolnierkiewicz 提交于
      * Add ide_no_data_taskfile() helper and convert ide_raw_taskfile() w/ NO DATA
        protocol users to use it instead.
      
      * Set ->data_phase explicitly in ide_no_data_taskfile()
        (TASKFILE_NO_DATA is defined as 0x0000).
      
      * Unexport task_no_data_intr().
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      9a3c49be
    • B
      ide: add ide_tf_load() helper · 9e42237f
      Bartlomiej Zolnierkiewicz 提交于
      Based on the earlier work by Tejun Heo.
      
      * Add 'tf_flags' field (for taskfile flags) to ide_task_t.
      
      * Add IDE_TFLAG_LBA48 taskfile flag for LBA48 taskfiles.
      
      * Add IDE_TFLAG_NO_SELECT_MASK taskfile flag for __ide_do_rw_disk()
        which doesn't use SELECT_MASK() (looks like a bug but it requires
        some more investigation).
      
      * Split off ide_tf_load() helper from do_rw_taskfile().
      
      * Convert __ide_do_rw_disk() to use ide_tf_load().
      
      There should be no functionality changes caused by this patch.
      
      Cc: Tejun Heo <htejun@gmail.com>
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      9e42237f
    • B
      ide: add struct ide_taskfile (take 2) · 650d841d
      Bartlomiej Zolnierkiewicz 提交于
      * Don't set write-only ide_task_t.hobRegister[6] and ide_task_t.hobRegister[7]
        in idedisk_set_max_address_ext().
      
      * Add struct ide_taskfile and use it in ide_task_t instead of tfRegister[]
        and hobRegister[].
      
      * Remove no longer needed IDE_CONTROL_OFFSET_HOB define.
      
      * Add #ifndef/#endif __KERNEL__ around definitions of {task,hob}_struct_t.
      
      While at it:
      
      * Use ATA_LBA define for LBA bit (0x40) as suggested by Tejun Heo.
      
      v2:
      * Add missing newlines. (Noticed by Sergei)
      
      * Use ~ATA_LBA instead of 0xBF. (Noticed by Sergei)
      
      * Use unnamed unions for error/feature and status/command.
        (Suggested by Sergei).
      
      There should be no functionality changes caused by this patch.
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Cc: Tejun Heo <htejun@gmail.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      650d841d
    • B
      ide: remove task_ioreg_t typedef (take 2) · cd2a2d96
      Bartlomiej Zolnierkiewicz 提交于
      Remove task_ioreg_t typedef from the kernel code (but leave it
      in <linux/hdreg.h> for #ifndef/#endif __KERNEL__ case).
      
      While at it also move sata_ioreg_t typedef under #ifndef/#endif __KERNEL__.
      
      v2:
      Remove name of the second parameter from ide_execute_command() declaration.
      (Noticed by Sergei).
      Acked-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Signed-off-by: NBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      cd2a2d96
  5. 06 11月, 2007 2 次提交
  6. 23 10月, 2007 1 次提交
  7. 20 10月, 2007 2 次提交