1. 07 4月, 2009 1 次提交
  2. 23 1月, 2009 1 次提交
  3. 12 1月, 2009 1 次提交
  4. 18 12月, 2008 1 次提交
  5. 27 11月, 2008 1 次提交
    • J
      ALSA: sound/pci/mixart/mixart.c: Add missing snd_card_free · 73f6a12e
      Julia Lawall 提交于
      The function snd_mixart_create creates a link between mgr and card that
      allows snd_mixart_free to free card as well.  But if snd_mixart_create
      fails, then the link has not been created and card has to be freed explicitly.
      
      The semantic match that finds the problem is as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @r exists@
      local idexpression x;
      statement S,S1;
      position p1,p2,p3;
      expression E,E1;
      type T,T1;
      expression *ptr != NULL;
      @@
      
      (
       if ((x@p1 = snd_card_new(...)) == NULL) S
      |
       x@p1 = snd_card_new(...);
      )
       ... when != snd_card_free(...,(T)x,...)
           when != if (...) { <+... snd_card_free(...,(T)x,...) ...+> }
           when != true x == NULL || ...
           when != x = E
           when != E = (T)x
           when any
      (
       if (x == NULL || ...) S1
      |
       if@p2 (...) {
        ... when != snd_card_free(...,(T1)x,...)
            when != if (...) { <+... snd_card_free(...,(T1)x,...) ...+> }
            when != x = E1
            when != E1 = (T1)x
      (
        return \(0\|<+...x...+>\|ptr\);
      |
        return@p3 ...;
      )
      }
      )
      
      @ script:python @
      p1 << r.p1;
      p3 << r.p3;
      @@
      
      print "* file: %s snd_card_new: %s return: %s" % (p1[0].file,p1[0].line,p3[0].line)
      
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      73f6a12e
  6. 25 11月, 2008 1 次提交
  7. 16 11月, 2008 1 次提交
    • J
      ALSA: sound/pci/pcxhr/pcxhr.c: introduce missing kfree and pci_disable_device · d6f35e3f
      Julia Lawall 提交于
      Error handling code following a kzalloc should free the allocated data.
      The error handling code is adjusted to call pci_disable_device(pci); as
      well, as done later in the function
      
      The semantic match that finds the problem is as follows:
      (http://www.emn.fr/x-info/coccinelle/)
      
      // <smpl>
      @r exists@
      local idexpression x;
      statement S;
      expression E;
      identifier f,l;
      position p1,p2;
      expression *ptr != NULL;
      @@
      
      (
      if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
      |
      x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
      ...
      if (x == NULL) S
      )
      <... when != x
           when != if (...) { <+...x...+> }
      x->f = E
      ...>
      (
       return \(0\|<+...x...+>\|ptr\);
      |
       return@p2 ...;
      )
      
      @script:python@
      p1 << r.p1;
      p2 << r.p2;
      @@
      
      print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
      // </smpl>
      Signed-off-by: NJulia Lawall <julia@diku.dk>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      d6f35e3f
  8. 13 8月, 2008 1 次提交
  9. 27 5月, 2008 1 次提交
  10. 24 4月, 2008 2 次提交
  11. 01 2月, 2008 1 次提交
    • T
      [ALSA] Remove sound/driver.h · 9004acc7
      Takashi Iwai 提交于
      This header file exists only for some hacks to adapt alsa-driver
      tree.  It's useless for building in the kernel.  Let's move a few
      lines in it to sound/core.h and remove it.
      With this patch, sound/driver.h isn't removed but has just a single
      compile warning to include it.  This should be really killed in
      future.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      Signed-off-by: NJaroslav Kysela <perex@perex.cz>
      9004acc7
  12. 16 10月, 2007 3 次提交
  13. 11 5月, 2007 2 次提交
  14. 20 12月, 2006 1 次提交
  15. 13 7月, 2006 1 次提交
  16. 03 7月, 2006 1 次提交
  17. 23 6月, 2006 1 次提交
  18. 28 4月, 2006 2 次提交
  19. 29 3月, 2006 1 次提交
  20. 22 3月, 2006 2 次提交
  21. 22 1月, 2006 2 次提交
  22. 03 1月, 2006 1 次提交