1. 31 3月, 2011 1 次提交
  2. 22 3月, 2011 1 次提交
  3. 05 3月, 2011 1 次提交
    • J
      rtlwifi: usb parts should depend on CONFIG_USB · 1ffe4dd1
      John W. Linville 提交于
      ERROR: "usb_unanchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      ERROR: "usb_control_msg" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      ERROR: "usb_submit_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      ERROR: "usb_get_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      ERROR: "usb_kill_anchored_urbs" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      ERROR: "usb_put_dev" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      ERROR: "usb_free_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      ERROR: "usb_anchor_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      ERROR: "usb_alloc_urb" [drivers/net/wireless/rtlwifi/rtlwifi.ko] undefined!
      make[2]: *** [__modpost] Error 1
      make[1]: *** [modules] Error 2
      make: *** [sub-make] Error 2
      
      The USB-part of rtlwifi should depend on CONFIG_USB.  This also
      corrects the existing check for CONFIG_PCI to build pci.o.
      Reported-by: NGeert Uytterhoeven <geert@linux-m68k.org>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      1ffe4dd1
  4. 02 3月, 2011 1 次提交
    • C
      rtlwifi: Fix error registering rate-control · 375ff4c7
      Chaoming Li 提交于
      When a second module such as rtl8192ce or rtl8192cu links to rtlwifi, the attempt
      to register a rate-control mechanism fails with the warning shown below. The fix is to
      select the RC mechanism when rtlwifi is initialized.
      
      WARNING: at net/mac80211/rate.c:42 ieee80211_rate_control_register+0xc9/0x100 [mac80211]()
      Hardware name: HP Pavilion dv2700 Notebook PC
      Modules linked in: arc4 ecb rtl8192ce rtl8192cu(+) rtl8192c_common rtlwifi snd_hda_codec_conexant amd74xx(+) ide_core sg mac80211 snd_hda_intel snd_hda_codec i2c_nforce2 snd_pcm snd_timer cfg80211 snd k8temp hwmon serio_raw joydev i2c_core soundcore snd_page_alloc rfkill forcedeth video ac battery button ext3 jbd mbcache sd_mod ohci_hcd ahci libahci libata scsi_mod ehci_hcd usbcore fan processor thermal
      Pid: 2227, comm: modprobe Not tainted 2.6.38-rc6-wl+ #468
      Call Trace:
       [<ffffffff8104a3da>] ? warn_slowpath_common+0x7a/0xb0
       [<ffffffff8104a425>] ? warn_slowpath_null+0x15/0x20
       [<ffffffffa02de409>] ? ieee80211_rate_control_register+0xc9/0x100 [mac80211]
       [<ffffffffa03b3790>] ? rtl_rate_control_register+0x10/0x20 [rtlwifi]
       [<ffffffffa03ab9c9>] ? rtl_init_core+0x189/0x620 [rtlwifi]
       [<ffffffff811cfff8>] ? __raw_spin_lock_init+0x38/0x70
       [<ffffffffa03b9dea>] ? rtl_usb_probe+0x709/0x82e [rtlwifi]
       [<ffffffffa002a7fd>] ? usb_match_one_id+0x3d/0xc0 [usbcore]
       [<ffffffffa002aae9>] ? usb_probe_interface+0xb9/0x160 [usbcore]
       [<ffffffff8126ed19>] ? driver_probe_device+0x89/0x1a0
       [<ffffffff8126eed3>] ? __driver_attach+0xa3/0xb0
       [<ffffffff8126ee30>] ? __driver_attach+0x0/0xb0
       [<ffffffff8126dd4e>] ? bus_for_each_dev+0x5e/0x90
       [<ffffffff8126e9d9>] ? driver_attach+0x19/0x20
       [<ffffffff8126e5e8>] ? bus_add_driver+0x158/0x290
       [<ffffffff8126f151>] ? driver_register+0x71/0x140
       [<ffffffff811cfff8>] ? __raw_spin_lock_init+0x38/0x70
       [<ffffffffa002a2cc>] ? usb_register_driver+0xdc/0x190 [usbcore]
       [<ffffffffa0013000>] ? rtl8192cu_init+0x0/0x20 [rtl8192cu]
       [<ffffffffa001301e>] ? rtl8192cu_init+0x1e/0x20 [rtl8192cu]
       [<ffffffff810002cf>] ? do_one_initcall+0x3f/0x180
       [<ffffffff8108fd4b>] ? sys_init_module+0xbb/0x200
       [<ffffffff81002c7b>] ? system_call_fastpath+0x16/0x1b
       ---[ end trace 726271c07a47439e ]---
      rtlwifi:rtl_init_core():<0-0> rtl: Unable to register rtl_rc,use default RC !!
      ieee80211 phy0: Selected rate control algorithm 'minstrel_ht'
      Signed-off-by: NChaoming Li <chaoming_li@realsil.com.cn>
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      375ff4c7
  5. 01 3月, 2011 3 次提交
    • S
      net: use pci_dev->revision, again · ff938e43
      Sergei Shtylyov 提交于
      Several more network drivers that read the device's revision ID
      from the PCI configuration register were merged after the commit
      44c10138 (PCI: Change all drivers
      to use pci_device->revision), so it's time to do another pass of
      conversion to using the 'revision' field of 'struct pci_dev'...
      Signed-off-by: NSergei Shtylyov <sshtylyov@ru.mvista.com>
      Acked-by: N"John W. Linville" <linville@tuxdriver.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      ff938e43
    • A
      rtlwifi: fix places where uninitialized data is used · c2a7dca0
      Alessio Igor Bogani 提交于
      drivers/net/wireless/rtlwifi/rtl8192ce/trx.c: In function ‘rtl92ce_rx_query_desc’:
      drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:255:5: warning: ‘rf_rx_num’ may be used uninitialized in this function
      drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:257:12: warning: ‘total_rssi’ may be used uninitialized in this function
      drivers/net/wireless/rtlwifi/rtl8192ce/trx.c:466:6: warning: ‘weighting’ may be used uninitialized in this function
      
      This work was supported by a hardware donation from the CE Linux Forum.
      Signed-off-by: NAlessio Igor Bogani <abogani@kernel.org>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      c2a7dca0
    • A
      rtlwifi: Add the missing rcu_read_lock/unlock · 701c2be0
      Alessio Igor Bogani 提交于
      ===================================================
      [ INFO: suspicious rcu_dereference_check() usage. ]
      ---------------------------------------------------
      net/mac80211/sta_info.c:125 invoked rcu_dereference_check() without protection!
      
      other info that might help us debug this:
      
      rcu_scheduler_active = 1, debug_locks = 0
      5 locks held by wpa_supplicant/468:
       #0:  (rtnl_mutex){+.+.+.}, at: [<c1465d84>] rtnl_lock+0x14/0x20
       #1:  (&rdev->mtx){+.+.+.}, at: [<f84b8c2b>] cfg80211_mgd_wext_siwfreq+0x6b/0x170 [cfg80211]
       #2:  (&rdev->devlist_mtx){+.+.+.}, at: [<f84b8c37>] cfg80211_mgd_wext_siwfreq+0x77/0x170 [cfg80211]
       #3:  (&wdev->mtx){+.+.+.}, at: [<f84b8c44>] cfg80211_mgd_wext_siwfreq+0x84/0x170 [cfg80211]
       #4:  (&rtlpriv->locks.conf_mutex){+.+.+.}, at: [<f8506476>] rtl_op_bss_info_changed+0x26/0xc10 [rtlwifi]
      
      stack backtrace:
      Pid: 468, comm: wpa_supplicant Not tainted 2.6.38-rc6+ #79
      Call Trace:
       [<c108806a>] ? lockdep_rcu_dereference+0xaa/0xb0
       [<f8523d2c>] ? sta_info_get_bss+0x19c/0x1b0 [mac80211]
       [<f8523d62>] ? ieee80211_find_sta+0x22/0x40 [mac80211]
       [<f850661c>] ? rtl_op_bss_info_changed+0x1cc/0xc10 [rtlwifi]
       [<c153671c>] ? __mutex_unlock_slowpath+0x14c/0x160
       [<c153673d>] ? mutex_unlock+0xd/0x10
       [<f8507180>] ? rtl_op_config+0x120/0x310 [rtlwifi]
       [<c10896db>] ? trace_hardirqs_on+0xb/0x10
       [<f8522169>] ? ieee80211_bss_info_change_notify+0xf9/0x1f0 [mac80211]
       [<f8506450>] ? rtl_op_bss_info_changed+0x0/0xc10 [rtlwifi]
       [<f853646f>] ? ieee80211_set_channel+0xbf/0xd0 [mac80211]
       [<f84b5f41>] ? cfg80211_set_freq+0x121/0x180 [cfg80211]
       [<f85363b0>] ? ieee80211_set_channel+0x0/0xd0 [mac80211]
       [<f84b8ceb>] ? cfg80211_mgd_wext_siwfreq+0x12b/0x170 [cfg80211]
       [<f84b87eb>] ? cfg80211_wext_siwfreq+0x9b/0x100 [cfg80211]
       [<c153b98b>] ? sub_preempt_count+0x7b/0xb0
       [<c150f874>] ? ioctl_standard_call+0x74/0x3b0
       [<c1465d84>] ? rtnl_lock+0x14/0x20
       [<f84b8750>] ? cfg80211_wext_siwfreq+0x0/0x100 [cfg80211]
       [<c14568bd>] ? __dev_get_by_name+0x8d/0xb0
       [<c150fddb>] ? wext_handle_ioctl+0x16b/0x180
       [<f84b8750>] ? cfg80211_wext_siwfreq+0x0/0x100 [cfg80211]
       [<c145bc7a>] ? dev_ioctl+0x5ba/0x720
       [<c108a947>] ? __lock_acquire+0x3e7/0x19b0
       [<c1443b0b>] ? sock_ioctl+0x1eb/0x290
       [<c108bfa5>] ? lock_release_non_nested+0x95/0x2f0
       [<c1443920>] ? sock_ioctl+0x0/0x290
       [<c114d74d>] ? do_vfs_ioctl+0x7d/0x5c0
       [<c1112232>] ? might_fault+0x62/0xb0
       [<c113e3c6>] ? fget_light+0x226/0x390
       [<c1112278>] ? might_fault+0xa8/0xb0
       [<c114dd17>] ? sys_ioctl+0x87/0x90
       [<c1002f9f>] ? sysenter_do_call+0x12/0x38
      
      This work was supported by a hardware donation from the CE Linux Forum.
      Signed-off-by: NAlessio Igor Bogani <abogani@kernel.org>
      Signed-off-by: NLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      701c2be0
  6. 26 2月, 2011 1 次提交
    • J
      mac80211: make tx() operation return void · 7bb45683
      Johannes Berg 提交于
      The return value of the tx operation is commonly
      misused by drivers, leading to errors. All drivers
      will drop frames if they fail to TX the frame, and
      they must also properly manage the queues (if they
      didn't, mac80211 would already warn).
      
      Removing the ability for drivers to return a BUSY
      value also allows significant cleanups of the TX
      TX handling code in mac80211.
      
      Note that this also fixes a bug in ath9k_htc, the
      old "return -1" there was wrong.
      Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
      Tested-by: Sedat Dilek <sedat.dilek@googlemail.com> [ath5k]
      Acked-by: Gertjan van Wingerde <gwingerde@gmail.com> [rt2x00]
      Acked-by: Larry Finger <Larry.Finger@lwfinger.net> [b43, rtl8187, rtlwifi]
      Acked-by: Luciano Coelho <coelho@ti.com> [wl12xx]
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      7bb45683
  7. 25 2月, 2011 2 次提交
  8. 24 2月, 2011 5 次提交
  9. 22 2月, 2011 16 次提交
  10. 12 2月, 2011 5 次提交
  11. 28 1月, 2011 1 次提交
  12. 22 1月, 2011 1 次提交
  13. 20 1月, 2011 1 次提交
    • J
      mac80211: track receiver's aggregation reorder buffer size · 0b01f030
      Johannes Berg 提交于
      The aggregation code currently doesn't implement the
      buffer size negotiation. It will always request a max
      buffer size (which is fine, if a little pointless, as
      the mac80211 code doesn't know and might just use 0
      instead), but if the peer requests a smaller size it
      isn't possible to honour this request.
      
      In order to fix this, look at the buffer size in the
      addBA response frame, keep track of it and pass it to
      the driver in the ampdu_action callback when called
      with the IEEE80211_AMPDU_TX_OPERATIONAL action. That
      way the driver can limit the number of subframes in
      aggregates appropriately.
      
      Note that this doesn't fix any drivers apart from the
      addition of the new argument -- they all need to be
      updated separately to use this variable!
      Signed-off-by: NJohannes Berg <johannes.berg@intel.com>
      Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
      0b01f030
  14. 23 12月, 2010 1 次提交