Currently the child devices were not freed if the irq could not be requested.
This patch restructures the function, that in case of an error all previously
allocated resources are freed.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NPaul Fertser <fercerpav@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

Currently the pcf50633-regulator driver data is set to the pcf50633 core
structure, but the pcf50633-regulator remove handler assumes that it is set to
the regulator device. This patch fixes the issue by accessing the pcf506533
core structure through its parent device and setting the driver data to the
regulator device.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NPaul Fertser <fercerpav@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

Platform devices allocated with platform_device_alloc should use
platform_device_add_data to set the platform data, because kfree will be called
on the platform_data when the device is released.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NPaul Fertser <fercerpav@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

Since platform_device_add_data copies the passed data, the allocated
subdev_pdata is never freed. A simple fix would be to either free subdev_pdata
or put it onto the stack. But since the pcf50633 child devices can rely on
beeing children of the pcf50633 core device it's much more elegant to get access
to pcf50633 core structure through that link. This allows to get completly rid
of pcf5033_subdev_pdata.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NPaul Fertser <fercerpav@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

IRQs masking/unmasking should be less verbose.
Signed-off-by: NArnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: NPaul Fertser <fercerpav@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

When not using the i2c suspend/resume callbacks the i2c client resumed
before the i2c master.
Signed-off-by: NLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: NPaul Fertser <fercerpav@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

On gta02 hardware revision A5 it can actually bring the system down
during normal operating conditions so we disable it.
Signed-off-by: NPaul Fertser <fercerpav@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

Using the default kernel "events" workqueue causes problems with
synchronous adc readings if initiated from some task on the same
workqueue.

I had a deadlock trying to use pcf50633_adc_sync_read from a
power_supply class driver because the reading was initiated from the
workqueue and it waited for the irq processing to complete (to get the
result) and that was put on the same workqueue.
Signed-off-by: NPaul Fertser <fercerpav@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

For MFDs running regulator cores, we really want them to be brought up early
during boot.
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: NMike Rapoport <mike@compulab.co.il>

In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device.  Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used.  These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.

Cc: Samuel Ortiz <sameo@linux.intel.com>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Without this change Openmoko Freerunner (GTA02) bootstrap will deadlock.
As pointed out in other patches this issue is in the wild since the merge
of:

: commit 3aa551c9
: Author: Thomas Gleixner <tglx@linutronix.de>
: Date:   Mon Mar 23 18:28:15 2009 +0100
:
:    genirq: add threaded interrupt handler support
:
:    Add support for threaded interrupt handlers
Signed-off-by: NNelson Castillo <arhuaco@freaks-unidos.net>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: <balajirrao@openmoko.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

Removed duplicated #include <linux/device.h> in
  drivers/mfd/pcf50633-core.c
Signed-off-by: NHuang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@openedhand.com>

The i2c_device_id list is supposed to be zero-terminated.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Cc: Balaji Rao <balajirrao@openmoko.org>
Signed-off-by: NSamuel Ortiz <sameo@openedhand.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>

Remove references to set_irq_type and handle_level_irq which are not exported
to modules
Signed-off-by: NBalaji Rao <balajirrao@openmoko.org>
Signed-off-by: NSamuel Ortiz <sameo@openedhand.com>

This patch implements the core of the PCF50633 driver. This core driver has
generic register read/write functions and does interrupt management for its
sub devices.
Signed-off-by: NBalaji Rao <balajirrao@openmoko.org>
Cc: Andy Green <andy@openmoko.com>
Signed-off-by: NSamuel Ortiz <sameo@openedhand.com>