1. 16 6月, 2016 3 次提交
    • D
      drm/i915: Signal drm events for atomic · 1f7528c4
      Daniel Vetter 提交于
      This is part of what atomic must implement. And it's also required
      to be able to use the helper nonblocking support.
      
      v2: Always send out the drm event, remove the planes_changed check.
      Reviewed-by: NMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: http://patchwork.freedesktop.org/patch/msgid/1465827229-1704-1-git-send-email-daniel.vetter@ffwll.ch
      1f7528c4
    • D
      Merge remote-tracking branch 'airlied/drm-next' into drm-intel-next-queued · c1994121
      Daniel Vetter 提交于
      Backmerge drm-next to get at the nonblocking atomic helpers, needed to
      merge the i915 conversion.
      Signed-off-by: NDaniel Vetter <daniel.vetter@intel.com>
      c1994121
    • D
      Merge tag 'topic/drm-misc-2016-06-15' of git://anongit.freedesktop.org/drm-intel into drm-next · a0877f52
      Dave Airlie 提交于
      - best_encoder cleanup from Boris.
      - drm_simple_display_pipe helpers from Noralf. Looks really neat imo, and
        there's 2-3 in-flight drivers which look like they could/should use it.
        Anyway, with this we have now helpers and everything in place to write
        drivers for simple hw with fewer complexity in the driver than what
        fbdev would need. That was the last complaint I've heard from embedded
        folks after we made atomic happen. Mission accomplished!
      - nonblocking commit helpers for atomic, plus a bunch of driver patches
        for that.
      - Prep patch from Laurent for cleaned up pixel format functions.
      - More of Gustavo's cleanup for drm vblank functions.
      - and a few oddball things in between
      
      Plus the merge of docs-next to prep the docbook->sphinx conversion as
      discussed. Jon cc'ed as fyi.
      
      * tag 'topic/drm-misc-2016-06-15' of git://anongit.freedesktop.org/drm-intel: (108 commits)
        drm/atomic-helpers: Clear up cleanup_done a bit
        drm/atomic-helpers: Stall on the right commit
        drm/vmwgfx: use *_32_bits() macros
        drm/virtio: Don't reinvent a flipping wheel
        drm/i915: Fix missing unlock on error in i915_ppgtt_info()
        drm/gma500: use drm_crtc_vblank_{on,off}()
        drm/radeon: use crtc directly in drm_crtc_vblank_put()
        drm/amdgpu: use crtc directly in drm_crtc_vblank_put()
        drm/radeon: use drm_crtc_vblank_{on,off}()
        drm/amdgpu: use drm_crtc_vblank_{on,off}()
        drm: make drm_vblank_{get,put}() static
        drm: remove legacy drm_arm_vblank_event()
        drm: remove legacy drm_send_vblank_event()
        drm/nouveau: replace legacy vblank helpers
        drm/prime: fix error path deadlock fail
        drm/dsi: Add uevent callback
        drm: fb: cma: fix memory leak
        drm: i915: Rely on the default ->best_encoder() behavior where appropriate
        drm: Add helper for simple display pipeline
        drm/bridge: dw-hdmi: Use drm_atomic_helper_best_encoder()
        ...
      a0877f52
  2. 15 6月, 2016 5 次提交
    • D
      drm/atomic-helpers: Clear up cleanup_done a bit · 7deef7f1
      Daniel Vetter 提交于
      It's not obvious at first sight that this is a fastpath, make that
      clearer with a goto. Fallout from a discussion with Liviu on irc.
      
      v2: Drop bogus hunks that crept in.
      
      v3: Make it compile.
      
      Cc: Liviu.Dudau@arm.com
      Acked-by: Liviu.Dudau@arm.com
      Signed-off-by: NDaniel Vetter <daniel.vetter@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: http://patchwork.freedesktop.org/patch/msgid/1465986266-2831-1-git-send-email-daniel.vetter@ffwll.ch
      7deef7f1
    • D
      drm/atomic-helpers: Stall on the right commit · 723c3e55
      Daniel Vetter 提交于
      stall_checks carefully picked out the right commit to stall on, then
      promptly used the wrong variable. Due to the break in the next loop
      iteration this could be the 3rd commit, or if the list only has 2
      entries commit would now point into the struct drm_crtc itself, at
      some offset. Hilarity eventually ensues.
      
      For added safety, also break right away instead of iterating once
      more, but the real fix is waiting on stall_commit instead of commit.
      Reported-and-tested-by: NLiviu Dudau <Liviu.Dudau@arm.com>
      Cc: Liviu Dudau <Liviu.Dudau@arm.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@intel.com>
      Reviewed-by: NLiviu Dudau <Liviu.Dudau@arm.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: http://patchwork.freedesktop.org/patch/msgid/1465926658-10110-1-git-send-email-daniel.vetter@ffwll.ch
      723c3e55
    • P
      drm/vmwgfx: use *_32_bits() macros · 0e7c875d
      Paul Bolle 提交于
      Use the upper_32_bits() macro instead of the four line equivalent that
      triggers a GCC warning on 32 bits x86:
          drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function 'vmw_cmdbuf_header_submit':
          drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:297:25: warning: right shift count >= width of type [-Wshift-count-overflow]
             val = (header->handle >> 32);
                                   ^
      
      And use the lower_32_bits() macro instead of and-ing with a 32 bits
      mask.
      Signed-off-by: NPaul Bolle <pebolle@tiscali.nl>
      Acked-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: http://patchwork.freedesktop.org/patch/msgid/1457000770-2317-1-git-send-email-pebolle@tiscali.nl
      0e7c875d
    • L
      drm/i915/ilk: Don't disable SSC source if it's in use · 1c1a24d2
      Lyude 提交于
      Thanks to Ville Syrjälä for pointing me towards the cause of this issue.
      
      Unfortunately one of the sideaffects of having the refclk for a DPLL set
      to SSC is that as long as it's set to SSC, the GPU will prevent us from
      powering down any of the pipes or transcoders using it. A couple of
      BIOSes enable SSC in both PCH_DREF_CONTROL and in the DPLL
      configurations. This causes issues on the first modeset, since we don't
      expect SSC to be left on and as a result, can't successfully power down
      the pipes or the transcoders using it. Here's an example from this Dell
      OptiPlex 990:
      
      [drm:intel_modeset_init] SSC enabled by BIOS, overriding VBT which says disabled
      [drm:intel_modeset_init] 2 display pipes available.
      [drm:intel_update_cdclk] Current CD clock rate: 400000 kHz
      [drm:intel_update_max_cdclk] Max CD clock rate: 400000 kHz
      [drm:intel_update_max_cdclk] Max dotclock rate: 360000 kHz
      vgaarb: device changed decodes: PCI:0000:00:02.0,olddecodes=io+mem,decodes=io+mem:owns=io+mem
      [drm:intel_crt_reset] crt adpa set to 0xf40000
      [drm:intel_dp_init_connector] Adding DP connector on port C
      [drm:intel_dp_aux_init] registering DPDDC-C bus for card0-DP-1
      [drm:ironlake_init_pch_refclk] has_panel 0 has_lvds 0 has_ck505 0
      [drm:ironlake_init_pch_refclk] Disabling SSC entirely
      … later we try committing the first modeset …
      [drm:intel_dump_pipe_config] [CRTC:26][modeset] config ffff88041b02e800 for pipe A
      [drm:intel_dump_pipe_config] cpu_transcoder: A
      …
      [drm:intel_dump_pipe_config] dpll_hw_state: dpll: 0xc4016001, dpll_md: 0x0, fp0: 0x20e08, fp1: 0x30d07
      [drm:intel_dump_pipe_config] planes on this crtc
      [drm:intel_dump_pipe_config] STANDARD PLANE:23 plane: 0.0 idx: 0 enabled
      [drm:intel_dump_pipe_config]     FB:42, fb = 800x600 format = 0x34325258
      [drm:intel_dump_pipe_config]     scaler:0 src (0, 0) 800x600 dst (0, 0) 800x600
      [drm:intel_dump_pipe_config] CURSOR PLANE:25 plane: 0.1 idx: 1 disabled, scaler_id = 0
      [drm:intel_dump_pipe_config] STANDARD PLANE:27 plane: 0.1 idx: 2 disabled, scaler_id = 0
      [drm:intel_get_shared_dpll] CRTC:26 allocated PCH DPLL A
      [drm:intel_get_shared_dpll] using PCH DPLL A for pipe A
      [drm:ilk_audio_codec_disable] Disable audio codec on port C, pipe A
      [drm:intel_disable_pipe] disabling pipe A
      ------------[ cut here ]------------
      WARNING: CPU: 1 PID: 130 at drivers/gpu/drm/i915/intel_display.c:1146 intel_disable_pipe+0x297/0x2d0 [i915]
      pipe_off wait timed out
      …
      ---[ end trace 94fc8aa03ae139e8 ]---
      [drm:intel_dp_link_down]
      [drm:ironlake_crtc_disable [i915]] *ERROR* failed to disable transcoder A
      
      Later modesets succeed since they reset the DPLL's configuration anyway,
      but this is enough to get stuck with a big fat warning in dmesg.
      
      A better solution would be to add refcounts for the SSC source, but for
      now leaving the source clock on should suffice.
      
      Changes since v4:
       - Fix calculation of final for systems with LVDS panels (fixes BUG() on
         CI test suite)
      Changes since v3:
       - Move temp variable into loop
       - Move checks for using_ssc_source to after we've figured out has_ck505
       - Add using_ssc_source to debug output
      Changes since v2:
       - Fix debug output for when we disable the CPU source
      Changes since v1:
       - Leave the SSC source clock on instead of just shutting it off on all
         of the DPLL configurations.
      
      Cc: stable@vger.kernel.org
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NLyude <cpaul@redhat.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Link: http://patchwork.freedesktop.org/patch/msgid/1465916649-10228-1-git-send-email-cpaul@redhat.com
      1c1a24d2
    • D
      Merge tag 'sphinx-4.8' of git://git.lwn.net/linux into topic/drm-misc · db5dfef7
      Daniel Vetter 提交于
      Stable tag for sphinx work
      
      Pull current state of the sphinx rework from Jonathan into drm-misc so
      that we can start converting gpu.tmpl.
      Signed-off-by: NDaniel Vetter <daniel.vetter@intel.com>
      db5dfef7
  3. 14 6月, 2016 22 次提交
  4. 13 6月, 2016 10 次提交