1. 25 4月, 2019 2 次提交
  2. 20 4月, 2019 1 次提交
  3. 02 4月, 2019 1 次提交
  4. 22 3月, 2019 1 次提交
  5. 21 3月, 2019 1 次提交
  6. 15 3月, 2019 1 次提交
  7. 06 3月, 2019 1 次提交
  8. 05 3月, 2019 1 次提交
  9. 29 1月, 2019 2 次提交
    • C
      drm/i915: Enlarge vma->pin_count · b18fe4be
      Chris Wilson 提交于
      Previously we only accommodated having a vma pinned by a small number of
      users, with the maximum being pinned for use by the display engine. As
      such, we used a small bitfield only large enough to allow the vma to
      be pinned twice (for back/front buffers) in each scanout plane. Keeping
      the maximum permissible pin_count small allows us to quickly catch a
      potential leak. However, as we want to split a 4096B page into 64
      different cachelines and pin each cacheline for use by a different
      timeline, we will exceed the current maximum permissible vma->pin_count
      and so time has come to enlarge it.
      
      Whilst we are here, try to pull together the similar bits:
      
      Address/layout specification:
       - bias, mappable, zone_4g: address limit specifiers
       - fixed: address override, limits still apply though
       - high: not strictly an address limit, but an address direction to search
      
      Search controls:
       - nonblock, nonfault, noevict
      
      v2: Rewrite the guideline comment on bit consumption.
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      Reviewed-by: NJohn Harrison <john.C.Harrison@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20190128181812.22804-2-chris@chris-wilson.co.uk
      b18fe4be
    • C
      drm/i915: Stop tracking MRU activity on VMA · 499197dc
      Chris Wilson 提交于
      Our goal is to remove struct_mutex and replace it with fine grained
      locking. One of the thorny issues is our eviction logic for reclaiming
      space for an execbuffer (or GTT mmaping, among a few other examples).
      While eviction itself is easy to move under a per-VM mutex, performing
      the activity tracking is less agreeable. One solution is not to do any
      MRU tracking and do a simple coarse evaluation during eviction of
      active/inactive, with a loose temporal ordering of last
      insertion/evaluation. That keeps all the locking constrained to when we
      are manipulating the VM itself, neatly avoiding the tricky handling of
      possible recursive locking during execbuf and elsewhere.
      
      Note that discarding the MRU (currently implemented as a pair of lists,
      to avoid scanning the active list for a NONBLOCKING search) is unlikely
      to impact upon our efficiency to reclaim VM space (where we think a LRU
      model is best) as our current strategy is to use random idle replacement
      first before doing a search, and over time the use of softpinned 48b
      per-ppGTT is growing (thereby eliminating any need to perform any eviction
      searches, in theory at least) with the remaining users being found on
      much older devices (gen2-gen6).
      
      v2: Changelog and commentary rewritten to elaborate on the duality of a
      single list being both an inactive and active list.
      v3: Consolidate bool parameters into a single set of flags; don't
      comment on the duality of a single variable being a multiplicity of
      bits.
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
      Reviewed-by: NTvrtko Ursulin <tvrtko.ursulin@intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20190128102356.15037-1-chris@chris-wilson.co.uk
      499197dc
  10. 25 1月, 2019 1 次提交
  11. 15 1月, 2019 1 次提交
  12. 27 12月, 2018 1 次提交
  13. 06 11月, 2018 3 次提交
  14. 03 11月, 2018 1 次提交
  15. 30 10月, 2018 1 次提交
  16. 26 10月, 2018 2 次提交
  17. 01 9月, 2018 1 次提交
  18. 28 8月, 2018 1 次提交
  19. 30 7月, 2018 1 次提交
  20. 27 7月, 2018 1 次提交
    • J
      drm/i915/guc: Move the pin bias value from GuC to GGTT · dd18cedf
      Jakub Bartmiński 提交于
      Removing the pin bias from GuC allows us to not check for GuC every time
      we pin a context, which fixes the assertion error on unresolved GuC
      platform default in mock contexts selftest.
      
      It also seems that we were using uninitialized WOPCM variables when
      setting the GuC pin bias. The pin bias has to be set after the WOPCM,
      but before the call to i915_gem_contexts_init where the first contexts
      are pinned.
      
      v2:
      This also makes it so that there's no need to set GuC variables from
      within the WOPCM init function or to move the WOPCM init, while keeping
      the correct initialization order. Also for mock tests the pin bias is
      left at 0 and we make sure that the pin bias with GuC will not be
      smaller than without GuC.
      
      v3:
      Avoid unused i915 in intel_guc_ggtt_offset if debug is disabled.
      
      v4:
      Squash with WOPCM init reordering.
      Moved the i915_ggtt_pin_bias helper to this patch, and made some
      functions use it instead of directly dereferencing i915->ggtt.
      
      v5:
      Since we now don't use wopcm.guc.base for the pin bias there's no need to
      validate it. It also has already been verified in WOPCM init.
      
      v6:
      Deleted the now unnecessarily introduced includes from previous versions.
      Dropped naming changes from dev_priv to i915 for better patch readability.
      
      v7:
      Changed some comments to make more sense in the context they're in.
      
      v8:
      Moved and renamed the function which now returns the wopcm.guc.size to
      intel_guc.c:intel_guc_reserved_gtt_size to avoid any possible confusion
      with the pin_bias in ggtt, which should be used for pinning.
      Fixed patch not applying or the most recent upstream.
      
      Fixes: f7dc0157 ("drm/i915/uc: Fetch GuC/HuC firmwares from guc/huc specific init")
      Testcase: igt/drv_selftest/mock_contexts #GuC
      Signed-off-by: NJakub Bartmiński <jakub.bartminski@intel.com>
      Cc: Chris Wilson <chris@chris-wilson.co.uk>
      Cc: Michał Winiarski <michal.winiarski@intel.com>
      Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
      Reviewed-by: NChris Wilson <chris@chris-wilson.co.uk>
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      Link: https://patchwork.freedesktop.org/patch/msgid/20180727141148.30874-3-jakub.bartminski@intel.com
      dd18cedf
  21. 13 7月, 2018 1 次提交
  22. 11 7月, 2018 1 次提交
  23. 05 7月, 2018 2 次提交
  24. 15 6月, 2018 3 次提交
  25. 14 6月, 2018 1 次提交
  26. 13 6月, 2018 1 次提交
  27. 12 6月, 2018 1 次提交
  28. 11 6月, 2018 1 次提交
    • C
      drm/i915/ringbuffer: Fix context restore upon reset · b3ee09a4
      Chris Wilson 提交于
      The discovery with trying to enable full-ppgtt was that we were
      completely failing to the load both the mm and context following the
      reset. Although we were performing mmio to set the PP_DIR (per-process
      GTT) and CCID (context), these were taking no effect (the assumption was
      that this would trigger reload of the context and restore the page
      tables). It was not until we performed the LRI + MI_SET_CONTEXT in a
      following context switch would anything occur.
      
      Since we are then required to reset the context image and PP_DIR using
      CS commands, we place those commands into every batch. The hardware
      should recognise the no-ops and eliminate the expensive context loads,
      but we still have to pay the cost of using cross-powerwell register
      writes. In practice, this has no effect on actual context switch times,
      and only adds a few hundred nanoseconds to no-op switches. We can improve
      the latter by eliminating the w/a around known no-op switches, but there
      is an ulterior motive to keeping them.
      
      Always emitting the context switch at the beginning of the request (and
      relying on HW to skip unneeded switches) does have one key advantage.
      Should we implement request reordering on Haswell, we will not know in
      advance what the previous executing context was on the GPU and so we
      would not be able to elide the MI_SET_CONTEXT commands ourselves and
      always have to emit them. Having our hand forced now actually prepares
      us for later.
      
      Now since that context and mm follow the request, we no longer (and not
      for a long time since requests took over!) require a trace point to tell
      when we write the switch into the ring, since it is always. (This is
      even more important when you remember that simply writing into the ring
      bears no relation to the current mm.)
      
      v2: Sandybridge has to agree to use LRI as well.
      
      Testcase: igt/drv_selftests/live_hangcheck
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
      Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
      Cc: Matthew Auld <matthew.william.auld@gmail.com>
      Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
      Reviewed-by: NJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
      Link: https://patchwork.freedesktop.org/patch/msgid/20180611110845.31890-1-chris@chris-wilson.co.uk
      b3ee09a4
  29. 08 6月, 2018 1 次提交
  30. 06 6月, 2018 1 次提交
  31. 13 5月, 2018 1 次提交
  32. 03 5月, 2018 1 次提交