1. 21 9月, 2012 2 次提交
    • M
      can: ti_hecc: fix oops during rmmod · ab04c8bd
      Marc Kleine-Budde 提交于
      This patch fixes an oops which occurs when unloading the driver, while the
      network interface is still up. The problem is that first the io mapping is
      teared own, then the CAN device is unregistered, resulting in accessing the
      hardware's iomem:
      
      [  172.744232] Unable to handle kernel paging request at virtual address c88b0040
      [  172.752441] pgd = c7be4000
      [  172.755645] [c88b0040] *pgd=87821811, *pte=00000000, *ppte=00000000
      [  172.762207] Internal error: Oops: 807 [#1] PREEMPT ARM
      [  172.767517] Modules linked in: ti_hecc(-) can_dev
      [  172.772430] CPU: 0    Not tainted  (3.5.0alpha-00037-g3554cc0 #126)
      [  172.778961] PC is at ti_hecc_close+0xb0/0x100 [ti_hecc]
      [  172.784423] LR is at __dev_close_many+0x90/0xc0
      [  172.789123] pc : [<bf00c768>]    lr : [<c033be58>]    psr: 60000013
      [  172.789123] sp : c5c1de68  ip : 00040081  fp : 00000000
      [  172.801025] r10: 00000001  r9 : c5c1c000  r8 : 00100100
      [  172.806457] r7 : c5d0a48c  r6 : c5d0a400  r5 : 00000000  r4 : c5d0a000
      [  172.813232] r3 : c88b0000  r2 : 00000001  r1 : c5d0a000  r0 : c5d0a000
      [  172.820037] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment user
      [  172.827423] Control: 10c5387d  Table: 87be4019  DAC: 00000015
      [  172.833404] Process rmmod (pid: 600, stack limit = 0xc5c1c2f0)
      [  172.839447] Stack: (0xc5c1de68 to 0xc5c1e000)
      [  172.843994] de60:                   bf00c6b8 c5c1dec8 c5d0a000 c5d0a000 00200200 c033be58
      [  172.852478] de80: c5c1de44 c5c1dec8 c5c1dec8 c033bf2c c5c1de90 c5c1de90 c5d0a084 c5c1de44
      [  172.860992] dea0: c5c1dec8 c033c098 c061d3dc c5d0a000 00000000 c05edf28 c05edb34 c000d724
      [  172.869476] dec0: 00000000 c033c2f8 c5d0a084 c5d0a084 00000000 c033c370 00000000 c5d0a000
      [  172.877990] dee0: c05edb00 c033c3b8 c5d0a000 bf00d3ac c05edb00 bf00d7c8 bf00d7c8 c02842dc
      [  172.886474] df00: c02842c8 c0282f90 c5c1c000 c05edb00 bf00d7c8 c0283668 bf00d7c8 00000000
      [  172.894989] df20: c0611f98 befe2f80 c000d724 c0282d10 bf00d804 00000000 00000013 c0068a8c
      [  172.903472] df40: c5c538e8 685f6974 00636365 c61571a8 c5cb9980 c61571a8 c6158a20 c00c9bc4
      [  172.911987] df60: 00000000 00000000 c5cb9980 00000000 c5cb9980 00000000 c7823680 00000006
      [  172.920471] df80: bf00d804 00000880 c5c1df8c 00000000 000d4267 befe2f80 00000001 b6d90068
      [  172.928985] dfa0: 00000081 c000d5a0 befe2f80 00000001 befe2f80 00000880 b6d90008 00000008
      [  172.937469] dfc0: befe2f80 00000001 b6d90068 00000081 00000001 00000000 befe2eac 00000000
      [  172.945983] dfe0: 00000000 befe2b18 00023ba4 b6e6addc 60000010 befe2f80 a8e00190 86d2d344
      [  172.954498] [<bf00c768>] (ti_hecc_close+0xb0/0x100 [ti_hecc]) from [<c033be58>] (__dev__registered_many+0xc0/0x2a0)
      [  172.984161] [<c033c098>] (rollback_registered_many+0xc0/0x2a0) from [<c033c2f8>] (rollback_registered+0x20/0x30)
      [  172.994750] [<c033c2f8>] (rollback_registered+0x20/0x30) from [<c033c370>] (unregister_netdevice_queue+0x68/0x98)
      [  173.005401] [<c033c370>] (unregister_netdevice_queue+0x68/0x98) from [<c033c3b8>] (unregister_netdev+0x18/0x20)
      [  173.015899] [<c033c3b8>] (unregister_netdev+0x18/0x20) from [<bf00d3ac>] (ti_hecc_remove+0x60/0x80 [ti_hecc])
      [  173.026245] [<bf00d3ac>] (ti_hecc_remove+0x60/0x80 [ti_hecc]) from [<c02842dc>] (platform_drv_remove+0x14/0x18)
      [  173.036712] [<c02842dc>] (platform_drv_remove+0x14/0x18) from [<c0282f90>] (__device_release_driver+0x7c/0xbc)
      
      Cc: stable <stable@vger.kernel.org>
      Cc: Anant Gole <anantgole@ti.com>
      Tested-by: NJan Luebbe <jlu@pengutronix.de>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      ab04c8bd
    • I
      can: janz-ican3: fix support for older hardware revisions · e21093ef
      Ira W. Snyder 提交于
      The Revision 1.0 Janz CMOD-IO Carrier Board does not have support for
      the reset registers. To support older hardware, the code is changed to
      use the hardware reset register on the Janz VMOD-ICAN3 hardware itself.
      
      Cc: stable <stable@vger.kernel.org>
      Signed-off-by: NIra W. Snyder <iws@ovro.caltech.edu>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      e21093ef
  2. 04 9月, 2012 1 次提交
  3. 24 8月, 2012 2 次提交
  4. 31 7月, 2012 1 次提交
  5. 20 7月, 2012 9 次提交
  6. 17 7月, 2012 3 次提交
  7. 03 7月, 2012 1 次提交
    • H
      can: flexcan: add hardware controller version support · 30c1e672
      Hui Wang 提交于
      At least in the i.MX series, the flexcan contrller divides into ver_3
      and ver_10, current driver is for ver_3 controller.
      
      i.MX6 has ver_10 controller, it has more reigsters than ver_3 has.
      The rxfgmask (Rx FIFO Global Mask) register is one of the new added.
      Its reset value is 0xffffffff, this means ID Filter Table must be
      checked when receive a packet, but the driver is designed to accept
      everything during the chip start, we need to clear this register to
      follow this design.
      
      Use the data entry of the struct of_device_id to point chip specific
      info, we can set hardware version for each platform.
      
      Cc: linux-can@vger.kernel.org
      Cc: Marc Kleine-Budde <mkl@pengutronix.de>
      Cc: Wolfgang Grandegger <wg@grandegger.com>
      Cc: Shawn Guo <shawn.guo@linaro.org>
      Signed-off-by: NHui Wang <jason77.wang@gmail.com>
      [mkl: add id_table support]
      Tested-by: NHui Wang <jason77.wang@gmail.com>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      30c1e672
  8. 02 7月, 2012 3 次提交
  9. 27 6月, 2012 1 次提交
  10. 21 6月, 2012 1 次提交
  11. 20 6月, 2012 3 次提交
  12. 16 6月, 2012 1 次提交
  13. 07 6月, 2012 3 次提交
    • A
      can: c_can: Add support for Bosch D_CAN controller · 69927fcc
      AnilKumar Ch 提交于
      This patch adds the support for D_CAN controller driver to the existing
      C_CAN driver.
      
      Bosch D_CAN controller is a full-CAN implementation which is compliant
      to CAN protocol version 2.0 part A and B. Bosch D_CAN user manual can be
      obtained from: http://www.semiconductors.bosch.de/media/en/pdf/
      ipmodules_1/can/d_can_users_manual_111.pdf
      
      A new array is added for accessing the d_can registers, according to d_can
      controller register space.
      
      Current D_CAN implementation has following limitations, this is done
      to avoid large changes to the C_CAN driver.
      1. Message objects are limited to 32, 16 for RX and 16 for TX. C_CAN IP
         supports upto 32 message objects but in case of D_CAN we can configure
         upto 128 message objects.
      2. Using two 16bit reads/writes for accessing the 32bit D_CAN registers.
      3. These patches have been tested on little endian machine, there might
         be some hidden endian-related issues due to the nature of the accesses
         (32-bit registers accessed as 2 16-bit registers). However, I do not
         have a big-endian D_CAN implementation to confirm.
      Signed-off-by: NAnilKumar Ch <anilkumar@ti.com>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      69927fcc
    • A
      can: c_can: Move overlay structure to array with offset as index · 33f81009
      AnilKumar Ch 提交于
      c_can uses overlay structure for accessing c_can module registers.
      With this kind of implementation it is difficult to add one more ip
      which is similar to c_can in functionality but different register
      offsets.
      
      This patch changes the overlay structure implementation to an array
      with register offset as index. This way we can overcome the above
      limitation.
      Signed-off-by: NAnilKumar Ch <anilkumar@ti.com>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      33f81009
    • J
      drivers: net: Remove casts to same type · c2fd03a0
      Joe Perches 提交于
      Adding casts of objects to the same type is unnecessary
      and confusing for a human reader.
      
      For example, this cast:
      
              int y;
              int *p = (int *)&y;
      
      I used the coccinelle script below to find and remove these
      unnecessary casts.  I manually removed the conversions this
      script produces of casts with __force, __iomem and __user.
      
      @@
      type T;
      T *p;
      @@
      
      -       (T *)p
      +       p
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      c2fd03a0
  14. 04 6月, 2012 4 次提交
    • J
      can: cc770: Fix likely misuse of | for & · dc605dbd
      Joe Perches 提交于
      Using | with a constant is always true.
      Likely this should have be &.
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      dc605dbd
    • A
      can: c_can: fix race condition in c_can_open() · f461f27a
      AnilKumar Ch 提交于
      Fix the issue of C_CAN interrupts getting disabled forever when canconfig
      utility is used multiple times. According to NAPI usage we disable all
      the hardware interrupts in ISR and re-enable them in poll(). Current
      implementation calls napi_enable() after hardware interrupts are enabled.
      If we get any interrupts between these two steps then we do not process
      those interrupts because napi is not enabled. Mostly these interrupts
      come because of STATUS is not 0x7 or ERROR interrupts. If napi_enable()
      happens before HW interrupts enabled then c_can_poll() function will be
      called eventual re-enabling.
      
      This patch moves the napi_enable() call before interrupts enabled.
      
      Cc: stable@kernel.org # 2.6.39+
      Signed-off-by: NAnilKumar Ch <anilkumar@ti.com>
      Acked-by: NWolfgang Grandegger <wg@grandegger.com>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      f461f27a
    • A
      can: c_can: fix an interrupt thrash issue with c_can driver · 148c87c8
      AnilKumar Ch 提交于
      This patch fixes an interrupt thrash issue with c_can driver.
      
      In c_can_isr() function interrupts are disabled and enabled only in
      c_can_poll() function. c_can_isr() & c_can_poll() both read the
      irqstatus flag. However, irqstatus is always read as 0 in c_can_poll()
      because all C_CAN interrupts are disabled in c_can_isr(). This causes
      all interrupts to be re-enabled in c_can_poll() which in turn causes
      another interrupt since the event is not really handled. This keeps
      happening causing a flood of interrupts.
      
      To fix this, read the irqstatus register in isr and use the same cached
      value in the poll function.
      
      Cc: stable@kernel.org # 2.6.39+
      Signed-off-by: NAnilKumar Ch <anilkumar@ti.com>
      Acked-by: NWolfgang Grandegger <wg@grandegger.com>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      148c87c8
    • A
      can: c_can: fix "BUG! echo_skb is occupied!" during transmit · 617cacce
      AnilKumar Ch 提交于
      This patch fixes an issue with transmit routine, which causes
      "can_put_echo_skb: BUG! echo_skb is occupied!" message when
      using "cansequence -p" on D_CAN controller.
      
      In c_can driver, while transmitting packets tx_echo flag holds
      the no of can frames put for transmission into the hardware.
      
      As the comment above c_can_do_tx() indicates, if we find any packet
      which is not transmitted then we should stop looking for more.
      In the current implementation this is not taken care of causing the
      said message.
      
      Also, fix the condition used to find if the packet is transmitted
      or not. Current code skips the first tx message object and ends up
      checking one extra invalid object.
      
      While at it, fix the comment on top of c_can_do_tx() to use the
      terminology "packet" instead of "package" since it is more
      standard.
      
      Cc: stable@kernel.org # 2.6.39+
      Signed-off-by: NAnilKumar Ch <anilkumar@ti.com>
      Acked-by: NWolfgang Grandegger <wg@grandegger.com>
      Signed-off-by: NMarc Kleine-Budde <mkl@pengutronix.de>
      617cacce
  15. 24 5月, 2012 1 次提交
  16. 12 5月, 2012 1 次提交
  17. 18 4月, 2012 1 次提交
  18. 17 4月, 2012 2 次提交
反馈
建议
客服 返回
顶部