It does not make sense to write new value only when all the bit_mask
bits are zero.
We need to write new value if the bit mask fields of new value is
not equal to old value.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

In the current code, every time we set a TPS6586x GPIO pin,
the tps6586x_gpio_set function is resetting all other GPIO pins.
We need to update the right GPIOxOUT bit of the GPIOSET2 register instead
of overriding the full value.

Tested by setting sequentially GPIO2 and GPIO3 and verifying the
pins voltage.

Change-Id: I560edde146c5425cce37432c4ee91569eea5adcf
Signed-off-by: NVincent Palatin <vpalatin@chromium.org>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

Converted with coccinelle.
Signed-off-by: NThomas Gleixner <tglx@linutronix.de>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

When using a fixed voltage regulator triggered by a TPS6586x GPIO,
this allows to declare and initialize it conveniently from the "subdev" list.
Signed-off-by: NVincent Palatin <vpalatin@chromium.org>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

tps6586 does not support burst writes. i2c writes have to be
1 byte at a time.

Cc: stable@kernel.org
Signed-off-by: NVarun Wadekar <vwadekar@nvidia.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

The genirq core is being updated to supply struct irq_data to irq_chip
operations rather than an irq number. Update the tps6586x driver to the
new APIs.
Signed-off-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: NMike Rapoport <mike@compulab.co.il>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

... and convert it to a dev_info print at probe time.

There are many variants of this chip with different values of VERSIONCRC.
The set of values is large, and not useful to enumerate. All are SW
compatible. The difference lies in default settings of the various power
rails, and other similar differences. The driver, or clients of the
driver, shouldn't be affected by this, since all rails should be
programmed into the desired state in all cases for correct operation.
Derived-from-code-by: NAndrew Chew <achew@nvidia.com>
Signed-off-by: NStephen Warren <swarren@nvidia.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

The interface for this device should be identical to that of the
TPS658521A.
Signed-off-by: NAndrew Chew <achew@nvidia.com>
Acked-by: NMike Rapoport <mike@compulab.co.il>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

Add support for enabling and disabling tps6586x subdevice interrupts
Signed-off-by: NGary King <gking@nvidia.com>
Acked-by: NMike Rapoport <mike@compulab.co.il>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

1. return -ENOMEM if platform_device_alloc() fail.
2. call platform_device_put() if platform_device_add() fail.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Acked-by: NMike Rapoport <mike@compulab.co.il>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

For the resources allocated in tps6586x_i2c_probe(),
we need to free it in tps6586x_i2c_remove().
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>

Add mfd core driver for TPS6586x PMICs family.
The driver provides I/O access for the sub-device drivers and performs
regstration of the sub-devices based on the platform requirements.
In addition it implements GPIOlib interface for the chip GPIOs.

TODO:
        - add interrupt support
        - add platform data for PWM, backlight leds and charger
Signed-off-by: NMike Rapoport <mike@compulab.co.il>
Signed-off-by: NMike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: NSamuel Ortiz <sameo@linux.intel.com>