1. 18 6月, 2006 12 次提交
  2. 14 6月, 2006 5 次提交
  3. 13 6月, 2006 1 次提交
  4. 12 6月, 2006 5 次提交
    • P
      [PATCH] Fix for the PPTP hangs that have been reported · 289a1e99
      Paul Mackerras 提交于
      People have been reporting that PPP connections over ptys, such as
      used with PPTP, will hang randomly when transferring large amounts of
      data, for instance in http://bugzilla.kernel.org/show_bug.cgi?id=6530.
      I have managed to reproduce the problem, and the patch below fixes the
      actual cause.
      
      The problem is not in fact in ppp_async.c but in n_tty.c.  What
      happens is that when pptp reads from the pty, we call read_chan() in
      drivers/char/n_tty.c on the master side of the pty.  That copies all
      the characters out of its buffer to userspace and then calls
      check_unthrottle(), which calls the pty unthrottle routine, which
      calls tty_wakeup on the slave side, which calls ppp_asynctty_wakeup,
      which calls tasklet_schedule.  So far so good.  Since we are in
      process context, the tasklet runs immediately and calls
      ppp_async_process(), which calls ppp_async_push, which calls the
      tty->driver->write function to send some more output.
      
      However, tty->driver->write() returns zero, because the master
      tty->receive_room is still zero.  We haven't returned from
      check_unthrottle() yet, and read_chan() only updates tty->receive_room
      _after_ calling check_unthrottle.  That means that the driver->write
      call in ppp_async_process() returns 0.  That would be fine if we were
      going to get a subsequent wakeup call, but we aren't (we just had it,
      and the buffer is now empty).
      
      The solution is for n_tty.c to update tty->receive_room _before_
      calling the driver unthrottle routine.  The patch below does this.
      With this patch I was able to transfer a 900MB file over a PPTP
      connection (taking about 25 minutes), whereas without the patch the
      connection would always stall in under a minute.
      Signed-off-by: NPaul Mackerras <paulus@samba.org>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      289a1e99
    • M
      [PATCH] sata_mv: grab host lock inside eng_timeout · 2f9719b6
      Mark Lord 提交于
      Bug fix:  mv_eng_timeout() calls mv_err_intr() without first grabbing the host lock,
      which can lead to all sorts of interesting scenarios.
      
      This whole error-handling portion of sata_mv is nasty (and will get fixed for
      the new EH stuff), but for now this patch will help keep it on life-support.
      Signed-off-by: NMark Lord <liml@rtr.ca>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      2f9719b6
    • Y
      [PATCH] PCI: reverse pci config space restore order · 8b8c8d28
      Yu, Luming 提交于
      According to Intel ICH spec, there are several rules that Base Address
      should be programmed before IOSE  (PCICMD register ) enabled.
      
      For example ICH7:
      
      12.1.3  SATA : the base address register for the bus master register
                     should be programmed before this bit is set.
      
      11.1.3:  PCICMD (USB): The base address register for USB should be
                             programmed before this bit is set.
      ....
      
      To make sure kernel code follow this rule , and prevent unnecessary
      confusion. I proposal this patch.
      Signed-off-by: NLuming Yu <luming.yu@intel.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      8b8c8d28
    • D
      [PATCH] PCI: Improve PCI config space writeback · 04d9c1a1
      Dave Jones 提交于
      At least one laptop blew up on resume from suspend with a black screen due
      to a lack of this patch.  By only writing back config space that is
      different, we minimise the possibility of accidents like this.
      Signed-off-by: NDave Jones <davej@redhat.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      04d9c1a1
    • J
      [PATCH] PCI: Error handling on PCI device resume · 8d92bc22
      Jean Delvare 提交于
      We currently don't handle errors properly when resuming a PCI device:
      * In pci_default_resume() we capture the error code returned by
        pci_enable_device() but don't pass it up to the caller.
        Introduced by commit 95a62965
      * In pci_resume_device(), the errors possibly returned by the driver's
        .resume method or by the generic pci_default_resume() function are
        ignored.
      
      This patch fixes both issues.
      Signed-off-by: NJean Delvare <khali@linux-fr.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      8d92bc22
  5. 11 6月, 2006 3 次提交
  6. 10 6月, 2006 2 次提交
  7. 09 6月, 2006 4 次提交
  8. 06 6月, 2006 8 次提交