1. 03 2月, 2022 1 次提交
  2. 01 2月, 2022 1 次提交
  3. 25 8月, 2021 1 次提交
  4. 24 8月, 2021 1 次提交
  5. 06 8月, 2021 2 次提交
    • R
      drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled · 8d70136e
      Randy Dunlap 提交于
      'pm_suspend_target_state' is only available when CONFIG_PM_SLEEP
      is set/enabled. OTOH, when both SUSPEND and HIBERNATION are not set,
      PM_SLEEP is not set, so this variable cannot be used.
      
      ../drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: In function ‘amdgpu_acpi_is_s0ix_active’:
      ../drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1046:11: error: ‘pm_suspend_target_state’ undeclared (first use in this function); did you mean ‘__KSYM_pm_suspend_target_state’?
          return pm_suspend_target_state == PM_SUSPEND_TO_IDLE;
                 ^~~~~~~~~~~~~~~~~~~~~~~
                 __KSYM_pm_suspend_target_state
      
      Also use shorter IS_ENABLED(CONFIG_foo) notation for checking the
      2 config symbols.
      
      Fixes: 91e27371 ("drm/amdgpu: Check pmops for desired suspend state")
      Signed-off-by: NRandy Dunlap <rdunlap@infradead.org>
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: Christian König <christian.koenig@amd.com>
      Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-next@vger.kernel.org
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      8d70136e
    • R
      drm/amdgpu: fix checking pmops when PM_SLEEP is not enabled · 5706cb3c
      Randy Dunlap 提交于
      'pm_suspend_target_state' is only available when CONFIG_PM_SLEEP
      is set/enabled. OTOH, when both SUSPEND and HIBERNATION are not set,
      PM_SLEEP is not set, so this variable cannot be used.
      
      ../drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: In function ‘amdgpu_acpi_is_s0ix_active’:
      ../drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1046:11: error: ‘pm_suspend_target_state’ undeclared (first use in this function); did you mean ‘__KSYM_pm_suspend_target_state’?
          return pm_suspend_target_state == PM_SUSPEND_TO_IDLE;
                 ^~~~~~~~~~~~~~~~~~~~~~~
                 __KSYM_pm_suspend_target_state
      
      Also use shorter IS_ENABLED(CONFIG_foo) notation for checking the
      2 config symbols.
      
      Fixes: 91e27371 ("drm/amdgpu: Check pmops for desired suspend state")
      Signed-off-by: NRandy Dunlap <rdunlap@infradead.org>
      Cc: Alex Deucher <alexander.deucher@amd.com>
      Cc: Christian König <christian.koenig@amd.com>
      Cc: "Pan, Xinhui" <Xinhui.Pan@amd.com>
      Cc: amd-gfx@lists.freedesktop.org
      Cc: dri-devel@lists.freedesktop.org
      Cc: linux-next@vger.kernel.org
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      Cc: stable@vger.kernel.org
      5706cb3c
  6. 29 7月, 2021 1 次提交
  7. 28 7月, 2021 3 次提交
  8. 02 6月, 2021 2 次提交
  9. 28 5月, 2021 2 次提交
  10. 22 5月, 2021 2 次提交
  11. 11 5月, 2021 1 次提交
  12. 24 3月, 2021 1 次提交
  13. 11 3月, 2021 1 次提交
  14. 04 3月, 2021 1 次提交
  15. 03 3月, 2021 1 次提交
  16. 16 12月, 2020 1 次提交
  17. 14 11月, 2020 1 次提交
  18. 10 10月, 2020 2 次提交
    • Y
      drm/amdgpu: Fix invalid number of character '{' in amdgpu_acpi_init · 9c27bc97
      Ye Bin 提交于
      Fix follow warning:
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: ''.
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: CONFIG_ACPI...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: 'CONFIG_ACPI'.
      ......
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: CONFIG_X86...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: 'CONFIG_X86'.
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: _X86_...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: '_X86_'.
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: __linux__...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: '__linux__'.
      
      Fixes: 97d798b2 ("drm/amdgpu: simplify ATIF backlight handling")
      Reported-by: NHulk Robot <hulkci@huawei.com>
      Signed-off-by: NYe Bin <yebin10@huawei.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      9c27bc97
    • Y
      drm/amdgpu: Fix invalid number of character '{' in amdgpu_acpi_init · 84900719
      Ye Bin 提交于
      Fix follow warning:
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: ''.
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: CONFIG_ACPI...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: 'CONFIG_ACPI'.
      ......
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: CONFIG_X86...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: 'CONFIG_X86'.
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: _X86_...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: '_X86_'.
      Checking drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: __linux__...
      [drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:770]: (error) Invalid number
      of character '{' when these macros are defined: '__linux__'.
      
      Fixes: 97d798b2 ("drm/amdgpu: simplify ATIF backlight handling")
      Reported-by: NHulk Robot <hulkci@huawei.com>
      Signed-off-by: NYe Bin <yebin10@huawei.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      84900719
  19. 25 8月, 2020 1 次提交
  20. 29 5月, 2020 1 次提交
  21. 06 5月, 2020 1 次提交
  22. 11 6月, 2019 1 次提交
  23. 06 5月, 2019 1 次提交
  24. 06 12月, 2018 1 次提交
  25. 27 11月, 2018 2 次提交
  26. 11 10月, 2018 1 次提交
    • L
      drm/amdgpu: Suppress keypresses from ACPI_VIDEO events · 582f58de
      Lyude Paul 提交于
      Currently we return NOTIFY_DONE for any event which we don't think is
      ours. However, many laptops will send more then just an ATIF event and
      will also send an ACPI_VIDEO_NOTIFY_PROBE event as well. Since we don't
      check for this, we return NOTIFY_DONE which causes a keypress for the
      ACPI event to be propogated to userspace. This is the equivalent of
      someone pressing the display key on a laptop every time there's a
      hotplug event.
      
      So, check for ACPI_VIDEO_NOTIFY_PROBE events and suppress keypresses
      from them.
      Signed-off-by: NLyude Paul <lyude@redhat.com>
      Cc: stable@vger.kernel.org
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      582f58de
  27. 28 8月, 2018 1 次提交
  28. 21 7月, 2018 2 次提交
  29. 06 7月, 2018 2 次提交
    • L
      drm/amdgpu: Dynamically probe for ATIF handle (v2) · 280cf1a9
      Lyude Paul 提交于
      The other day I was testing one of the HP laptops at my office with an
      i915/amdgpu hybrid setup and noticed that hotplugging was non-functional
      on almost all of the display outputs. I eventually discovered that all
      of the external outputs were connected to the amdgpu device instead of
      i915, and that the hotplugs weren't being detected so long as the GPU
      was in runtime suspend. After some talking with folks at AMD, I learned
      that amdgpu is actually supposed to support hotplug detection in runtime
      suspend so long as the OEM has implemented it properly in the firmware.
      
      On this HP ZBook 15 G4 (the machine in question), amdgpu wasn't managing
      to find the ATIF handle at all despite the fact that I could see acpi
      events being sent in response to any hotplugging. After going through
      dumps of the firmware, I discovered that this machine did in fact
      support ATIF, but that it's ATIF method lived in an entirely different
      namespace than this device's handle (the device handle was
      \_SB_.PCI0.PEG0.PEGP, but ATIF lives in ATPX's handle at
      \_SB_.PCI0.GFX0).
      
      So, fix this by probing ATPX's ACPI parent's namespace if we can't find
      ATIF elsewhere, along with storing a pointer to the proper handle to use
      for ATIF and using that instead of the device's handle.
      
      This fixes HPD detection while in runtime suspend for this ZBook!
      
      v2: Update the comment to reflect how the namespaces are arranged
      based on the system configuration. (Alex)
      Signed-off-by: NLyude Paul <lyude@redhat.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      280cf1a9
    • L
      drm/amdgpu: Make struct amdgpu_atif private to amdgpu_acpi.c · 102c16a0
      Lyude Paul 提交于
      Currently, there is nothing in amdgpu that actually uses these structs
      other than amdgpu_acpi.c. Additionally, since we're about to start
      saving the correct ACPI handle to use for calling ATIF in this struct
      this saves us from having to handle making sure that the acpi_handle
      (and by proxy, the type definition for acpi_handle and all of the other
      acpi headers) doesn't need to be included within the amdgpu_drv struct
      itself. This follows the example set by amdgpu_atpx_handler.c.
      Signed-off-by: NLyude Paul <lyude@redhat.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      102c16a0
  30. 29 6月, 2018 1 次提交
    • L
      drm/amdgpu: Dynamically probe for ATIF handle (v2) · f9ff6852
      Lyude Paul 提交于
      The other day I was testing one of the HP laptops at my office with an
      i915/amdgpu hybrid setup and noticed that hotplugging was non-functional
      on almost all of the display outputs. I eventually discovered that all
      of the external outputs were connected to the amdgpu device instead of
      i915, and that the hotplugs weren't being detected so long as the GPU
      was in runtime suspend. After some talking with folks at AMD, I learned
      that amdgpu is actually supposed to support hotplug detection in runtime
      suspend so long as the OEM has implemented it properly in the firmware.
      
      On this HP ZBook 15 G4 (the machine in question), amdgpu wasn't managing
      to find the ATIF handle at all despite the fact that I could see acpi
      events being sent in response to any hotplugging. After going through
      dumps of the firmware, I discovered that this machine did in fact
      support ATIF, but that it's ATIF method lived in an entirely different
      namespace than this device's handle (the device handle was
      \_SB_.PCI0.PEG0.PEGP, but ATIF lives in ATPX's handle at
      \_SB_.PCI0.GFX0).
      
      So, fix this by probing ATPX's ACPI parent's namespace if we can't find
      ATIF elsewhere, along with storing a pointer to the proper handle to use
      for ATIF and using that instead of the device's handle.
      
      This fixes HPD detection while in runtime suspend for this ZBook!
      
      v2: Update the comment to reflect how the namespaces are arranged
      based on the system configuration. (Alex)
      Signed-off-by: NLyude Paul <lyude@redhat.com>
      Signed-off-by: NAlex Deucher <alexander.deucher@amd.com>
      Cc: stable@vger.kernel.org
      f9ff6852