1. 19 1月, 2018 2 次提交
  2. 11 1月, 2018 1 次提交
  3. 10 1月, 2018 11 次提交
    • J
      MIPS: mm: Fix duplicate "const" on insn_table_MM · ccf85c74
      James Hogan 提交于
      Fix the following gcc 7.x build error on microMIPS builds:
      
      arch/mips/mm/uasm-micromips.c:43:26: error: duplicate ‘const’ declaration specifier [-Werror=duplicate-decl-specifier]
       static const struct insn const insn_table_MM[insn_invalid] = {
                                ^~~~~
      
      The same issue has already been fixed in uasm-mips by commit
      00e06297 ("MIPS: mm: remove duplicate "const" qualifier on
      insn_table").
      Signed-off-by: NJames Hogan <jhogan@kernel.org>
      Fixes: ce807d5f ("MIPS: Optimize uasm insn lookup.")
      Cc: David Daney <david.daney@cavium.com>
      Cc: linux-mips@linux-mips.org
      Patchwork: https://patchwork.linux-mips.org/patch/17889/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      ccf85c74
    • J
      MIPS: CM: Drop WARN_ON(vp != 0) · c04de7b1
      James Hogan 提交于
      Since commit 68923cdc ("MIPS: CM: Add cluster & block args to
      mips_cm_lock_other()"), mips_smp_send_ipi_mask() has used
      mips_cm_lock_other_cpu() with each CPU number, rather than
      mips_cm_lock_other() with the first VPE in each core. Prior to r6,
      multicore multithreaded systems such as dual-core dual-thread
      interAptivs with CPU Idle enabled (e.g. MIPS Creator Ci40) results in
      mips_cm_lock_other() repeatedly hitting WARN_ON(vp != 0).
      
      There doesn't appear to be anything fundamentally wrong about passing a
      non-zero VP/VPE number, even if it is a core's region that is locked
      into the other region before r6, so remove that particular WARN_ON().
      
      Fixes: 68923cdc ("MIPS: CM: Add cluster & block args to mips_cm_lock_other()")
      Signed-off-by: NJames Hogan <jhogan@kernel.org>
      Reviewed-by: NPaul Burton <paul.burton@mips.com>
      Cc: linux-mips@linux-mips.org
      Cc: stable@vger.kernel.org # 4.14+
      Patchwork: https://patchwork.linux-mips.org/patch/17883/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      c04de7b1
    • A
      MIPS: ralink: Fix platform_get_irq's error checking · b6ab1a13
      Arvind Yadav 提交于
      The platform_get_irq() function returns negative if an error occurs.
      zero or positive number on success. platform_get_irq() error checking
      for zero is not correct.
      Signed-off-by: NArvind Yadav <arvind.yadav.cs@gmail.com>
      Cc: john@phrozen.org
      Cc: linux-kernel@vger.kernel.org
      Cc: linux-mips@linux-mips.org
      Patchwork: https://patchwork.linux-mips.org/patch/17783/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      b6ab1a13
    • J
      MIPS: Fix CPS SMP NS16550 UART defaults · 7e5e371e
      James Hogan 提交于
      The MIPS_CPS_NS16550_BASE and MIPS_CPS_NS16550_SHIFT options have no
      defaults for non-Malta platforms which select SYS_SUPPORTS_MIPS_CPS
      (i.e. the pistachio and generic platforms). This is problematic for
      automated allyesconfig and allmodconfig builds based on these platforms,
      since make silentoldconfig tries to ask the user for values, and
      especially since v4.15 where the default platform was switched to
      generic.
      
      Default these options to 0 and arrange for MIPS_CPS_NS16550 to be no
      when using that default base address, so that the option only has an
      effect when the default is provided (i.e. Malta) or when a value is
      provided by the user.
      
      Fixes: 609cf6f2 ("MIPS: CPS: Early debug using an ns16550-compatible UART")
      Signed-off-by: NJames Hogan <jhogan@kernel.org>
      Reviewed-by: NPaul Burton <paul.burton@mips.com>
      Tested-by: NGuenter Roeck <linux@roeck-us.net>
      Cc: linux-mips@linux-mips.org
      Cc: linux-kernel@vger.kernel.org
      Cc: linux-mips@linux-mips.org
      Patchwork: https://patchwork.linux-mips.org/patch/17749/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      7e5e371e
    • M
      MIPS: BCM47XX Avoid compile error with MIPS allnoconfig · dfe00495
      Matt Redfearn 提交于
      Currently MIPS allnoconfig with CONFIG_BCM47XX=y fails to compile due to
      neither BCM47XX_BCMA nor BCM47XX_SSB being selected. This leads the
      enumeration in arch/mips/include/asm/mach-bcm47xx/bcm47xx.h to be empty,
      and compilation fails:
      
      In file included from arch/mips/bcm47xx/irq.c:32:0:
      ./arch/mips/include/asm/mach-bcm47xx/bcm47xx.h:34:1: error: expected
      identifier before '}' token
       };
       ^
      make[2]: *** [scripts/Makefile.build:314: arch/mips/bcm47xx/irq.o] Error 1
      
      Fix this by ensuring that BCM47XX_SSB is selected if BCM47XX_BCMA is
      not. This allows us to select either system or both, but not neither.
      Signed-off-by: NMatt Redfearn <matt.redfearn@mips.com>
      Cc: James Hogan <james.hogan@mips.com>
      Cc: linux-mips@linux-mips.org
      Cc: linux-kernel@vger.kernel.org
      Patchwork: https://patchwork.linux-mips.org/patch/17703/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      dfe00495
    • M
      MIPS: RB532: Avoid undefined mac_pton without GENERIC_NET_UTILS · ecff167c
      Matt Redfearn 提交于
      Currently MIPS allnoconfig with CONFIG_MIKROTIK_RB532=y fails to link
      due to missing support for mac_pton():
      
        LD      vmlinux
      arch/mips/rb532/devices.o: In function `setup_kmac':
      devices.c:(.init.text+0xc): undefined reference to `mac_pton'
      
      Rather than adding dependencies to the platform to force inclusion of
      GENERIC_NET_UTILS which is selected by CONFIG_NET, just exclude the
      setup of the MAC address if CONFIG_NET is not selected in the kernel
      config.
      Signed-off-by: NMatt Redfearn <matt.redfearn@mips.com>
      Cc: James Hogan <james.hogan@mips.com>
      Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
      Cc: Neil Armstrong <narmstrong@baylibre.com>
      Cc: Krzysztof Kozlowski <krzk@kernel.org>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Vladimir Zapolskiy <vz@mleia.com>
      Cc: Shawn Guo <shawnguo@kernel.org>
      Cc: linux-mips@linux-mips.org
      Cc: linux-kernel@vger.kernel.org
      Patchwork: https://patchwork.linux-mips.org/patch/17702/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      ecff167c
    • M
      MIPS: RB532: Avoid undefined early_serial_setup() without SERIAL_8250_CONSOLE · ff9bed94
      Matt Redfearn 提交于
      Currently MIPS allnoconfig with CONFIG_MIKROTIK_RB532=y fails to link due to
      missing support for early_serial_setup():
      
        LD      vmlinux
      arch/mips/rb532/serial.o: In function `setup_serial_port':
      serial.c:(.init.text+0x14): undefined reference to `early_serial_setup'
      
      Rather than adding dependencies to the platform to force inclusion of
      SERIAL_8250_CONSOLE together with it's dependencies like TTY, HAS_IOMEM,
      etc, just exclude arch/mips/rb532/serial.c from the build when it's
      dependency is not selected in the kernel config.
      Reported-by: NRalf Baechle <ralf@linux-mips.org>
      Signed-off-by: NMatt Redfearn <matt.redfearn@mips.com>
      Cc: James Hogan <james.hogan@mips.com>
      Cc: linux-mips@linux-mips.org
      Cc: linux-kernel@vger.kernel.org
      Patchwork: https://patchwork.linux-mips.org/patch/17701/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      ff9bed94
    • M
      MIPS: ath25: Avoid undefined early_serial_setup() without SERIAL_8250_CONSOLE · 9dd79fed
      Matt Redfearn 提交于
      Currently MIPS allnoconfig with CONFIG_ATH25=y fails to link due to
      missing support for early_serial_setup():
      
        LD      vmlinux
      arch/mips/ath25/devices.o: In function ath25_serial_setup':
      devices.c:(.init.text+0x68): undefined reference to 'early_serial_setup'
      
      Rather than adding dependencies to the platform to force inclusion of
      SERIAL_8250_CONSOLE together with it's dependencies like TTY, HAS_IOMEM,
      etc, just make ath25_serial_setup() a no-op when the dependency is not
      selected in the kernel config.
      Signed-off-by: NMatt Redfearn <matt.redfearn@mips.com>
      Cc: James Hogan <james.hogan@mips.com>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: Philippe Ombredanne <pombredanne@nexb.com>
      Cc: Kate Stewart <kstewart@linuxfoundation.org>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: linux-mips@linux-mips.org
      Cc: linux-kernel@vger.kernel.org
      Patchwork: https://patchwork.linux-mips.org/patch/17700/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      9dd79fed
    • J
      MIPS: AR7: ensure the port type's FCR value is used · 0a5191ef
      Jonas Gorski 提交于
      Since commit aef9a7bd ("serial/uart/8250: Add tunable RX interrupt
      trigger I/F of FIFO buffers"), the port's default FCR value isn't used
      in serial8250_do_set_termios anymore, but copied over once in
      serial8250_config_port and then modified as needed.
      
      Unfortunately, serial8250_config_port will never be called if the port
      is shared between kernel and userspace, and the port's flag doesn't have
      UPF_BOOT_AUTOCONF, which would trigger a serial8250_config_port as well.
      
      This causes garbled output from userspace:
      
      [    5.220000] random: procd urandom read with 49 bits of entropy available
      ers
         [kee
      
      Fix this by forcing it to be configured on boot, resulting in the
      expected output:
      
      [    5.250000] random: procd urandom read with 50 bits of entropy available
      Press the [f] key and hit [enter] to enter failsafe mode
      Press the [1], [2], [3] or [4] key and hit [enter] to select the debug level
      
      Fixes: aef9a7bd ("serial/uart/8250: Add tunable RX interrupt trigger I/F of FIFO buffers")
      Signed-off-by: NJonas Gorski <jonas.gorski@gmail.com>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
      Cc: Florian Fainelli <f.fainelli@gmail.com>
      Cc: Nicolas Schichan <nschichan@freebox.fr>
      Cc: linux-mips@linux-mips.org
      Cc: linux-serial@vger.kernel.org
      Patchwork: https://patchwork.linux-mips.org/patch/17544/Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      0a5191ef
    • L
      Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus · 44cae9b2
      Linus Torvalds 提交于
      Pull MIPS fixes from Ralf Baechle:
       "Another round of MIPS fixes for 4.15.
      
         - Maciej Rozycki found another series of FP issues which requires a
           seven part series to restructure and fix.
      
         - James fixes a warning about .set mt which gas doesn't like when
           building for R1 processors"
      
      * 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus:
        MIPS: Validate PR_SET_FP_MODE prctl(2) requests against the ABI of the task
        MIPS: Disallow outsized PTRACE_SETREGSET NT_PRFPREG regset accesses
        MIPS: Also verify sizeof `elf_fpreg_t' with PTRACE_SETREGSET
        MIPS: Fix an FCSR access API regression with NT_PRFPREG and MSA
        MIPS: Consistently handle buffer counter with PTRACE_SETREGSET
        MIPS: Guard against any partial write attempt with PTRACE_SETREGSET
        MIPS: Factor out NT_PRFPREG regset access helpers
        MIPS: CPS: Fix r1 .set mt assembler warning
      44cae9b2
    • L
      Merge branch 'for-linus' of git://git.kernel.dk/linux-block · d476c533
      Linus Torvalds 提交于
      Pull block fixes from Jens Axboe:
       "A set of fixes that should go into this release. This contains:
      
         - An NVMe pull request from Christoph, with a few critical fixes for
           NVMe.
      
         - A block drain queue fix from Ming.
      
         - The concurrent lo_open/release fix for loop"
      
      * 'for-linus' of git://git.kernel.dk/linux-block:
        loop: fix concurrent lo_open/lo_release
        block: drain queue before waiting for q_usage_counter becoming zero
        nvme-fcloop: avoid possible uninitialized variable warning
        nvme-mpath: fix last path removal during traffic
        nvme-rdma: fix concurrent reset and reconnect
        nvme: fix sector units when going between formats
        nvme-pci: move use_sgl initialization to nvme_init_iod()
      d476c533
  4. 09 1月, 2018 15 次提交
    • L
      Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net · ef7f8cec
      Linus Torvalds 提交于
      Pull networking fixes from David Miller:
      
       1) Frag and UDP handling fixes in i40e driver, from Amritha Nambiar and
          Alexander Duyck.
      
       2) Undo unintentional UAPI change in netfilter conntrack, from Florian
          Westphal.
      
       3) Revert a change to how error codes are returned from
          dev_get_valid_name(), it broke some apps.
      
       4) Cannot cache routes for ipv6 tunnels in the tunnel is ipv4/ipv6
          dual-stack. From Eli Cooper.
      
       5) Fix missed PMTU updates in geneve, from Xin Long.
      
       6) Cure double free in macvlan, from Gao Feng.
      
       7) Fix heap out-of-bounds write in rds_message_alloc_sgs(), from
          Mohamed Ghannam.
      
       8) FEC bug fixes from FUgang Duan (mis-accounting of dev_id, missed
          deferral of probe when the regulator is not ready yet).
      
       9) Missing DMA mapping error checks in 3c59x, from Neil Horman.
      
      10) Turn off Broadcom tags for some b53 switches, from Florian Fainelli.
      
      11) Fix OOPS when get_target_net() is passed an SKB whose NETLINK_CB()
          isn't initialized. From Andrei Vagin.
      
      12) Fix crashes in fib6_add(), from Wei Wang.
      
      13) PMTU bug fixes in SCTP from Marcelo Ricardo Leitner.
      
      * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (56 commits)
        sh_eth: fix TXALCR1 offsets
        mdio-sun4i: Fix a memory leak
        phylink: mark expected switch fall-throughs in phylink_mii_ioctl
        sctp: fix the handling of ICMP Frag Needed for too small MTUs
        sctp: do not retransmit upon FragNeeded if PMTU discovery is disabled
        xen-netfront: enable device after manual module load
        bnxt_en: Fix the 'Invalid VF' id check in bnxt_vf_ndo_prep routine.
        bnxt_en: Fix population of flow_type in bnxt_hwrm_cfa_flow_alloc()
        sh_eth: fix SH7757 GEther initialization
        net: fec: free/restore resource in related probe error pathes
        uapi/if_ether.h: prevent redefinition of struct ethhdr
        ipv6: fix general protection fault in fib6_add()
        RDS: null pointer dereference in rds_atomic_free_op
        sh_eth: fix TSU resource handling
        net: stmmac: enable EEE in MII, GMII or RGMII only
        rtnetlink: give a user socket to get_target_net()
        MAINTAINERS: Update my email address.
        can: ems_usb: improve error reporting for error warning and error passive
        can: flex_can: Correct the checking for frame length in flexcan_start_xmit()
        can: gs_usb: fix return value of the "set_bittiming" callback
        ...
      ef7f8cec
    • L
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma · 44596f86
      Linus Torvalds 提交于
      Pull rdma fixes from Doug Ledford:
      
       - One line fix to mlx4 error flow (same as mlx5 fix in last pull
         request, just in the mlx4 driver)
      
       - Fix a race condition in the IPoIB driver. This patch is larger than
         just a one line fix, but resolves a race condition in a fairly
         straight forward manner
      
       - Fix a locking issue in the RDMA netlink code. This patch is also
         larger than I would like for a late -rc. It has, however, had a week
         to bake in the rdma tree prior to this pull request
      
       - One line fix to fix granting remote machine access to memory that
         they don't need and shouldn't have
      
       - One line fix to correct the fact that our sgid/dgid pair is swapped
         from what you would expect when receiving an incoming connection
         request
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma:
        IB/srpt: Fix ACL lookup during login
        IB/srpt: Disable RDMA access by the initiator
        RDMA/netlink: Fix locking around __ib_get_device_by_index
        IB/ipoib: Fix race condition in neigh creation
        IB/mlx4: Fix mlx4_ib_alloc_mr error flow
      44596f86
    • L
      Merge tag 'platform-drivers-x86-v4.15-4' of git://git.infradead.org/linux-platform-drivers-x86 · d32da584
      Linus Torvalds 提交于
      Pull x86 platform driver fix from Darren Hart:
       "Address a wmi initcall ordering race resulting in a difficult to
        reproduce boot failure"
      
      * tag 'platform-drivers-x86-v4.15-4' of git://git.infradead.org/linux-platform-drivers-x86:
        platform/x86: wmi: Call acpi_wmi_init() later
      d32da584
    • S
      sh_eth: fix TXALCR1 offsets · 50f3d740
      Sergei Shtylyov 提交于
      The  TXALCR1 offsets are incorrect in the register offset tables, most
      probably due to copy&paste error.  Luckily, the driver never uses this
      register. :-)
      
      Fixes: 4a55530f ("net: sh_eth: modify the definitions of register")
      Signed-off-by: NSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      50f3d740
    • C
      mdio-sun4i: Fix a memory leak · 56c02902
      Christophe JAILLET 提交于
      If the probing of the regulator is deferred, the memory allocated by
      'mdiobus_alloc_size()' will be leaking.
      It should be freed before the next call to 'sun4i_mdio_probe()' which will
      reallocate it.
      
      Fixes: 4bdcb1dd ("net: Add MDIO bus driver for the Allwinner EMAC")
      Signed-off-by: NChristophe JAILLET <christophe.jaillet@wanadoo.fr>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      56c02902
    • G
      phylink: mark expected switch fall-throughs in phylink_mii_ioctl · 46cd7503
      Gustavo A. R. Silva 提交于
      In preparation to enabling -Wimplicit-fallthrough, mark switch cases
      where we are expecting to fall through.
      
      Addresses-Coverity-ID: 1463447 ("Missing break in switch")
      Signed-off-by: NGustavo A. R. Silva <garsilva@embeddedor.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      46cd7503
    • D
      Merge branch 'SCTP-PMTU-discovery-fixes' · 313c86da
      David S. Miller 提交于
      Marcelo Ricardo Leitner says:
      
      ====================
      SCTP PMTU discovery fixes
      
      This patchset fixes 2 issues with PMTU discovery that can lead to flood
      of retransmissions.
      The first patch fixes the issue for when PMTUD is disabled by the
      application, while the second fixes it for when its enabled.
      
      Please consider these to stable.
      ====================
      Acked-by: NNeil Horman <nhorman@tuxdriver.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      313c86da
    • M
      sctp: fix the handling of ICMP Frag Needed for too small MTUs · b6c5734d
      Marcelo Ricardo Leitner 提交于
      syzbot reported a hang involving SCTP, on which it kept flooding dmesg
      with the message:
      [  246.742374] sctp: sctp_transport_update_pmtu: Reported pmtu 508 too
      low, using default minimum of 512
      
      That happened because whenever SCTP hits an ICMP Frag Needed, it tries
      to adjust to the new MTU and triggers an immediate retransmission. But
      it didn't consider the fact that MTUs smaller than the SCTP minimum MTU
      allowed (512) would not cause the PMTU to change, and issued the
      retransmission anyway (thus leading to another ICMP Frag Needed, and so
      on).
      
      As IPv4 (ip_rt_min_pmtu=556) and IPv6 (IPV6_MIN_MTU=1280) minimum MTU
      are higher than that, sctp_transport_update_pmtu() is changed to
      re-fetch the PMTU that got set after our request, and with that, detect
      if there was an actual change or not.
      
      The fix, thus, skips the immediate retransmission if the received ICMP
      resulted in no change, in the hope that SCTP will select another path.
      
      Note: The value being used for the minimum MTU (512,
      SCTP_DEFAULT_MINSEGMENT) is not right and instead it should be (576,
      SCTP_MIN_PMTU), but such change belongs to another patch.
      
      Changes from v1:
      - do not disable PMTU discovery, in the light of commit
      06ad3919 ("[SCTP] Don't disable PMTU discovery when mtu is small")
      and as suggested by Xin Long.
      - changed the way to break the rtx loop by detecting if the icmp
        resulted in a change or not
      Changes from v2:
      none
      
      See-also: https://lkml.org/lkml/2017/12/22/811Reported-by: Nsyzbot <syzkaller@googlegroups.com>
      Signed-off-by: NMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b6c5734d
    • M
      sctp: do not retransmit upon FragNeeded if PMTU discovery is disabled · cc35c3d1
      Marcelo Ricardo Leitner 提交于
      Currently, if PMTU discovery is disabled on a given transport, but the
      configured value is higher than the actual PMTU, it is likely that we
      will get some icmp Frag Needed. The issue is, if PMTU discovery is
      disabled, we won't update the information and will issue a
      retransmission immediately, which may very well trigger another ICMP,
      and another retransmission, leading to a loop.
      
      The fix is to simply not trigger immediate retransmissions if PMTU
      discovery is disabled on the given transport.
      
      Changes from v2:
      - updated stale comment, noticed by Xin Long
      Signed-off-by: NMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      cc35c3d1
    • E
      xen-netfront: enable device after manual module load · b707fda2
      Eduardo Otubo 提交于
      When loading the module after unloading it, the network interface would
      not be enabled and thus wouldn't have a backend counterpart and unable
      to be used by the guest.
      
      The guest would face errors like:
      
        [root@guest ~]# ethtool -i eth0
        Cannot get driver information: No such device
      
        [root@guest ~]# ifconfig eth0
        eth0: error fetching interface information: Device not found
      
      This patch initializes the state of the netfront device whenever it is
      loaded manually, this state would communicate the netback to create its
      device and establish the connection between them.
      Signed-off-by: NEduardo Otubo <otubo@redhat.com>
      Reviewed-by: NBoris Ostrovsky <boris.ostrovsky@oracle.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b707fda2
    • D
      Merge branch 'bnxt_en_fixes' · bde21915
      David S. Miller 提交于
      Michael Chan says:
      
      ====================
      bnxt_en: 2 small bug fixes.
      
      The first one fixes the TC Flower flow parameter passed to firmware.  The
      2nd one fixes the VF index range checking for iproute2 SRIOV related commands.
      ====================
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      bde21915
    • V
      bnxt_en: Fix the 'Invalid VF' id check in bnxt_vf_ndo_prep routine. · 78f30004
      Venkat Duvvuru 提交于
      In bnxt_vf_ndo_prep (which is called by bnxt_get_vf_config ndo), there is a
      check for "Invalid VF id". Currently, the check is done against max_vfs.
      However, the user doesn't always create max_vfs. So, the check should be
      against the created number of VFs. The number of bnxt_vf_info structures
      that are allocated in bnxt_alloc_vf_resources routine is the "number of
      requested VFs". So, if an "invalid VF id" falls between the requested
      number of VFs and the max_vfs, the driver will be dereferencing an invalid
      pointer.
      
      Fixes: c0c050c5 ("bnxt_en: New Broadcom ethernet driver.")
      Signed-off-by: NVenkat Devvuru <venkatkumar.duvvuru@broadcom.com>
      Signed-off-by: NMichael Chan <michael.chan@broadcom.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      78f30004
    • S
      bnxt_en: Fix population of flow_type in bnxt_hwrm_cfa_flow_alloc() · 7deea450
      Sunil Challa 提交于
      flow_type in HWRM_FLOW_ALLOC is not being populated correctly due to
      incorrect passing of pointer and size of l3_mask argument of is_wildcard().
      Fixed this.
      
      Fixes: db1d36a2 ("bnxt_en: add TC flower offload flow_alloc/free FW cmds")
      Signed-off-by: NSunil Challa <sunilkumar.challa@broadcom.com>
      Reviewed-by: NSathya Perla <sathya.perla@broadcom.com>
      Reviewed-by: NVenkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
      Signed-off-by: NMichael Chan <michael.chan@broadcom.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      7deea450
    • L
      Merge branch 'for-4.15-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup · 29f7e499
      Linus Torvalds 提交于
      Pull cgroup fixes from Tejun Heo:
       "This contains fixes for the following two non-trivial issues:
      
         - The task iterator got broken while adding thread mode support for
           v4.14. It was less visible because it only triggers when both
           cgroup1 and cgroup2 hierarchies are in use. The recent versions of
           systemd uses cgroup2 for process management even when cgroup1 is
           used for resource control exposing this issue.
      
         - cpuset CPU hotplug path could deadlock when racing against exits.
      
        There also are two patches to replace unlimited strcpy() usages with
        strlcpy()"
      
      * 'for-4.15-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup:
        cgroup: fix css_task_iter crash on CSS_TASK_ITER_PROC
        cgroup: Fix deadlock in cpu hotplug path
        cgroup: use strlcpy() instead of strscpy() to avoid spurious warning
        cgroup: avoid copying strings longer than the buffers
      29f7e499
    • R
      platform/x86: wmi: Call acpi_wmi_init() later · 98b8e4e5
      Rafael J. Wysocki 提交于
      Calling acpi_wmi_init() at the subsys_initcall() level causes ordering
      issues to appear on some systems and they are difficult to reproduce,
      because there is no guaranteed ordering between subsys_initcall()
      calls, so they may occur in different orders on different systems.
      
      In particular, commit 86d9f485 (mm/slab: fix kmemcg cache
      creation delayed issue) exposed one of these issues where genl_init()
      and acpi_wmi_init() are both called at the same initcall level, but
      the former must run before the latter so as to avoid a NULL pointer
      dereference.
      
      For this reason, move the acpi_wmi_init() invocation to the
      initcall_sync level which should still be early enough for things
      to work correctly in the WMI land.
      
      Link: https://marc.info/?t=151274596700002&r=1&w=2Reported-by: NJonathan McDowell <noodles@earth.li>
      Reported-by: NJoonsoo Kim <iamjoonsoo.kim@lge.com>
      Tested-by: NJonathan McDowell <noodles@earth.li>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      Signed-off-by: NDarren Hart (VMware) <dvhart@infradead.org>
      98b8e4e5
  5. 08 1月, 2018 5 次提交
  6. 07 1月, 2018 6 次提交