Ensure that function names does not mix upper/lower case
Signed-off-by: NAlexis Lothoré <alexis.lothore@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Add missing parenthesis for else statement
Signed-off-by: NAlexis Lothoré <alexis.lothore@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Update EPn* variables names to EPN* to prevent CamelCase usage
Signed-off-by: NAlexis Lothoré <alexis.lothore@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Closing braces should match the first characters of the openings.
Signed-off-by: NGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix various checkpatch warnings and errors in LLI macro definitions
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Drop uneeded include guard for __KERNEL__.
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The MSB64 is defined in two include file. One copy
is sufficient.
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch reported white space style violations
in cc_lli_defs.h
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix checkpatch reported white space style violations
in cc_hw_queue_defs.h
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fix enum and struct definition coding style by removing uneeded typedef and
s/CamelCase/snake_case/g.
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace open coded struct zeroing with a memset call.
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove useless and wrong min/max macros.
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Move from stdint style int_t/uint_t to kernel style u/s types.
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove a bunch of cruft being used in HW debugging but not useful
or compiled for driver use or development.
Signed-off-by: NGilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes checkpatch warnings: "WARNING: braces {} are not
necessary for single statement blocks" and "WARNING: braces {} are not
necessary for any arm of this statement".
Signed-off-by: NThibaut Robert <thibaut.robert@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

offset is an unsigned variable and, greater-than-or-equal-to-zero
comparison of an unsigned variable is always true.

Addresses-Coverity-ID: 1373919
Signed-off-by: NGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Resolving a minor checkpatch/indentation issue in ion_carveout_heap.c,
ie:
drivers/staging/android/ion/ion_carveout_heap.c
-----------------------------------------------
CHECK: Alignment should match open parenthesis
+static phys_addr_t ion_carveout_allocate(struct ion_heap *heap,
+					     unsigned long size)
Signed-off-by: NMatthew Giassa <matthew@giassa.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

According to checkpatch.pl, kcalloc should be preferred to kzalloc with
multiply.
Signed-off-by: NJB Van Puyvelde <jbvanpuyvelde@gmail.com>
Acked-by: NViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: NRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Fixed following checkpatch.pl warning:
 * WARNING: Prefer kcalloc over kzalloc with multiply

Instead of specifying no.of bytes * size as argument
in kzalloc, prefer kcalloc.
Signed-off-by: NKarthik Tummala <karthik@techveda.org>
Reviewed-by: NRui Miguel Silva <rmfrfs@gmail.com>
Acked-by: NViresh Kumar <viresh.kumar@linaro.org>

Changes for v2:
- Changed subject line & fixed typo as suggested by
  Rui Miguel Silva
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Balance if/else braces as recommended by checkpatch.pl
Signed-off-by: NLaurence Rochfort <laurence.rochfort@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove unused RTW_IEEE80211_FCTL_*, RTW_IEEE80211_FTYPE_*,
RTW_IEEE80211_STYPE_*, IEEE80211_STATMASK_*, IEEE80211_DEFAULT_*,
BEACON_PROBE_SSID_ID_POSITION, MFIE_TYPE_*, IEEE80211_DTIM_*
and IEEE80211_PS_*.
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

ieee80211_is_empty_essid() is unused, remove it.
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

ieee80211_get_hdrlen is unused, remove it and all corresponding code.
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Length of IV/ICV fields calculated here, so trim these field here too.
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

It is useful to remove IV/ICV from rtl88eu_mon_recv_hook().
Also unprotect_frame() will be very short without skb_(pull|trim).
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

staging:r8188eu: use different mon_recv_decrypted() inside rtl88eu_mon_recv_hook() and rtl88eu_mon_xmit_hook().

Create mon_recv_decrypted_recv() to change rtl88eu_mon_recv_hook()
without affect to rtl88eu_mon_xmit_hook().
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

staging:r8188eu: move IV/ICV trimming into decrypt() and also place it after rtl88eu_mon_recv_hook()

IV/ICV should be trimmed immediately after decoding
(this is a decryptor job).

Trim IV/ICV inside decrypt() for SW decrypted frames,
for HW decrypted - before rtl88eu_mon_recv_hook().

Adopt frames receive process to work without IV/ICV fields.
Signed-off-by: NIvan Safonov <insafonov@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase association_request_t and association_response_t
struct field names with underscores to comply with the standard kernel
coding style.
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- maxDuration
- durRemaining
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- FhParms_t
- DsParms_t
- CfParms_t
- IbssParms_t
- ErpParams_t
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase struct field names with underscores to comply
with the standard kernel coding style.
Changed:
- dwellTime
- hopSet
- hopPattern
- hopIndex
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Replace CamelCase fields of struct with underscores to comply
with the standard kernel coding style
Signed-off-by: NJanusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Sparse spits out a warnings about __le16 and unsigned short assignment.
Change the type of size and event members of struct hostif_hdr
to __le16 and correct conversion to the proper cpu type.
Signed-off-by: NCezary Gapinski <gapalinux@gmail.com>
Reviewed-by: NTobin C. Harding <me@tobin.cc>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

To ensure the bss is always synchronized only call on basic rate
change.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The key table is not intialized correctly without this call.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Cc: <stable@vger.kernel.org> # v3.17+
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

short time change needs to synchronize parameters in vnt_update_ifs so
a call to the function is always necessary.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Short slot time is controlled by mac80211 so there is no need to find
odfm rates.

Merge PK_TYPE_11B and PK_TYPE_11GA & PK_TYPE_11GB into one else and
switch on short slot time.
Signed-off-by: NMalcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split struct definition across multiple line to fit in the 80 characters
limit
Signed-off-by: NVincent Siles <vincent.siles@provenrun.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Splitting function calls across multiple lines to fit in the 80
characters limit
Signed-off-by: NVincent Siles <vincent.siles@provenrun.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>