Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and clean the
error path.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and clean the
error path.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>
Cc: Support Opensource <support.opensource@diasemi.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
call of gpiochip_remove() from error path.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>
Cc: Ray Jui <rjui@broadcom.com>
Acked-by: NRay Jui <ray.jui@broadcom.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>
Cc: patches@opensource.wolfsonmicro.com
Acked-by: NCharles Keepax <ckeepax@opensource.wolfsonmicro.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from remove callback.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: NMichael Hennerich <michael.hennerich@analog.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from error path.

Also remove the need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: NMichael Hennerich <michael.hennerich@analog.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from error path.

Also remove the need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>
Cc: Alexandre Courbot <gnurou@gmail.com>

Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from error path.

Also remove the need of driver callback .remove.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>
Cc: Alexander Shiyan <shc_work@mail.ru>

Add device managed APIs devm_gpiochip_add_data() and
devm_gpiochip_remove() for the APIs gpiochip_add_data()
and gpiochip_remove().

This helps in reducing code in error path and sometimes
removal of .remove callback for driver unbind.
Signed-off-by: NLaxman Dewangan <ldewangan@nvidia.com>

This fixes the wrongly indicated lines in the userspace
ABI: test for the right BITS, do not treat bit numbers as
bitmasks.
Reported-by: NMarkus Pargmann <mpa@pengutronix.de>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

Commit cb464a88e1ed ("gpio: make the gpiochip a real device") call
gpiochip_sysfs_unregister after the gpiochip is empty. It lead to the
following crash:

[  163.503994] Unable to handle kernel NULL pointer dereference at virtual address 0000007c
[...]
[  163.525394] [<ffffffc0003719a0>] gpiochip_sysfs_unregister+0x44/0xa4
[  163.525611] [<ffffffc00036f6a0>] gpiochip_remove+0x24/0x154
[  163.525861] [<ffffffbffc00f0a4>] mockup_gpio_remove+0x38/0x64 [gpio_mockup]
[  163.526101] [<ffffffc00042b4b4>] platform_drv_remove+0x24/0x64
[  163.526313] [<ffffffc000429cc8>] __device_release_driver+0x7c/0xfc
[  163.526525] [<ffffffc000429e54>] driver_detach+0xbc/0xc0
[  163.526700] [<ffffffc000429014>] bus_remove_driver+0x58/0xac
[  163.526883] [<ffffffc00042a4cc>] driver_unregister+0x2c/0x4c
[  163.527067] [<ffffffc00042b5c0>] platform_driver_unregister+0x10/0x18
[  163.527284] [<ffffffbffc00f340>] mock_device_exit+0x10/0x38 [gpio_mockup]
[  163.527593] [<ffffffc00011cefc>] SyS_delete_module+0x1b8/0x1fc
[  163.527799] [<ffffffc000085d8c>] __sys_trace_return+0x0/0x4
[  163.528049] Code: 940d74b4 f9019abf aa1303e0 940d7439 (7940fac0)
[  163.536273] ---[ end trace 3d1329be504af609 ]---

This patch fix this by changing the code back.
Signed-off-by: NBamvor Jian Zhang <bamvor.zhangjian@linaro.org>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

If spi_read() fails then we just returned but we missed unlocking the
mutex.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

Enable X-Gene standby GPIO controller as interrupt controller to provide
its own resources. This avoids ambiguity where GIC interrupt resource is
use as X-Gene standby GPIO interrupt resource in user driver.
Signed-off-by: NY Vo <yvo@apm.com>
Signed-off-by: NQuan Nguyen <qnguyen@apm.com>
Acked-by: NMarc Zyngier <marc.zyngier@arm.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

This adds a GPIO line ABI for getting name, label and a few select
flags from the kernel.

This hides the kernel internals and only tells userspace what it
may need to know: the different in-kernel consumers are masked
behind the flag "kernel" and that is all userspace needs to know.

However electric characteristics like active low, open drain etc
are reflected to userspace, as this is important information.

We provide information on all lines on all chips, later on we will
likely add a flag for the chardev consumer so we can filter and
display only the lines userspace actually uses in e.g. lsgpio,
but then we first need an ABI for userspace to grab and use
(get/set/select direction) a GPIO line.

Sample output from "lsgpio" on ux500:

GPIO chip: gpiochip7, "8011e000.gpio", 32 GPIO lines
        line 0: unnamed unlabeled
        line 1: unnamed unlabeled
(...)
        line 25: unnamed "SFH7741 Proximity Sensor" [kernel output open-drain]
        line 26: unnamed unlabeled
(...)
Tested-by: NMichael Welling <mwelling@ieee.org>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

The gpio_chip label is useful for userspace to understand what
kind of GPIO chip it is dealing with. Let's store a copy of this
label in the gpio_device, add it to the struct passed to userspace
for GPIO_GET_CHIPINFO_IOCTL and modify lsgpio to show it.
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

Just as it says: after adding the proper interfaces to gpiolib,
this is no longer needed.
Suggested-by: NNicolas Saenz Julienne <nicolassaenzj@gmail.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

The ks8695 gpio driver has its own copy of the irq_to_gpio()
function. This is completely unused in the mainline kernel
after we converted all remaining users several years ago,
so we can remove the definition as well.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

The use of kmalloc() to allocate the gpio_device leaves the contained struct
device object in an unknown state.  Calling dev_set_name() on a struct device
of unknown state can trigger the free() of an invalid pointer, as seen in the
following backtrace (collected by Tony Lindgren):

  kfree
  kobject_set_name_vargs
  dev_set_name
  gpiochip_add_data
  omap_gpio_probe
  platform_drv_probe
  ...
Reported-by: NGeert Uytterhoeven <geert+renesas@glider.be>
Reported-by: NMichael Welling <mwelling@ieee.org>
Reported-by: NTony Lindgren <tony@atomide.com>
Tested-by: NMichael Welling <mwelling@ieee.org>
Tested-by: NTony Lindgren <tony@atomide.com>
Signed-off-by: NJosh Cartwright <joshc@ni.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

Since devm_kzalloc can be failed in memory pressure,
it needs to check and return -ENOMEM
Signed-off-by: NInsu Yun <wuninsu@gmail.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>

The .direction_output callback should set proper output level.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>