1. 21 9月, 2009 4 次提交
    • H
      thinkpad-acpi: hotkey event driver update · 0d922e3b
      Henrique de Moraes Holschuh 提交于
      Update the HKEY event driver to:
      
      1. Handle better the second-gen firmware, which has no HKEY mask
         support but does report FN+F3, FN+F4 and FN+F12 without the need
         for NVRAM polling.
      
         a) always make the mask-related attributes available in sysfs;
         b) use DMI quirks to detect the second-gen firmware;
         c) properly report that FN+F3, FN+F4 and FN+F12 are enabled,
            and available even on mask-less second-gen firmware;
      
      2. Decouple the issuing of hotkey events towards userspace from
         their reception from the firmware.  ALSA mixer and brightness
         event reporting support will need this feature.
      
      3. Clean up the mess in the hotkey driver a great deal.  It is
         still very convoluted, and wants a full refactoring into a
         proper event API interface, but that is not going to happen
         today.
      
      4. Fully reset firmware interface on resume (restore hotkey
         mask and status).
      
      5. Stop losing polled events for no good reason when changing the
         mask and poll frequencies.  We will still lose them when the
         hotkey_source_mask is changed, as well as any that happened
         between driver suspend and driver resume.
      
      The hotkey subdriver now has the notion of user-space-visible hotkey
      event mask, as well as of the set of "hotkey" events the driver needs
      (because brightness/volume change reports are not just keypress
      reports in most ThinkPad models).
      
      With this rewrite, the ABI level is bumped to 0x020500 should
      userspace need to know it is dealing with the updated hotkey
      subdriver.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      0d922e3b
    • H
      thinkpad-acpi: drop HKEY event 0x5010 · 176dd985
      Henrique de Moraes Holschuh 提交于
      HKEY event 0x5010 is useless to us: old ThinkPads don't issue it.  Newer
      ThinkPads won't issue it anymore.  And all ThinkPads issue 0x1010 and
      0x1011 events.
      
      Just silently drop it instead of sending it to userspace.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      176dd985
    • H
      thinkpad-acpi: remove uneeded tp_features.hotkey tests in hotkey_exit · 4be73005
      Henrique de Moraes Holschuh 提交于
      hotkey_exit() is only called if hotkey_init() finished sucessfully, or
      by direct calls inside hotkey_init().  The tp_features.hotkey test is
      always true, and just adds to the confusion, remove it.  Also, avoid
      calling hotkey_mask_set() when it won't do anything useful.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      4be73005
    • H
      thinkpad-acpi: don't leave ERR_PTR() pointers around · 435c47e2
      Henrique de Moraes Holschuh 提交于
      backlight_device_register returns ERR_PTR() in case of problems, and
      the current code would leave that ERR_PTR in ibm_backlight_device.
      
      The current code paths won't touch it in that situation, but that could
      change.  Make sure to set ibm_backlight_device to NULL in the error
      path.
      Signed-off-by: NHenrique de Moraes Holschuh <hmh@hmh.eng.br>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      435c47e2
  2. 19 9月, 2009 9 次提交
  3. 29 8月, 2009 1 次提交
  4. 27 8月, 2009 1 次提交
    • C
      wmi: fix kernel panic when stack protection enabled. · f3d83e24
      Costantino Leandro 提交于
      Summary:
      Kernel panic arise when stack protection is enabled, since strncat will
      add a null terminating byte '\0'; So in functions
      like this one (wmi_query_block):
              char wc[4]="WC";
      	....
      	strncat(method, block->object_id, 2);
              ...
      the length of wc should be n+1 (wc[5]) or stack protection
      fault will arise. This is not noticeable when stack protection is
      disabled,but , isn't good either.
      Config used: [CONFIG_CC_STACKPROTECTOR_ALL=y,
      	      CONFIG_CC_STACKPROTECTOR=y]
      
      Panic Trace
      ------------
             .... stack-protector: kernel stack corrupted in : fa7b182c
             2.6.30-rc8-obelisco-generic
             call_trace:
                 [<c04a6c40>] ? panic+0x45/0xd9
      	   [<c012925d>] ? __stack_chk_fail+0x1c/0x40
      	   [<fa7b182c>] ? wmi_query_block+0x15a/0x162 [wmi]
      	   [<fa7b182c>] ? wmi_query_block+0x15a/0x162 [wmi]
      	   [<fa7e7000>] ? acer_wmi_init+0x00/0x61a [acer_wmi]
      	   [<fa7e7135>] ? acer_wmi_init+0x135/0x61a [acer_wmi]
      	   [<c0101159>] ? do_one_initcall+0x50+0x126
      
      Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13514Signed-off-by: NCostantino Leandro <lcostantino@gmail.com>
      Signed-off-by: NCarlos Corbacho <carlos@strangeworlds.co.uk>
      Cc: Len Brown <len.brown@intel.com>
      Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
      Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
      Cc: <stable@kernel.org>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      f3d83e24
  5. 03 8月, 2009 1 次提交
    • A
      eeepc-laptop: fix hot-unplug on resume · 7334546a
      Alan Jenkins 提交于
      OOPS on resume when the wireless adaptor is disabled during suspend was
      introduced by "eeepc-laptop: read rfkill soft-blocked state on resume".
      
      Unable to handle kernel NULL pointer dereference
      
      Process s2disk
      Tainted: G W
      IP: klist_put
      
      Call trace:
      ? klist_del
      ? device_del
      ? device_unregister
      ? pci_stop_dev
      ? pci_stop_bus
      ? pci_remove_device
      ? eeepc_rfkill_hotplug [eeepc_laptop]
      ? eeepc_hotk_resume [eeepc_laptop]
      ? acpi_device_resume
      ? device_resume
      ? hibernation_snapshot
      
      It appears the PCI device is removed twice.  The eeepc_rfkill_hotplug()
      call from the resume handler is racing against the call from the ACPI
      notifier callback.  The ACPI notification is triggered by the resume
      handler when it refreshes the value of CM_ASL_WLAN.
      
      The fix is to serialize hotplug calls using a workqueue.
      
      http://bugzilla.kernel.org/show_bug.cgi?id=13825Signed-off-by: NAlan Jenkins <alan-jenkins@tuffmail.co.uk>
      Acked-by: NCorentin Chary <corentin.chary@gmail.com>
      Signed-off-by: NLen Brown <len.brown@intel.com>
      7334546a
  6. 02 8月, 2009 4 次提交
  7. 31 7月, 2009 1 次提交
  8. 22 7月, 2009 1 次提交
  9. 08 7月, 2009 1 次提交
  10. 30 6月, 2009 1 次提交
    • I
      eeepc-laptop: Fix build failure with HOTPLUG_PCI && !SYSFS · 44b3615b
      Ingo Molnar 提交于
      FYI, there's a post-rc1 build regression with certain configs:
      
       drivers/built-in.o: In function `pci_hp_deregister':
       (.text+0xb166): undefined reference to `pci_hp_remove_module_link'
       drivers/built-in.o: In function `pci_hp_deregister':
       (.text+0xb19f): undefined reference to `pci_destroy_slot'
       drivers/built-in.o: In function `__pci_hp_register':
       (.text+0xb583): undefined reference to `pci_create_slot'
       drivers/built-in.o: In function `__pci_hp_register':
       (.text+0xb5b1): undefined reference to `pci_hp_create_module_link'
       make: *** [.tmp_vmlinux1] Error 1
      
      Caused by:
      
      | 2b121bc2 is first bad commit
      | commit 2b121bc2
      | Date:   Thu Jun 25 13:25:36 2009 +0200
      |
      |     eeepc-laptop: Register as a pci-hotplug device
      
      which changed the driver to use the PCI hotplug infrastructure, but
      didn't do a good job on the Kconfig rules.
      Signed-off-by: NIngo Molnar <mingo@elte.hu>
      Acked-by: NRandy Dunlap <randy.dunlap@oracle.com>
      Acked-by: NLen Brown <len.brown@intel.com>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      44b3615b
  11. 26 6月, 2009 7 次提交
  12. 24 6月, 2009 9 次提交