1. 20 5月, 2011 1 次提交
  2. 31 3月, 2011 1 次提交
  3. 25 12月, 2010 1 次提交
  4. 23 12月, 2010 1 次提交
  5. 22 10月, 2010 2 次提交
  6. 03 10月, 2010 1 次提交
  7. 01 9月, 2010 1 次提交
  8. 30 7月, 2010 1 次提交
  9. 29 6月, 2010 1 次提交
    • E
      spi/mmc_spi: SPI bus locking API, using mutex · cf32b71e
      Ernst Schwab 提交于
      SPI bus locking API to allow exclusive access to the SPI bus, especially, but
      not limited to, for the mmc_spi driver.
      
      Coded according to an outline from Grant Likely; here is his
      specification (accidentally swapped function names corrected):
      
      It requires 3 things to be added to struct spi_master.
      - 1 Mutex
      - 1 spin lock
      - 1 flag.
      
      The mutex protects spi_sync, and provides sleeping "for free"
      The spinlock protects the atomic spi_async call.
      The flag is set when the lock is obtained, and checked while holding
      the spinlock in spi_async().  If the flag is checked, then spi_async()
      must fail immediately.
      
      The current runtime API looks like this:
      spi_async(struct spi_device*, struct spi_message*);
      spi_sync(struct spi_device*, struct spi_message*);
      
      The API needs to be extended to this:
      spi_async(struct spi_device*, struct spi_message*)
      spi_sync(struct spi_device*, struct spi_message*)
      spi_bus_lock(struct spi_master*)  /* although struct spi_device* might
      be easier */
      spi_bus_unlock(struct spi_master*)
      spi_async_locked(struct spi_device*, struct spi_message*)
      spi_sync_locked(struct spi_device*, struct spi_message*)
      
      Drivers can only call the last two if they already hold the spi_master_lock().
      
      spi_bus_lock() obtains the mutex, obtains the spin lock, sets the
      flag, and releases the spin lock before returning.  It doesn't even
      need to sleep while waiting for "in-flight" spi_transactions to
      complete because its purpose is to guarantee no additional
      transactions are added.  It does not guarantee that the bus is idle.
      
      spi_bus_unlock() clears the flag and releases the mutex, which will
      wake up any waiters.
      
      The difference between spi_async() and spi_async_locked() is that the
      locked version bypasses the check of the lock flag.  Both versions
      need to obtain the spinlock.
      
      The difference between spi_sync() and spi_sync_locked() is that
      spi_sync() must hold the mutex while enqueuing a new transfer.
      spi_sync_locked() doesn't because the mutex is already held.  Note
      however that spi_sync must *not* continue to hold the mutex while
      waiting for the transfer to complete, otherwise only one transfer
      could be queued up at a time!
      
      Almost no code needs to be written.  The current spi_async() and
      spi_sync() can probably be renamed to __spi_async() and __spi_sync()
      so that spi_async(), spi_sync(), spi_async_locked() and
      spi_sync_locked() can just become wrappers around the common code.
      
      spi_sync() is protected by a mutex because it can sleep
      spi_async() needs to be protected with a flag and a spinlock because
      it can be called atomically and must not sleep
      Signed-off-by: NErnst Schwab <eschwab@online.de>
      [grant.likely@secretlab.ca: use spin_lock_irqsave()]
      Signed-off-by: NGrant Likely <grant.likely@secretlab.ca>
      Tested-by: NMatt Fleming <matt@console-pimps.org>
      Tested-by: NAntonio Ospite <ospite@studenti.unina.it>
      cf32b71e
  10. 28 4月, 2010 2 次提交
  11. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  12. 23 9月, 2009 3 次提交
    • D
      spi: handle TX-only/RX-only · 568d0697
      David Brownell 提交于
      Support two new half-duplex SPI implementation restrictions, for links
      that talk to TX-only or RX-only devices.  (Existing half-duplex flavors
      support both transfer directions, just not at the same time.)
      
      Move spi_async() into the spi.c core, and stop inlining it.  Then make
      that function perform error checks and reject messages that demand more
      than the underlying controller can support.
      
      Based on a patch from Marek Szyprowski which did this only for the
      bitbanged GPIO driver.
      
      Cc: Marek Szyprowski <m.szyprowski@samsung.com>
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      568d0697
    • A
      spi: prefix modalias with "spi:" · e0626e38
      Anton Vorontsov 提交于
      This makes it consistent with other buses (platform, i2c, vio, ...).  I'm
      not sure why we use the prefixes, but there must be a reason.
      
      This was easy enough to do it, and I did it.
      Signed-off-by: NAnton Vorontsov <avorontsov@ru.mvista.com>
      Cc: David Brownell <dbrownell@users.sourceforge.net>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Grant Likely <grant.likely@secretlab.ca>
      Cc: Jean Delvare <khali@linux-fr.org>
      Cc: Ben Dooks <ben-linux@fluff.org>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Dmitry Torokhov <dtor@mail.ru>
      Cc: Samuel Ortiz <sameo@openedhand.com>
      Cc: "John W. Linville" <linville@tuxdriver.com>
      Acked-by: NMike Frysinger <vapier.adi@gmail.com>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      e0626e38
    • A
      spi: add support for device table matching · 75368bf6
      Anton Vorontsov 提交于
      With this patch spi drivers can use standard spi_driver.id_table and
      MODULE_DEVICE_TABLE() mechanisms to bind against the devices.  Just like
      we do with I2C drivers.
      
      This is useful when a single driver supports several variants of devices
      but it is not possible to detect them in run-time (like non-JEDEC chips
      probing in drivers/mtd/devices/m25p80.c), and when platform_data usage is
      overkill.
      
      This patch also makes life a lot easier on OpenFirmware platforms, since
      with OF we extensively use proper device IDs in modaliases.
      Signed-off-by: NAnton Vorontsov <avorontsov@ru.mvista.com>
      Cc: David Brownell <dbrownell@users.sourceforge.net>
      Cc: David Woodhouse <dwmw2@infradead.org>
      Cc: Grant Likely <grant.likely@secretlab.ca>
      Cc: Jean Delvare <khali@linux-fr.org>
      Cc: Ben Dooks <ben-linux@fluff.org>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      75368bf6
  13. 19 6月, 2009 3 次提交
  14. 14 4月, 2009 1 次提交
  15. 07 1月, 2009 1 次提交
  16. 17 10月, 2008 2 次提交
  17. 15 8月, 2008 1 次提交
    • D
      spi: bugfix spi_add_device() with duplicate chipselects · e48880e0
      David Brownell 提交于
      When reviewing a recent patch I noticed a potential trouble spot in the
      registration of new SPI devices.  The SPI master driver is told to set
      the device up before adding it to the driver model, so that it's always
      properly set up when probe() is called.  (This is important, because in
      the case of inverted chipselects, this device can make the bus misbehave
      until it's properly deselected.  It's got to be set up even if no driver
      binds to the device.)
      
      The trouble spot is that it doesn't first verify that no other device
      has been added using that chipselect.  If such a device has been added,
      its configuration gets trashed.  (Fortunately this has not been a common
      error!)
      
      The fix here adds an explicit check, and a mutex to protect the relevant
      critical region.
      
      [akpm@linux-foundation.org: make the lock local to spi_add_device()]
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      e48880e0
  18. 26 7月, 2008 1 次提交
    • G
      spi: split up spi_new_device() to allow two stage registration. · dc87c98e
      Grant Likely 提交于
      spi_new_device() allocates and registers an spi device all in one swoop.
      If the driver needs to add extra data to the spi_device before it is
      registered, then this causes problems.  This is needed for OF device
      tree support so that the SPI device tree helper can add a pointer to
      the device node after the device is allocated, but before the device
      is registered.  OF aware SPI devices can then retrieve data out of the
      device node to populate a platform data structure.
      
      This patch splits the allocation and registration portions of code out
      of spi_new_device() and creates two new functions; spi_alloc_device()
      and spi_register_device().  spi_new_device() is modified to use the new
      functions for allocation and registration.  None of the existing users
      of spi_new_device() should be affected by this change.
      
      Drivers using the new API can forego the use of spi_board_info
      structure to describe the device layout and populate data into the
      spi_device structure directly.
      
      This change is in preparation for adding an OF device tree parser to
      generate spi_devices based on data in the device tree.
      Signed-off-by: NGrant Likely <grant.likely@secretlab.ca>
      Acked-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      dc87c98e
  19. 25 7月, 2008 1 次提交
    • G
      spi: make spi_board_info.modalias a char array · 102eb975
      Grant Likely 提交于
      Currently, 'modalias' in the spi_device structure is a 'const char *'.
      The spi_new_device() function fills in the modalias value from a passed in
      spi_board_info data block.  Since it is a pointer copy, the new spi_device
      remains dependent on the spi_board_info structure after the new spi_device
      is registered (no other fields in spi_device directly depend on the
      spi_board_info structure; all of the other data is copied).
      
      This causes a problem when dynamically propulating the list of attached
      SPI devices.  For example, in arch/powerpc, the list of SPI devices can be
      populated from data in the device tree.  With the current code, the device
      tree adapter must kmalloc() a new spi_board_info structure for each new
      SPI device it finds in the device tree, and there is no simple mechanism
      in place for keeping track of these allocations.
      
      This patch changes modalias from a 'const char *' to a fixed char array.
      By copying the modalias string instead of referencing it, the dependency
      on the spi_board_info structure is eliminated and an outside caller does
      not need to maintain a separate spi_board_info allocation for each device.
      
      If searched through the code to the best of my ability for any references
      to modalias which may be affected by this change and haven't found
      anything.  It has been tested with the lite5200b platform in arch/powerpc.
      
      [dbrownell@users.sourceforge.net: cope with linux-next changes: KOBJ_NAME_LEN obliterated, etc]
      Signed-off-by: NGrant Likely <grant.likely@secretlab.ca>
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      102eb975
  20. 22 7月, 2008 1 次提交
  21. 07 2月, 2008 2 次提交
  22. 25 1月, 2008 1 次提交
  23. 06 12月, 2007 2 次提交
  24. 15 11月, 2007 1 次提交
  25. 17 10月, 2007 1 次提交
  26. 13 10月, 2007 1 次提交
    • K
      Driver core: change add_uevent_var to use a struct · 7eff2e7a
      Kay Sievers 提交于
      This changes the uevent buffer functions to use a struct instead of a
      long list of parameters. It does no longer require the caller to do the
      proper buffer termination and size accounting, which is currently wrong
      in some places. It fixes a known bug where parts of the uevent
      environment are overwritten because of wrong index calculations.
      
      Many thanks to Mathieu Desnoyers for finding bugs and improving the
      error handling.
      Signed-off-by: NKay Sievers <kay.sievers@vrfy.org>
      Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
      Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      
      7eff2e7a
  27. 01 8月, 2007 1 次提交
    • D
      spi device setup gets better error checking · 082c8cb4
      David Brownell 提交于
      This updates some error reporting paths in SPI device setup:
      
       - Move validation logic for SPI chipselects to spi_new_device(),
         which is where it should always have been.
      
       - In spi_new_device(), emit error messages if the device can't
         be created.  This is LOTS better than a silent failure; though
         eventually, the calling convention should probably change to
         use the <linux/err.h> conventions.
      
       - Includes one previously-missing check:  SPI masters must always
         have at least one chipselect, even for dedicated busses which
         always keep it selected!
      
      It also adds a FIXME (IDR for dynamic ID allocation) so the issue doesn't live
      purely in my mailbox.
      Signed-off-by: NDavid Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      082c8cb4
  28. 22 7月, 2007 1 次提交
  29. 18 7月, 2007 1 次提交
  30. 05 6月, 2007 1 次提交
  31. 09 5月, 2007 1 次提交