1. 14 8月, 2009 1 次提交
  2. 23 6月, 2009 1 次提交
    • H
      V4L/DVB (12107): smscoreapi: fix compile warning · be5daa9b
      Hans Verkuil 提交于
      gcc 4.3.1 generates this warning:
      
      v4l/smscoreapi.c: In function 'smscore_gpio_configure':
      v4l/smscoreapi.c:1481: warning: 'GroupNum' may be used uninitialized in this function
      v4l/smscoreapi.c:1480: warning: 'TranslatedPinNum' may be used uninitialized in this function
      
      While in practice this will not happen, it is something that the compiler
      can't determine. Initializing these two local variables to 0 suppresses
      this warning.
      
      Cc: Udi Atar <udi.linuxtv@gmail.com>
      Signed-off-by: NHans Verkuil <hverkuil@xs4all.nl>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      be5daa9b
  3. 17 6月, 2009 10 次提交
  4. 30 3月, 2009 4 次提交
    • M
      V4L/DVB (10772): siano: prevent duplicate variable declaration · 0d02efe4
      Michael Krufky 提交于
      Fix the following build error:
      
      drivers/media/dvb/siano/smsusb.o: In function `get_order':
      include/asm-generic/page.h:10: multiple definition of `sms_dbg'
      drivers/media/dvb/siano/sms1xxx.o:include/asm-generic/page.h:10: first defined here
      drivers/media/dvb/siano/smsdvb.o: In function `get_order':
      include/asm-generic/page.h:10: multiple definition of `sms_dbg'
      drivers/media/dvb/siano/sms1xxx.o:include/asm-generic/page.h:10: first defined here
      
      Thanks to Mauro Carvalho Chehab for his original patch to address this issue.
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      0d02efe4
    • M
      V4L/DVB (10753): siano: convert EXPORT_SYMBOL to EXPORT_SYMBOL_GPL · a0beec8f
      Michael Krufky 提交于
      As pointed out by Mauro Chehab, we should always use EXPORT_SYMBOL_GPL
      instead of EXPORT_SYMBOL wherever possible.
      
      A message was posted to the linux-media mailing list about this, checking
      with Uri Shkolnik of Siano Mobile Silicon if this is okay to convert.
      
      As per Uri's response to this email, it is OK for us to make this conversion.
      
      http://www.spinics.net/lists/linux-media/msg02200.htmlSigned-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      a0beec8f
    • M
      V4L/DVB (10751): sms1xxx: fix checkpatch.pl violations introduced by previous changeset · b9391f41
      Michael Krufky 提交于
      Fix checkpatch.pl violations introduced by previous changeset:
      
      ERROR: do not use C99 // comments
      156: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1373:
      +//#ifdef DVB_CORE
      
      ERROR: do not use C99 // comments
      157: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1374:
      +//	smsdvb_unregister();
      
      ERROR: do not use C99 // comments
      158: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1375:
      +//#endif
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      163: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1380:
      +EXPORT_SYMBOL(smscore_onresponse);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      164: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1381:
      +EXPORT_SYMBOL(sms_get_board);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      165: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1382:
      +EXPORT_SYMBOL(sms_debug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      166: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1383:
      +EXPORT_SYMBOL(smscore_putbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      167: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1384:
      +EXPORT_SYMBOL(smscore_registry_getmode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      168: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1385:
      +EXPORT_SYMBOL(smscore_register_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      169: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1386:
      +EXPORT_SYMBOL(smscore_set_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      170: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1387:
      +EXPORT_SYMBOL(smscore_start_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      171: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1388:
      +EXPORT_SYMBOL(smsusb_id_table);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      172: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1389:
      +EXPORT_SYMBOL(smscore_unregister_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      173: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1390:
      +EXPORT_SYMBOL(smscore_getbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      174: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1391:
      +EXPORT_SYMBOL(smscore_get_device_mode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      175: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1392:
      +EXPORT_SYMBOL(smscore_register_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      176: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1393:
      +EXPORT_SYMBOL(smscore_unregister_hotplug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      177: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1394:
      +EXPORT_SYMBOL(smsclient_sendrequest);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      178: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1395:
      +EXPORT_SYMBOL(smscore_unregister_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      179: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1396:
      +EXPORT_SYMBOL(smscore_get_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      180: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1397:
      +EXPORT_SYMBOL(smscore_register_hotplug);
      
      WARNING: line over 80 characters
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      ERROR: "foo* bar" should be "foo *bar"
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      WARNING: line over 80 characters
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: "foo* bar" should be "foo *bar"
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: space required after that ',' (ctx:VxV)
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
                                                                                   ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      489: FILE: linux/drivers/media/dvb/siano/smsusb.c:443:
      +	printk(KERN_INFO"%s  Entering status %d.\n", __FUNCTION__, msg.event);
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      501: FILE: linux/drivers/media/dvb/siano/smsusb.c:455:
      +	printk(KERN_INFO  "%s  Entering.\n", __FUNCTION__);
      
      ERROR: space prohibited before that '++' (ctx:WxB)
      505: FILE: linux/drivers/media/dvb/siano/smsusb.c:459:
      +	for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i ++)
       	                                                            ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      517: FILE: linux/drivers/media/dvb/siano/smsusb.c:471:
      +			__FUNCTION__, rc);
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      [mchehab@redhat.com: sms_dbg were declared on 3 different files]
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      b9391f41
    • U
      V4L/DVB (10750): import changes from Siano · e0f14c25
      Uri Shkolnik 提交于
      Import the following changes from Uri Shkolnik
      
      * Two-ways merge with Siano internal repository
      * Continuing with DVB sub-system separation
      * kconfig and makefile updates
      * Code cleanup
      
      This is a work-in-progress sync with Siano's internal repository.
      
      Some changes had to be altered or dropped in order not to break the build.
      
      This breaks normal operation for the current driver, but it is being committed
      now for tracking purposes.
      
      These changes introduce the following checkpatch.pl violations:
      
      ERROR: do not use C99 // comments
      156: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1373:
      +//#ifdef DVB_CORE
      
      ERROR: do not use C99 // comments
      157: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1374:
      +//	smsdvb_unregister();
      
      ERROR: do not use C99 // comments
      158: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1375:
      +//#endif
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      163: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1380:
      +EXPORT_SYMBOL(smscore_onresponse);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      164: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1381:
      +EXPORT_SYMBOL(sms_get_board);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      165: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1382:
      +EXPORT_SYMBOL(sms_debug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      166: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1383:
      +EXPORT_SYMBOL(smscore_putbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      167: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1384:
      +EXPORT_SYMBOL(smscore_registry_getmode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      168: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1385:
      +EXPORT_SYMBOL(smscore_register_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      169: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1386:
      +EXPORT_SYMBOL(smscore_set_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      170: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1387:
      +EXPORT_SYMBOL(smscore_start_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      171: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1388:
      +EXPORT_SYMBOL(smsusb_id_table);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      172: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1389:
      +EXPORT_SYMBOL(smscore_unregister_device);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      173: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1390:
      +EXPORT_SYMBOL(smscore_getbuffer);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      174: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1391:
      +EXPORT_SYMBOL(smscore_get_device_mode);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      175: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1392:
      +EXPORT_SYMBOL(smscore_register_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      176: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1393:
      +EXPORT_SYMBOL(smscore_unregister_hotplug);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      177: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1394:
      +EXPORT_SYMBOL(smsclient_sendrequest);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      178: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1395:
      +EXPORT_SYMBOL(smscore_unregister_client);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      179: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1396:
      +EXPORT_SYMBOL(smscore_get_board_id);
      
      WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
      180: FILE: linux/drivers/media/dvb/siano/smscoreapi.c:1397:
      +EXPORT_SYMBOL(smscore_register_hotplug);
      
      WARNING: line over 80 characters
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      ERROR: "foo* bar" should be "foo *bar"
      391: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:398:
      +extern int smscore_get_fw_filename(struct smscore_device_t *coredev, int mode, char* filename);
      
      WARNING: line over 80 characters
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: "foo* bar" should be "foo *bar"
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
      
      ERROR: space required after that ',' (ctx:VxV)
      392: FILE: linux/drivers/media/dvb/siano/smscoreapi.h:399:
      +extern int smscore_send_fw_file(struct smscore_device_t *coredev, u8* ufwbuf,int size);
                                                                                   ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      489: FILE: linux/drivers/media/dvb/siano/smsusb.c:443:
      +	printk(KERN_INFO"%s  Entering status %d.\n", __FUNCTION__, msg.event);
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      501: FILE: linux/drivers/media/dvb/siano/smsusb.c:455:
      +	printk(KERN_INFO  "%s  Entering.\n", __FUNCTION__);
      
      ERROR: space prohibited before that '++' (ctx:WxB)
      505: FILE: linux/drivers/media/dvb/siano/smsusb.c:459:
      +	for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i ++)
       	                                                            ^
      
      WARNING: __func__ should be used instead of gcc specific __FUNCTION__
      517: FILE: linux/drivers/media/dvb/siano/smsusb.c:471:
      +			__FUNCTION__, rc);
      
      total: 7 errors, 23 warnings, 524 lines checked
      Signed-off-by: NUri Shkolnik <uris@siano-ms.com>
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
      e0f14c25
  5. 30 12月, 2008 2 次提交
  6. 04 9月, 2008 1 次提交
  7. 26 7月, 2008 1 次提交
    • A
      V4L/DVB (8453): sms1xxx: dvb/siano/: cleanups · c5e0bd1a
      Adrian Bunk 提交于
      This patch contains the following cleanups:
      - mark smscore_module_init() as __init
      - mark smscore_module_exit as __exit
      - make the following needlessly global code static:
        - smscoreapi.c: struct g_smscore_notifyees
        - smscoreapi.c: struct g_smscore_devices
        - smscoreapi.c: struct g_smscore_deviceslock
        - smscoreapi.c: struct g_smscore_registry
        - smscoreapi.c: struct g_smscore_registrylock
        - smscoreapi.c: smscore_module_init()
        - smscoreapi.c: smscore_module_exit()
        - smsdvb.c: struct g_smsdvb_clients
        - smsdvb.c: struct g_smsdvb_clientslock
      Signed-off-by: NAdrian Bunk <bunk@kernel.org>
      Signed-off-by: NMichael Krufky <mkrufky@linuxtv.org>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@infradead.org>
      c5e0bd1a
  8. 20 7月, 2008 20 次提交