1. 12 10月, 2013 3 次提交
  2. 10 10月, 2013 23 次提交
  3. 04 10月, 2013 8 次提交
    • D
      drm/i915: Use adjusted_mode in the fastboot hack to disable pfit · d7bf63f2
      Damien Lespiau 提交于
      When booting with i915.fastboot=1, we always take tha code path and end
      up undoing what we're trying to do with adjusted_mode.
      
      Hopefully, as the fastboot hardware readout code is using adjusted_mode
      as well, it should be equivalent.
      Signed-off-by: NDamien Lespiau <damien.lespiau@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      d7bf63f2
    • D
      drm/i915: Add a more detailed comment about the set_base() fastboot hack · bb2043de
      Damien Lespiau 提交于
      Instead of it just being on the mailing list, let's put Jesse's
      explanation next to the code in question.
      Signed-off-by: NDamien Lespiau <damien.lespiau@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      bb2043de
    • J
      drm/i915/vlv: reset DPIO on load and resume v2 · 40e9cf64
      Jesse Barnes 提交于
      DPIO needs to have common reset de-asserted on soft resets like boot and
      S3.  In some cases, the BIOS will have done this for us, but it should
      be safe to do at runtime as well, as long as we do it when the pipes are
      otherwise off.
      
      v2: update bit name to match docs better (Ville)
          reset after CRI clock select (Ville)
      
      References: https://bugs.freedesktop.org/show_bug.cgi?id=69166Signed-off-by: NJesse Barnes <jbarnes@virtuousgeek.org>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      40e9cf64
    • C
      drm/i915: Boost RPS frequency for CPU stalls · b29c19b6
      Chris Wilson 提交于
      If we encounter a situation where the CPU blocks waiting for results
      from the GPU, give the GPU a kick to boost its the frequency.
      
      This should work to reduce user interface stalls and to quickly promote
      mesa to high frequencies - but the cost is that our requested frequency
      stalls high (as we do not idle for long enough before rc6 to start
      reducing frequencies, nor are we aggressive at down clocking an
      underused GPU). However, this should be mitigated by rc6 itself powering
      off the GPU when idle, and that energy use is dependent upon the workload
      of the GPU in addition to its frequency (e.g. the math or sampler
      functions only consume power when used). Still, this is likely to
      adversely affect light workloads.
      
      In particular, this nearly eliminates the highly noticeable wake-up lag
      in animations from idle. For example, expose or workspace transitions.
      (However, given the situation where we fail to downclock, our requested
      frequency is almost always the maximum, except for Baytrail where we
      manually downclock upon idling. This often masks the latency of
      upclocking after being idle, so animations are typically smooth - at the
      cost of increased power consumption.)
      
      Stéphane raised the concern that this will punish good applications and
      reward bad applications - but due to the nature of how mesa performs its
      client throttling, I believe all mesa applications will be roughly
      equally affected. To address this concern, and to prevent applications
      like compositors from permanently boosting the RPS state, we ratelimit the
      frequency of the wait-boosts each client recieves.
      
      Unfortunately, this techinique is ineffective with Ironlake - which also
      has dynamic render power states and suffers just as dramatically. For
      Ironlake, the thermal/power headroom is shared with the CPU through
      Intelligent Power Sharing and the intel-ips module. This leaves us with
      no GPU boost frequencies available when coming out of idle, and due to
      hardware limitations we cannot change the arbitration between the CPU and
      GPU quickly enough to be effective.
      
      v2: Limit each client to receiving a single boost for each active period.
          Tested by QA to only marginally increase power, and to demonstrably
          increase throughput in games. No latency measurements yet.
      
      v3: Cater for front-buffer rendering with manual throttling.
      
      v4: Tidy up.
      
      v5: Sadly the compositor needs frequent boosts as it may never idle, but
      due to its picking mechanism (using ReadPixels) may require frequent
      waits. Those waits, along with the waits for the vrefresh swap, conspire
      to keep the GPU at low frequencies despite the interactive latency. To
      overcome this we ditch the one-boost-per-active-period and just ratelimit
      the number of wait-boosts each client can receive.
      Reported-and-tested-by: NPaul Neumann <paul104x@yahoo.de>
      Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68716Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      Cc: Kenneth Graunke <kenneth@whitecape.org>
      Cc: Stéphane Marchesin <stephane.marchesin@gmail.com>
      Cc: Owen Taylor <otaylor@redhat.com>
      Cc: "Meng, Mengmeng" <mengmeng.meng@intel.com>
      Cc: "Zhuang, Lena" <lena.zhuang@intel.com>
      Reviewed-by: NJesse Barnes <jbarnes@virtuousgeek.org>
      [danvet: No extern for function prototypes in headers.]
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      b29c19b6
    • V
      drm/i915: Don't populate pipe_src_{w,h} multiple times · e41a56be
      Ville Syrjälä 提交于
      If we ever end up doing the retry loop due to bandwidth constraints, we
      would rewrite pipe_src_{w,n} based on adjusted_mode timings. But by that
      time the encoder may have already replaced the adjusted_mode with a
      fixed panel mode, which would then corrupt pipe_src_{w,h}.
      
      v2: Use requested_mode and slap on a big comment from Daniel
      Signed-off-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      e41a56be
    • P
      drm/i915: implement the Haswell mode set sequence workaround · e4916946
      Paulo Zanoni 提交于
      This workaround is described in the mode set sequence documentation.
      When enabling planes for the second pipe, we need to wait for 2
      vblanks on the first pipe. This should solve "a flash of screen
      corruption if planes are enabled on second/third pipe during the time
      that big FIFO mode is exiting". Watermarks are fun :)
      
      v2: Save indentation levels
      Signed-off-by: NPaulo Zanoni <paulo.r.zanoni@intel.com>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      e4916946
    • V
      drm/i915: Disable/enable planes as the first/last thing during modeset on HSW · dda9a66a
      Ville Syrjälä 提交于
      Refactor the plane enabling/disabling into helper functions and move
      the calls to happen as the first thing during .crtc_disable, and the
      last thing during .crtc_enable.
      
      Those are the two clear points where we are sure that the pipe is
      actually running regardless of the encoder type or hardware
      generation.
      
      v2: Made by Paulo:
        Remove the code touching everything but the Haswell functions. We
        need this change on Haswell right now since it fixes a FIFO underrun
        that we get on pipe A while we enable pipe B (see the workaround
        notes on the Haswell mode set sequence documentation). We can bring
        back the code to gens 2-7 later, once they're tested.
      Signed-off-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Signed-off-by: NPaulo Zanoni <paulo.r.zanoni@intel.com>
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      dda9a66a
    • J
      i915/vlv: untangle integrated clock source handling v4 · f6071166
      Jesse Barnes 提交于
      The global integrated clock source bit resides in DPLL B on VLV, but we
      were treating it as a per-pipe resource.  It needs to be set whenever
      any PLL is active, so pull setting the bit out of vlv_update_pll and
      into vlv_enable_pll.  Also add a vlv_disable_pll to prevent disabling it
      when pipe B shuts down.
      
      I'm guessing on the references here, I expect this to bite any config
      where multiple displays are active or displays are moved from pipe to
      pipe.
      
      v2: re-add bits in vlv_update_pll to keep from confusing the state checker
      v3: use enum pipe checks (Daniel)
          set CRI clock source early (Ville)
          consistently set CRI clock source everywhere (Ville)
      v4: drop unnecessary setting of bit in vlv enable pll (Ville)
      
      References: https://bugs.freedesktop.org/show_bug.cgi?id=67245
      References: https://bugs.freedesktop.org/show_bug.cgi?id=69693Signed-off-by: NJesse Barnes <jbarnes@virtuousgeek.org>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      [danvet: s/1/PIPE_B/]
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      f6071166
  4. 01 10月, 2013 6 次提交