ar1021_i2c also supports the ar1020 device I'm using. This is tested.
They also share the same datasheet:

   http://ww1.microchip.com/downloads/en/DeviceDoc/40001393C.pdf

So let users see that they have a compatible in front of them by adding
AR1020 to the driver's description.
Signed-off-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We should not be forcing edge triggered interrupt, but rather let platform
decide the kind of trigger it needs to use. Also, the driver is not quite
safe with regard to edge-triggered interrupts as it does not try to kick
the controller after requesting/enabling IRQ.
Reviewed-By: NChristian Gmeiner <christian.gmeiner@gmail.com>
Tested-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The name field in structure i2c_device_id is 20 characters, and we expect
it to be NULL-terminated, however we are trying to stuff it with 21 bytes
and thus NULL-terminator is lost. This causes issues when one creates
device with name "MICROCHIP_AR1021_I2C" as i2c core cuts off the last "C",
and automatic module loading by alias does not work as result.

The -I2C suffix in the device name is superfluous, we know what bus we are
dealing with, so let's drop it. Also, no other driver uses capitals, and
the manufacturer name is normally not included, except in very rare cases
of incompatible name collisions.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116211
Fixes: dd4cae8b ("Input: Add Microchip AR1021 i2c touchscreen")
Reviewed-By: NChristian Gmeiner <christian.gmeiner@gmail.com>
Tested-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use the common kernel coding style and corrently align parameters with
open parenthesis.
Signed-off-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

clk_prepare_enable() may fail, so we better check its return value and
propagate it in the case of error.
Signed-off-by: NFabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

If imx6ul_tsc_init() fails we should not return directly.

We should disable the previously acquired clocks in this case.
Signed-off-by: NFabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

According to the previous error handling code, it is likely that 'goto
err_free_keymap' is expected here in order to avoid a memory leak in error
handling path.
Signed-off-by: NChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

There are several quirky Xbox One pads that depend on initialization
packets that the Microsoft pads don't require. To deal with these,
I've added a mechanism for issuing device-specific initialization
packets using a VID/PID-based quirks list.

For the initial set of init quirks, I have added quirk handling from
Valve's Steam Link xpad driver[0] and the 360Controller project[1] for
macOS to enable some new pads to work properly.

This should enable full functionality on the following quirky pads:
0x0e6f:0x0165 - Titanfall 2 gamepad (previously fully non-functional)
0x0f0d:0x0067 - Hori Horipad (analog sticks previously non-functional)
0x24c6:0x541a - PowerA Xbox One pad (previously fully non-functional)
0x24c6:0x542a - PowerA Xbox One pad (previously fully non-functional)
0x24c6:0x543a - PowerA Xbox One pad (previously fully non-functional)

[0]: https://github.com/ValveSoftware/steamlink-sdk/blob/master/kernel/drivers/input/joystick/xpad.c
[1]: https://github.com/360Controller/360ControllerSigned-off-by: NCameron Gutman <aicommander@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

sparse says

 warning: incorrect type in assignment (different base types)
    expected unsigned short [unsigned] [usertype] offset
    got restricted __be16 [usertype] <noident>

for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the
first place shouldn't hurt.
Signed-off-by: NMartin Kepplinger <martin.kepplinger@ginzinger.com>
Signed-off-by: Henk.Vergonet@gmail.com
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use setup_timer() instead of init_timer() to simplify the code.
Signed-off-by: NGeliang Tang <geliangtang@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use setup_timer() instead of init_timer() to simplify the code.
Signed-off-by: NGeliang Tang <geliangtang@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use setup_timer() instead of init_timer() to simplify the code.
Signed-off-by: NGeliang Tang <geliangtang@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use setup_timer() instead of init_timer() to simplify the code.
Signed-off-by: NGeliang Tang <geliangtang@gmail.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

When submitting the support for the ACPI0011 windows tablet keys device I
mapped the "windows" logo homekey to KEY_HOMEPAGE. But this is inconsistent
with how it is done on windows tablets using the old PNP0C40 ACPI device
and it does not match the HUT spec, which says that usage-page 7 usage 0xe3
is "Keyboard Left GUI".

This commit maps usage-page 7 usage 0xe3 to KEY_LEFTMETA fixing this.

Fixes: 4c3362f4 ("Input: soc_button_array - add support for ACPI 6.0...")
Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add pm8xxx_regs for this PMIC and the device tree match table entry.
Signed-off-by: NDamien Riegel <damien.riegel@savoirfairelinux.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Some PMIC vibrator IPs use a separate enable register to turn the
vibrator on and off. To detect if a vibrator uses this feature, rely on
the enable_mask being non-zero.
Signed-off-by: NDamien Riegel <damien.riegel@savoirfairelinux.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

In order to prepare this driver to support other vibrators of the same
kind, move some hardcoded values to a structure holding register
parameters (address, mask, shit of the control register).
Signed-off-by: NDamien Riegel <damien.riegel@savoirfairelinux.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NDamien Riegel <damien.riegel@savoirfairelinux.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

sparse says:

  sur40.c:372:40: warning: restricted __le32 degrades to integer

the header's data is __le32 so we need to convert it before comparing.
Signed-off-by: NMartin Kepplinger <martink@posteo.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

gpiod API allows standard way of specifying GPIO polarity and takes it into
account when reading or setting GPIO state. It also allows us to switch to
common way of obtaining GPIO descriptor and away form legacy platform data.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of keying interrupt trigger off GPIO polarity, let's rely on
platform code to set it up properly for us.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of having standard interrupt handler and manually firing work item
to perform I2C reads, let's switch to threaded interrupts, which were
designed specifically for this purpose.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We are reading GPIO state in a non-atomic context (workqueue), so we can
use "cansleep" variant, and thus make the driver available on systems where
GPIO controllers require sleeping when reading GPIO state.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of expecting that GPIO is always interrupt source, let's use
interrupt specified in I2C client.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Using devm_* APIs simpifies error handling and device teardown.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use input_set_capability() instead of manipulating evbit/keybit
masks directly.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of manually converting big endian data on wire into host
endianness, let's use helpers to do that for us. It might save us
a few cycles if host endianness matches what's on wire.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use idiomatic BIT(n) to form single-bit masks.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Also rename 'priv' variables to eeti.
Reviewed-by: NDaniel Mack <daniel@zonque.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We are not registering drivers, but transport devices (AKA sensors), so
let's call them that.

Also let's rename "retval" to "error" in probe() functions as the variables
are used to store error codes.
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

There is no reason to copy structures field-by-filed when we can copy
elements at once.
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The mapping table holds address in LE form, so we should convert it
to CPU when comparing it.
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

If rmi_enable_sensor() fails in rmi_driver_probe(), we should not return
immediately, but disable IRQs and tear down function list.
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The rest of the kernel uses u8, u16, etc for data coming form hardware,
let's switch ti using u8 here as well.

Also turn pkt_type into an enum.
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Let's stop using -1 as a universal return value and instead propagate
errors from underlying calls up the stack.
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use standard infrastructure, such as BIT and GENMASK, instead of rolling
bitmasks by hand.
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Factor out querying and parsing 3-byte response into an integer value.
Reviewed-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Now that i2c_client_type structure is exported, we can use it, instead
of i2c_adapter_type, when looking for devices that are i2c clients.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Some form factors (detachables/tablets) may not have a keyboard and
thus user may have to resort to using a defined EC UI to send sysrq(s)
to the kernel in order to collect crash info etc. This UI typically
is in the form of user pressing volume / power buttons in some specific
sequence and for some specific time. Add a new EC event that allows EC
to communicate the sysrq to the AP.

(We're skipping event number 5 because it has been reserved for
something else)
Signed-off-by: NRajat Jain <rajatja@google.com>
Acked-by: NLee Jones <lee.jones@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

When trying to destroy platform data after destruction of SMbus companion,
we need to make sure that we are actually dealing with an SMB companion
device, and not some random I2C client device.

Fixes: 8eb92e5c ("Input: psmouse - add support for SMBus companions")
Reported-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Tested-by: NBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>