1. 22 6月, 2016 2 次提交
    • I
      drm/i915: Initialize the PPS HW before its first use · 0080b5da
      Imre Deak 提交于
      The initial DPCD read for eDP detection involves using the PPS, but so
      far we only initialized the PPS registers after the DPCD read. The
      reason this was done so far is to preserve a possible LVDS PPS HW setup
      if LVDS is detected but eDP is not. This is not an issue any more after
      the previous patch, so we can move the init earlier now.
      
      This was caught by CI with the PPS sanity checks in place and the
      initial eDP DPCD readout waiting for the panel power cycle timeout
      without the PPS registers being initialized.
      
      CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
      CC: Chris Wilson <chris@chris-wilson.co.uk>
      Signed-off-by: NImre Deak <imre.deak@intel.com>
      Reviewed-by: NChris Wilson <chris@chris-wilson.co.uk>
      Reviewed-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
      Link: http://patchwork.freedesktop.org/patch/msgid/1466499109-20240-3-git-send-email-imre.deak@intel.com
      0080b5da
    • I
      drm/i915/ibx, cpt: Don't attempt to register eDP if LVDS was detected · 97a824e1
      Imre Deak 提交于
      Atm on IBX/CPT we attempt to detect if eDP is present even if LVDS was
      already detected and an encoder for it was registered. This involves
      trying to read out the eDP DPCD, which in turn needs the same power
      sequencer that LVDS uses. Poking at the VDD line at an unexpected time
      may or may not interfere with the LVDS panel, but it's probably safer to
      prevent this. Registering both an LVDS and an eDP connector would also
      present a similar problem accessing the shared PPS at any point later in
      an unexpected way.
      
      We also need this to be able fix PPS initialization before its first use
      in the next patch. For that we want to be sure that PPS is not in use
      by LVDS.
      
      v2:
      - Split out the PPS init fix to a separate patch. (Chris)
      - Add comment about eDP init depending on LVDS init. (Chris)
      - Make the use of the intel_encoder ptr less error prone.
      v3:
      - Use IBX/CPT reference instead of the incorrect ILK, add a WARN about
        this. (Ville)
      v4:
      - Use a helper to get the lvds encoder instead of opencoding the same.
        (Ville)
      
      CC: Ville Syrjälä <ville.syrjala@linux.intel.com>
      CC: Chris Wilson <chris@chris-wilson.co.uk>
      Signed-off-by: NImre Deak <imre.deak@intel.com>
      Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> (v2)
      Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> (v3)
      Link: http://patchwork.freedesktop.org/patch/msgid/1466499109-20240-2-git-send-email-imre.deak@intel.com
      97a824e1
  2. 21 6月, 2016 16 次提交
  3. 20 6月, 2016 4 次提交
  4. 18 6月, 2016 9 次提交
  5. 17 6月, 2016 1 次提交
  6. 16 6月, 2016 8 次提交