1. 12 11月, 2013 3 次提交
    • A
      perf tests: Use lower sample_freq in sw clock event period test · 67c1e4a5
      Arnaldo Carvalho de Melo 提交于
      We were using it at 10 kHz, which doesn't work in machines where somehow
      the max freq was auto reduced by the kernel:
      
      [root@ssdandy ~]# perf test 19
      19: Test software clock events have valid period values    : FAILED!
      [root@ssdandy ~]# perf test -v 19
      19: Test software clock events have valid period values    :
      --- start ---
      Couldn't open evlist: Invalid argument
      ---- end ----
      Test software clock events have valid period values: FAILED!
      [root@ssdandy ~]#
      
      [root@ssdandy ~]# cat /proc/sys/kernel/perf_event_max_sample_rate
      7000
      
      Reducing it to 500 Hz should be good enough for this test and also
      shouldn't affect what it is testing.
      
      But warn the user if it fails, informing the knob and the freq tried.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-548rhj1uo6xbwnxa95kw3hqe@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      67c1e4a5
    • A
      perf tests: Check return of perf_evlist__open sw clock event period test · d0b849e9
      Arnaldo Carvalho de Melo 提交于
      We were not checking if we successfully opened the counters, i.e. if
      sys_perf_event_open worked, when it doesn't in this test, we were
      continuing anyway and then segfaulting when trying to access the file
      descriptor array, that at that point had been freed in perf_evlist__open
      error path:
      
      [root@ssdandy ~]# perf test -v 19
      19: Test software clock events have valid period values    :
      --- start ---
      Segmentation fault (core dumped)
      [root@ssdandy ~]#
      
      Do the check and bail out instead.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-6qy8ljkn0e9hm7bh7keo5z68@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      d0b849e9
    • A
      perf evsel: Remove idx parm from constructor · ef503831
      Arnaldo Carvalho de Melo 提交于
      Most uses of the evsel constructor are followed by a call to
      perf_evlist__add with an idex of evlist->nr_entries, so make rename
      the current constructor to perf_evsel__new_idx and remove the need
      for passing the constructor for the common case.
      
      We still need the new_idx variant because the way groups are handled,
      with evsel->nr_members holding the number of entries in an evlist,
      partitioning the evlist into sublists inside a single linked list.
      
      This asks for a clarifying refactoring, but for now simplify the non
      parser cases, so that tool writers don't have to bother with evsel idx
      setting.
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-zy9tskx6jqm2rmw7468zze2a@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      ef503831
  2. 29 10月, 2013 1 次提交
  3. 18 3月, 2013 1 次提交