提交 fda76e32 编写于 作者: P Pietro Borrello 提交者: Jialin Zhang

HID: check empty report_list in bigben_probe()

stable inclusion
from stable-v5.10.166
commit 20fd4598762e2d717deb64ef028e6f5f587ac2a6
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I6KCIO
CVE: CVE-2023-1073

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=20fd4598762e2d717deb64ef028e6f5f587ac2a6

--------------------------------

Add a check for empty report_list in bigben_probe().
The missing check causes a type confusion when issuing a list_entry()
on an empty report_list.
The problem is caused by the assumption that the device must
have valid report_list. While this will be true for all normal HID
devices, a suitably malicious device can violate the assumption.

Fixes: 256a90ed ("HID: hid-bigbenff: driver for BigBen Interactive PS3OFMINIPAD gamepad")
Signed-off-by: NPietro Borrello <borrello@diag.uniroma1.it>
Signed-off-by: NJiri Kosina <jkosina@suse.cz>
Signed-off-by: NLin Yujun <linyujun809@huawei.com>
Reviewed-by: NLiao Chang <liaochang1@huawei.com>
Reviewed-by: NZhang Jianhua <chris.zjh@huawei.com>
Signed-off-by: NJialin Zhang <zhangjialin11@huawei.com>
上级 7fdd4395
...@@ -344,6 +344,11 @@ static int bigben_probe(struct hid_device *hid, ...@@ -344,6 +344,11 @@ static int bigben_probe(struct hid_device *hid,
} }
report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list; report_list = &hid->report_enum[HID_OUTPUT_REPORT].report_list;
if (list_empty(report_list)) {
hid_err(hid, "no output report found\n");
error = -ENODEV;
goto error_hw_stop;
}
bigben->report = list_entry(report_list->next, bigben->report = list_entry(report_list->next,
struct hid_report, list); struct hid_report, list);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册