提交 fcea758a 编写于 作者: H Hugh Dickins 提交者: Zheng Zengkai

mm: page_vma_mapped_walk(): prettify PVMW_MIGRATION block

stable inclusion
from stable-5.10.47
commit 8dc191ed9c5f7af7f6cd1ebea3f281db353fe442
bugzilla: 172973 https://gitee.com/openeuler/kernel/issues/I4DAKB

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=8dc191ed9c5f7af7f6cd1ebea3f281db353fe442

--------------------------------

commit e2e1d407 upstream.

page_vma_mapped_walk() cleanup: rearrange the !pmd_present() block to
follow the same "return not_found, return not_found, return true"
pattern as the block above it (note: returning not_found there is never
premature, since existence or prior existence of huge pmd guarantees
good alignment).

Link: https://lkml.kernel.org/r/378c8650-1488-2edf-9647-32a53cf2e21@google.comSigned-off-by: NHugh Dickins <hughd@google.com>
Acked-by: NKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: NPeter Xu <peterx@redhat.com>
Cc: Alistair Popple <apopple@nvidia.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Ralph Campbell <rcampbell@nvidia.com>
Cc: Wang Yugui <wangyugui@e16-tech.com>
Cc: Will Deacon <will@kernel.org>
Cc: Yang Shi <shy828301@gmail.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NChen Jun <chenjun102@huawei.com>
Acked-by: NWeilong Chen <chenweilong@huawei.com>
Signed-off-by: NChen Jun <chenjun102@huawei.com>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
上级 2befed6d
...@@ -197,24 +197,22 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) ...@@ -197,24 +197,22 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
if (pmd_page(pmde) != page) if (pmd_page(pmde) != page)
return not_found(pvmw); return not_found(pvmw);
return true; return true;
} else if (!pmd_present(pmde)) { }
if (thp_migration_supported()) { if (!pmd_present(pmde)) {
if (!(pvmw->flags & PVMW_MIGRATION)) swp_entry_t entry;
return not_found(pvmw);
if (is_migration_entry(pmd_to_swp_entry(pmde))) {
swp_entry_t entry = pmd_to_swp_entry(pmde);
if (migration_entry_to_page(entry) != page) if (!thp_migration_supported() ||
return not_found(pvmw); !(pvmw->flags & PVMW_MIGRATION))
return true; return not_found(pvmw);
} entry = pmd_to_swp_entry(pmde);
} if (!is_migration_entry(entry) ||
return not_found(pvmw); migration_entry_to_page(entry) != page)
} else { return not_found(pvmw);
/* THP pmd was split under us: handle on pte level */ return true;
spin_unlock(pvmw->ptl);
pvmw->ptl = NULL;
} }
/* THP pmd was split under us: handle on pte level */
spin_unlock(pvmw->ptl);
pvmw->ptl = NULL;
} else if (!pmd_present(pmde)) { } else if (!pmd_present(pmde)) {
/* /*
* If PVMW_SYNC, take and drop THP pmd lock so that we * If PVMW_SYNC, take and drop THP pmd lock so that we
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册