未验证 提交 fc94224c 编写于 作者: C Chen-Yu Tsai 提交者: Robert Foss

drm/bridge: parade-ps8640: Fix regulator supply order

The datasheet says that VDD12 must be enabled and at full voltage before
VDD33 is enabled.

Reorder the bulk regulator supply names so that VDD12 is enabled before
VDD33. Any enable ramp delays should be handled by setting proper
constraints on the regulators.

Fixes: bc1aee7f ("drm/bridge: Add I2C based driver for ps8640 bridge")
Signed-off-by: NChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: NNeil Armstrong <narmstrong@baylibre.com>
Signed-off-by: NRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220721092258.3397461-1-wenst@chromium.org
上级 2b8428a1
...@@ -631,8 +631,8 @@ static int ps8640_probe(struct i2c_client *client) ...@@ -631,8 +631,8 @@ static int ps8640_probe(struct i2c_client *client)
if (!ps_bridge) if (!ps_bridge)
return -ENOMEM; return -ENOMEM;
ps_bridge->supplies[0].supply = "vdd33"; ps_bridge->supplies[0].supply = "vdd12";
ps_bridge->supplies[1].supply = "vdd12"; ps_bridge->supplies[1].supply = "vdd33";
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ps_bridge->supplies), ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ps_bridge->supplies),
ps_bridge->supplies); ps_bridge->supplies);
if (ret) if (ret)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册