未验证 提交 fb6c83ca 编写于 作者: P Pierre-Louis Bossart 提交者: Mark Brown

ASoC: AMD: fix depend/select mistake on SND_AMD_ACP_CONFIG

on i386 or x86_64:

when # CONFIG_ACPI is not set,
so SND_SOC_ACPI is not set:

WARNING: unmet direct dependencies detected for SND_AMD_ACP_CONFIG
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
  SND_SOC_ACPI [=n]
  Selected by [y]:
  - SND_SOC_AMD_ACP_COMMON [=y] && SOUND [=y] && !UML && SND [=y] &&
  SND_SOC [=y] && X86 [=y] && PCI [=y]

This problem is due to the unconditional selection of
SND_AMD_ACP_CONFIG in other options. Using 'depends on' solved an
initial problem but exposed another, let's use select instead.
Reported-by: NRandy Dunlap <rdunlap@infradead.org>
Fixes: d9b994cd ('ASoC: AMD: acp-config: fix missing dependency on SND_SOC_ACPI')
Signed-off-by: NPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Reviewed-by: NDaniel Baluta <daniel.baluta@nxp.com>
Reviewed-by: NRanjani Sridharan <ranjani.sridharan@intel.com>
Reviewed-by: NAjit Kumar Pandey <AjitKumar.Pandey@amd.com>
Link: https://lore.kernel.org/r/20211215163511.151286-1-pierre-louis.bossart@linux.intel.comSigned-off-by: NMark Brown <broonie@kernel.org>
上级 88dffe43
...@@ -98,7 +98,7 @@ config SND_SOC_AMD_YC_MACH ...@@ -98,7 +98,7 @@ config SND_SOC_AMD_YC_MACH
config SND_AMD_ACP_CONFIG config SND_AMD_ACP_CONFIG
tristate "AMD ACP configuration selection" tristate "AMD ACP configuration selection"
depends on SND_SOC_ACPI select SND_SOC_ACPI if ACPI
help help
This option adds an auto detection to determine which ACP This option adds an auto detection to determine which ACP
driver modules to use driver modules to use
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册