提交 f639554b 编写于 作者: G Greg Kroah-Hartman

USB: gadget: ci13xx_udc: fix potential crash in irq handler

As pointed out by Dan Carpenter, we should not be trying to call
dev_err() on a structure that was previously determined to be NULL,
that's just foolish and asking for trouble.

So just delete the message, it's not going to do anyone any good to have
it anyway.

This problem was caused by 0f089094: "usb: gadget: ci13xxx: replace
home-brewed logging with dev_{err,warn,info}"
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 126625e1
......@@ -2719,10 +2719,8 @@ static irqreturn_t udc_irq(int irq, void *data)
trace(udc ? udc->dev : NULL, "");
if (udc == NULL) {
dev_err(udc->dev, "ENODEV");
if (udc == NULL)
return IRQ_HANDLED;
}
spin_lock(&udc->lock);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册