提交 f560cd50 编写于 作者: F Florian Eckert 提交者: Andy Shevchenko

platform/x86: pcengines-apuv2: revert wiring up simswitch GPIO as LED

This reverts commit 5037d4dd.

Explanation why this does not work:
This change connects the simswap to the LED subsystem of the kernel.
From my point of view, it's nonsense. If we do it this way, then this
can be switched relatively easily via the LED subsystem (trigger:
none/default-on) and that is dangerous! If this is used, it would be
unfavorable, since there is also another trigger (trigger:
heartbeat/netdev).

Therefore, this simswap GPIO should remain in the GPIO
subsystem and be switched via it and not be connected to the LED
subsystem. To avoid the problems mentioned above. The LED subsystem is
not made for this and it is not a good compromise, but rather dangerous.
Signed-off-by: NFlorian Eckert <fe@dev.tdt.de>
Signed-off-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
上级 f9e11043
...@@ -78,7 +78,6 @@ static const struct gpio_led apu2_leds[] = { ...@@ -78,7 +78,6 @@ static const struct gpio_led apu2_leds[] = {
{ .name = "apu:green:1" }, { .name = "apu:green:1" },
{ .name = "apu:green:2" }, { .name = "apu:green:2" },
{ .name = "apu:green:3" }, { .name = "apu:green:3" },
{ .name = "apu:simswap" },
}; };
static const struct gpio_led_platform_data apu2_leds_pdata = { static const struct gpio_led_platform_data apu2_leds_pdata = {
...@@ -95,8 +94,6 @@ static struct gpiod_lookup_table gpios_led_table = { ...@@ -95,8 +94,6 @@ static struct gpiod_lookup_table gpios_led_table = {
NULL, 1, GPIO_ACTIVE_LOW), NULL, 1, GPIO_ACTIVE_LOW),
GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_LED3, GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_LED3,
NULL, 2, GPIO_ACTIVE_LOW), NULL, 2, GPIO_ACTIVE_LOW),
GPIO_LOOKUP_IDX(AMD_FCH_GPIO_DRIVER_NAME, APU2_GPIO_LINE_SIMSWAP,
NULL, 3, GPIO_ACTIVE_LOW),
} }
}; };
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册