提交 f53bd142 编写于 作者: A Al Viro

__ufs_truncate_blocks(): avoid excessive dirtying of indirect blocks

There's a case when an indirect block gets dirtied for no good
reason - when there's a hole starting in the middle of area
covered by it and spanning past its end, and truncate() is done
precisely to the beginning of the hole.

The block is obviously not modified at all - all removals happen
beyond it.  However, existing code ends up dirtying it just in
case.  It's trivial to fix and while it's not a real bug by any
stretch of imagination, it makes the damn thing harder to follow.
Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
上级 cc7231e3
......@@ -1251,10 +1251,8 @@ static void __ufs_truncate_blocks(struct inode *inode)
}
p = ubh_get_data_ptr(uspi, ubh[i], offsets[i + 1]);
}
while (i--) {
ubh_mark_buffer_dirty(ubh[i]);
while (i--)
free_branch_tail(inode, offsets[i + 1], ubh[i], depth - i - 1);
}
}
for (i = offsets[0]; i <= UFS_TIND_BLOCK; i++) {
p = ufs_get_direct_data_ptr(uspi, ufsi, i);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册