提交 f3df00c5 编写于 作者: C Christoph Hellwig 提交者: Yang Yingliang

nvme: do not try to reconfigure APST when the controller is not live

stable inclusion
from linux-4.19.191
commit a3dd6095f1a66fd05fe79c96fb9f7a3a13d0ca03

--------------------------------

commit 53fe2a30 upstream.

Do not call nvme_configure_apst when the controller is not live, given
that nvme_configure_apst will fail due the lack of an admin queue when
the controller is being torn down and nvme_set_latency_tolerance is
called from dev_pm_qos_hide_latency_tolerance.

Fixes: 510a405d("nvme: fix memory leak for power latency tolerance")
Reported-by: NPeng Liu <liupeng17@lenovo.com>
Signed-off-by: NChristoph Hellwig <hch@lst.de>
Reviewed-by: NKeith Busch <kbusch@kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 fc819071
...@@ -2180,7 +2180,8 @@ static void nvme_set_latency_tolerance(struct device *dev, s32 val) ...@@ -2180,7 +2180,8 @@ static void nvme_set_latency_tolerance(struct device *dev, s32 val)
if (ctrl->ps_max_latency_us != latency) { if (ctrl->ps_max_latency_us != latency) {
ctrl->ps_max_latency_us = latency; ctrl->ps_max_latency_us = latency;
nvme_configure_apst(ctrl); if (ctrl->state == NVME_CTRL_LIVE)
nvme_configure_apst(ctrl);
} }
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册