提交 f3848af1 编写于 作者: J Jeff Layton 提交者: Ilya Dryomov

ceph: have MDS map decoding use entity_addr_t decoder

Signed-off-by: NJeff Layton <jlayton@kernel.org>
Reviewed-by: N"Yan, Zheng" <zyan@redhat.com>
Signed-off-by: NIlya Dryomov <idryomov@gmail.com>
上级 8cb5f2b4
...@@ -107,7 +107,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) ...@@ -107,7 +107,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end)
struct ceph_mdsmap *m; struct ceph_mdsmap *m;
const void *start = *p; const void *start = *p;
int i, j, n; int i, j, n;
int err = -EINVAL; int err;
u8 mdsmap_v, mdsmap_cv; u8 mdsmap_v, mdsmap_cv;
u16 mdsmap_ev; u16 mdsmap_ev;
...@@ -183,8 +183,9 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) ...@@ -183,8 +183,9 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end)
inc = ceph_decode_32(p); inc = ceph_decode_32(p);
state = ceph_decode_32(p); state = ceph_decode_32(p);
state_seq = ceph_decode_64(p); state_seq = ceph_decode_64(p);
ceph_decode_copy(p, &addr, sizeof(addr)); err = ceph_decode_entity_addr(p, end, &addr);
ceph_decode_addr(&addr); if (err)
goto corrupt;
ceph_decode_copy(p, &laggy_since, sizeof(laggy_since)); ceph_decode_copy(p, &laggy_since, sizeof(laggy_since));
*p += sizeof(u32); *p += sizeof(u32);
ceph_decode_32_safe(p, end, namelen, bad); ceph_decode_32_safe(p, end, namelen, bad);
...@@ -357,7 +358,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) ...@@ -357,7 +358,7 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end)
nomem: nomem:
err = -ENOMEM; err = -ENOMEM;
goto out_err; goto out_err;
bad: corrupt:
pr_err("corrupt mdsmap\n"); pr_err("corrupt mdsmap\n");
print_hex_dump(KERN_DEBUG, "mdsmap: ", print_hex_dump(KERN_DEBUG, "mdsmap: ",
DUMP_PREFIX_OFFSET, 16, 1, DUMP_PREFIX_OFFSET, 16, 1,
...@@ -365,6 +366,9 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end) ...@@ -365,6 +366,9 @@ struct ceph_mdsmap *ceph_mdsmap_decode(void **p, void *end)
out_err: out_err:
ceph_mdsmap_destroy(m); ceph_mdsmap_destroy(m);
return ERR_PTR(err); return ERR_PTR(err);
bad:
err = -EINVAL;
goto corrupt;
} }
void ceph_mdsmap_destroy(struct ceph_mdsmap *m) void ceph_mdsmap_destroy(struct ceph_mdsmap *m)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册