提交 f375a49f 编写于 作者: B Brian Masney 提交者: Jonathan Cameron

staging: iio: tsl2583: add error code to sysfs store functions

in_illuminance_input_target_store() and in_illuminance_calibrate_store()
validated the data from userspace, however it would not return an
error code to userspace if an invalid value was passed in. This patch
changes these functions so that they return -EINVAL if invalid data is
passed in.
Signed-off-by: NBrian Masney <masneyb@onstation.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>
上级 b2fa81be
......@@ -525,11 +525,10 @@ static ssize_t in_illuminance_input_target_store(struct device *dev,
struct tsl2583_chip *chip = iio_priv(indio_dev);
int value;
if (kstrtoint(buf, 0, &value))
if (kstrtoint(buf, 0, &value) || !value)
return -EINVAL;
if (value)
chip->taos_settings.als_cal_target = value;
chip->taos_settings.als_cal_target = value;
return len;
}
......@@ -541,11 +540,10 @@ static ssize_t in_illuminance_calibrate_store(struct device *dev,
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
int value;
if (kstrtoint(buf, 0, &value))
if (kstrtoint(buf, 0, &value) || value != 1)
return -EINVAL;
if (value == 1)
taos_als_calibrate(indio_dev);
taos_als_calibrate(indio_dev);
return len;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册