提交 ef87c5d6 编写于 作者: M Markus Elfring 提交者: David S. Miller

net: pktgen: Deletion of an unnecessary check before the function call "proc_remove"

The proc_remove() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 1abe7cd9
...@@ -3728,8 +3728,7 @@ static int pktgen_remove_device(struct pktgen_thread *t, ...@@ -3728,8 +3728,7 @@ static int pktgen_remove_device(struct pktgen_thread *t,
/* Remove proc before if_list entry, because add_device uses /* Remove proc before if_list entry, because add_device uses
* list to determine if interface already exist, avoid race * list to determine if interface already exist, avoid race
* with proc_create_data() */ * with proc_create_data() */
if (pkt_dev->entry) proc_remove(pkt_dev->entry);
proc_remove(pkt_dev->entry);
/* And update the thread if_list */ /* And update the thread if_list */
_rem_dev_from_if_list(t, pkt_dev); _rem_dev_from_if_list(t, pkt_dev);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册