提交 e5bd12bf 编写于 作者: E Eric Sandeen 提交者: Dave Chinner

xfs: don't pass value into attr ->put_listent

The value is not used; only names and value lengths are
returned.  Remove the argument.
Signed-off-by: NEric Sandeen <sandeen@redhat.com>
Reviewed-by: NChristoph Hellwig <hch@lst.de>
Signed-off-by: NDave Chinner <david@fromorbit.com>
上级 2a6fba6d
...@@ -114,7 +114,7 @@ typedef struct attrlist_cursor_kern { ...@@ -114,7 +114,7 @@ typedef struct attrlist_cursor_kern {
/* Return 0 on success, or -errno; other state communicated via *context */ /* Return 0 on success, or -errno; other state communicated via *context */
typedef int (*put_listent_func_t)(struct xfs_attr_list_context *, int, typedef int (*put_listent_func_t)(struct xfs_attr_list_context *, int,
unsigned char *, int, int, unsigned char *); unsigned char *, int, int);
typedef struct xfs_attr_list_context { typedef struct xfs_attr_list_context {
struct xfs_inode *dp; /* inode */ struct xfs_inode *dp; /* inode */
......
...@@ -106,8 +106,7 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context) ...@@ -106,8 +106,7 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context)
sfe->flags, sfe->flags,
sfe->nameval, sfe->nameval,
(int)sfe->namelen, (int)sfe->namelen,
(int)sfe->valuelen, (int)sfe->valuelen);
&sfe->nameval[sfe->namelen]);
if (error) if (error)
return error; return error;
/* /*
...@@ -198,8 +197,7 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context) ...@@ -198,8 +197,7 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context)
sbp->flags, sbp->flags,
sbp->name, sbp->name,
sbp->namelen, sbp->namelen,
sbp->valuelen, sbp->valuelen);
&sbp->name[sbp->namelen]);
if (error) { if (error) {
kmem_free(sbuf); kmem_free(sbuf);
return error; return error;
...@@ -430,8 +428,7 @@ xfs_attr3_leaf_list_int( ...@@ -430,8 +428,7 @@ xfs_attr3_leaf_list_int(
entry->flags, entry->flags,
name_loc->nameval, name_loc->nameval,
(int)name_loc->namelen, (int)name_loc->namelen,
be16_to_cpu(name_loc->valuelen), be16_to_cpu(name_loc->valuelen));
&name_loc->nameval[name_loc->namelen]);
if (retval) if (retval)
return retval; return retval;
} else { } else {
...@@ -459,16 +456,14 @@ xfs_attr3_leaf_list_int( ...@@ -459,16 +456,14 @@ xfs_attr3_leaf_list_int(
entry->flags, entry->flags,
name_rmt->name, name_rmt->name,
(int)name_rmt->namelen, (int)name_rmt->namelen,
valuelen, valuelen);
args.value);
kmem_free(args.value); kmem_free(args.value);
} else { } else {
retval = context->put_listent(context, retval = context->put_listent(context,
entry->flags, entry->flags,
name_rmt->name, name_rmt->name,
(int)name_rmt->namelen, (int)name_rmt->namelen,
valuelen, valuelen);
NULL);
} }
if (retval) if (retval)
return retval; return retval;
...@@ -549,8 +544,7 @@ xfs_attr_put_listent( ...@@ -549,8 +544,7 @@ xfs_attr_put_listent(
int flags, int flags,
unsigned char *name, unsigned char *name,
int namelen, int namelen,
int valuelen, int valuelen)
unsigned char *value)
{ {
struct attrlist *alist = (struct attrlist *)context->alist; struct attrlist *alist = (struct attrlist *)context->alist;
attrlist_ent_t *aep; attrlist_ent_t *aep;
......
...@@ -166,8 +166,7 @@ xfs_xattr_put_listent( ...@@ -166,8 +166,7 @@ xfs_xattr_put_listent(
int flags, int flags,
unsigned char *name, unsigned char *name,
int namelen, int namelen,
int valuelen, int valuelen)
unsigned char *value)
{ {
char *prefix; char *prefix;
int prefix_len; int prefix_len;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册