ext4: fix ext4_error_err save negative errno into superblock

stable inclusion
from stable-5.10.36
commit bf4ba04f0161c8b17cfca9cd32118a6215593b30
bugzilla: 51867
CVE: NA

--------------------------------

commit 6810fad9 upstream.

Fix As write_mmp_block() so that it returns -EIO instead of 1, so that
the correct error gets saved into the superblock.

Cc: stable@kernel.org
Fixes: 54d3adbc ("ext4: save all error info in save_error_info() and drop ext4_set_errno()")
Reported-by: NLiu Zhi Qiang <liuzhiqiang26@huawei.com>
Signed-off-by: NYe Bin <yebin10@huawei.com>
Reviewed-by: NAndreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20210406025331.148343-1-yebin10@huawei.comSigned-off-by: NTheodore Ts'o <tytso@mit.edu>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NChen Jun <chenjun102@huawei.com>
Acked-by: NWeilong Chen <chenweilong@huawei.com>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>

fs/ext4/mmp.c

@@ -56,7 +56,7 @@ static int write_mmp_block(struct super_block *sb, struct buffer_head *bh)
 	wait_on_buffer(bh);
 	sb_end_write(sb);
 	if (unlikely(!buffer_uptodate(bh)))
-		return 1;
+		return -EIO;
 
 	return 0;
 }