提交 e038f7b8 编写于 作者: P Peter Zijlstra 提交者: Ingo Molnar

cpuidle, psci: Push RCU-idle into driver

Doing RCU-idle outside the driver, only to then temporarily enable it
again, at least twice, before going idle is suboptimal.

Notably once implicitly through the cpu_pm_*() calls and once
explicitly doing ct_irq_*_irqon().
Signed-off-by: NPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: NIngo Molnar <mingo@kernel.org>
Tested-by: NKajetan Puchalski <kajetan.puchalski@arm.com>
Tested-by: NTony Lindgren <tony@atomide.com>
Tested-by: NUlf Hansson <ulf.hansson@linaro.org>
Reviewed-by: NFrederic Weisbecker <frederic@kernel.org>
Reviewed-by: NGuo Ren <guoren@kernel.org>
Acked-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://lore.kernel.org/r/20230112195539.760296658@infradead.org
上级 5fca0d9f
...@@ -69,12 +69,12 @@ static int __psci_enter_domain_idle_state(struct cpuidle_device *dev, ...@@ -69,12 +69,12 @@ static int __psci_enter_domain_idle_state(struct cpuidle_device *dev,
return -1; return -1;
/* Do runtime PM to manage a hierarchical CPU toplogy. */ /* Do runtime PM to manage a hierarchical CPU toplogy. */
ct_irq_enter_irqson();
if (s2idle) if (s2idle)
dev_pm_genpd_suspend(pd_dev); dev_pm_genpd_suspend(pd_dev);
else else
pm_runtime_put_sync_suspend(pd_dev); pm_runtime_put_sync_suspend(pd_dev);
ct_irq_exit_irqson();
ct_idle_enter();
state = psci_get_domain_state(); state = psci_get_domain_state();
if (!state) if (!state)
...@@ -82,12 +82,12 @@ static int __psci_enter_domain_idle_state(struct cpuidle_device *dev, ...@@ -82,12 +82,12 @@ static int __psci_enter_domain_idle_state(struct cpuidle_device *dev,
ret = psci_cpu_suspend_enter(state) ? -1 : idx; ret = psci_cpu_suspend_enter(state) ? -1 : idx;
ct_irq_enter_irqson(); ct_idle_exit();
if (s2idle) if (s2idle)
dev_pm_genpd_resume(pd_dev); dev_pm_genpd_resume(pd_dev);
else else
pm_runtime_get_sync(pd_dev); pm_runtime_get_sync(pd_dev);
ct_irq_exit_irqson();
cpu_pm_exit(); cpu_pm_exit();
...@@ -240,6 +240,7 @@ static int psci_dt_cpu_init_topology(struct cpuidle_driver *drv, ...@@ -240,6 +240,7 @@ static int psci_dt_cpu_init_topology(struct cpuidle_driver *drv,
* of a shared state for the domain, assumes the domain states are all * of a shared state for the domain, assumes the domain states are all
* deeper states. * deeper states.
*/ */
drv->states[state_count - 1].flags |= CPUIDLE_FLAG_RCU_IDLE;
drv->states[state_count - 1].enter = psci_enter_domain_idle_state; drv->states[state_count - 1].enter = psci_enter_domain_idle_state;
drv->states[state_count - 1].enter_s2idle = psci_enter_s2idle_domain_idle_state; drv->states[state_count - 1].enter_s2idle = psci_enter_s2idle_domain_idle_state;
psci_cpuidle_use_cpuhp = true; psci_cpuidle_use_cpuhp = true;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册