提交 df5d4b61 编写于 作者: M Miaoqian Lin 提交者: Michael Ellerman

powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address

of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.

Fixes: ce21b3c9 ("[CELL] add support for MSI on Axon-based Cell systems")
Signed-off-by: NMiaoqian Lin <linmq006@gmail.com>
Signed-off-by: NMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605065129.63906-1-linmq006@gmail.com
上级 255b650c
...@@ -223,6 +223,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg) ...@@ -223,6 +223,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
if (!prop) { if (!prop) {
dev_dbg(&dev->dev, dev_dbg(&dev->dev,
"axon_msi: no msi-address-(32|64) properties found\n"); "axon_msi: no msi-address-(32|64) properties found\n");
of_node_put(dn);
return -ENOENT; return -ENOENT;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册