提交 de116c46 编写于 作者: Y Yu'an Wang 提交者: Yang Yingliang

uacce: misc fixes

driver inclusion
category: bugfix
bugzilla: NA
CVE: NA

1.add input para check of uacce_unregister api
2.change uacce_qfrt_str to internal interface, because it is used
  just in uacce.c
Signed-off-by: NYu'an Wang <wangyuan46@huawei.com>
Reviewed-by: NLongfang Liu <liulongfang@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 01702464
...@@ -126,11 +126,10 @@ static void uacce_hw_err_destroy(struct uacce *uacce) ...@@ -126,11 +126,10 @@ static void uacce_hw_err_destroy(struct uacce *uacce)
} }
} }
const char *uacce_qfrt_str(struct uacce_qfile_region *qfr) static const char *uacce_qfrt_str(struct uacce_qfile_region *qfr)
{ {
return qfrt_str[qfr->type]; return qfrt_str[qfr->type];
} }
EXPORT_SYMBOL_GPL(uacce_qfrt_str);
/** /**
* uacce_wake_up - Wake up the process who is waiting this queue * uacce_wake_up - Wake up the process who is waiting this queue
...@@ -1302,6 +1301,9 @@ EXPORT_SYMBOL_GPL(uacce_register); ...@@ -1302,6 +1301,9 @@ EXPORT_SYMBOL_GPL(uacce_register);
*/ */
int uacce_unregister(struct uacce *uacce) int uacce_unregister(struct uacce *uacce)
{ {
if (!uacce)
return -ENODEV;
if (atomic_read(&uacce->ref) > 0) { if (atomic_read(&uacce->ref) > 0) {
printk_ratelimited("Fail to unregister uacce, please close all uacce queues!\n"); printk_ratelimited("Fail to unregister uacce, please close all uacce queues!\n");
return -EAGAIN; return -EAGAIN;
......
...@@ -128,7 +128,6 @@ struct uacce { ...@@ -128,7 +128,6 @@ struct uacce {
int uacce_register(struct uacce *uacce); int uacce_register(struct uacce *uacce);
int uacce_unregister(struct uacce *uacce); int uacce_unregister(struct uacce *uacce);
void uacce_wake_up(struct uacce_queue *q); void uacce_wake_up(struct uacce_queue *q);
const char *uacce_qfrt_str(struct uacce_qfile_region *qfr);
struct uacce *dev_to_uacce(struct device *dev); struct uacce *dev_to_uacce(struct device *dev);
int uacce_hw_err_isolate(struct uacce *uacce); int uacce_hw_err_isolate(struct uacce *uacce);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册