提交 dc807fcc 编写于 作者: P Pavel Skripkin 提交者: Yang Yingliang

net: caif: fix memory leak in caif_device_notify

commit b53558a9 upstream.

In case of caif_enroll_dev() fail, allocated
link_support won't be assigned to the corresponding
structure. So simply free allocated pointer in case
of error

Fixes: 7c18d220 ("caif: Restructure how link caif link layer enroll")
Cc: stable@vger.kernel.org
Reported-and-tested-by: syzbot+7ec324747ce876a29db6@syzkaller.appspotmail.com
Signed-off-by: NPavel Skripkin <paskripkin@gmail.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 4a7faedc
...@@ -365,6 +365,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, ...@@ -365,6 +365,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
struct cflayer *layer, *link_support; struct cflayer *layer, *link_support;
int head_room = 0; int head_room = 0;
struct caif_device_entry_list *caifdevs; struct caif_device_entry_list *caifdevs;
int res;
cfg = get_cfcnfg(dev_net(dev)); cfg = get_cfcnfg(dev_net(dev));
caifdevs = caif_device_list(dev_net(dev)); caifdevs = caif_device_list(dev_net(dev));
...@@ -390,8 +391,10 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, ...@@ -390,8 +391,10 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
break; break;
} }
} }
caif_enroll_dev(dev, caifdev, link_support, head_room, res = caif_enroll_dev(dev, caifdev, link_support, head_room,
&layer, NULL); &layer, NULL);
if (res)
cfserl_release(link_support);
caifdev->flowctrl = dev_flowctrl; caifdev->flowctrl = dev_flowctrl;
break; break;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册