提交 d9ad1bdd 编写于 作者: C Clemens Ladisch 提交者: Jaroslav Kysela

[ALSA] rtctimer: optimize module parameter validation

Modules: RTC timer driver

The check whether rtctimer_freq is a power of two can be done easier
with a simple bit operation.
Signed-off-by: NClemens Ladisch <clemens@ladisch.de>
上级 adf25df1
......@@ -119,16 +119,11 @@ static void rtctimer_interrupt(void *private_data)
*/
static int __init rtctimer_init(void)
{
int order, err;
int err;
snd_timer_t *timer;
if (rtctimer_freq < 2 || rtctimer_freq > 8192) {
snd_printk(KERN_ERR "rtctimer: invalid frequency %d\n", rtctimer_freq);
return -EINVAL;
}
for (order = 1; rtctimer_freq > order; order <<= 1)
;
if (rtctimer_freq != order) {
if (rtctimer_freq < 2 || rtctimer_freq > 8192 ||
(rtctimer_freq & (rtctimer_freq - 1)) != 0) {
snd_printk(KERN_ERR "rtctimer: invalid frequency %d\n", rtctimer_freq);
return -EINVAL;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册