提交 d7dbd43f 编写于 作者: C Chris Mason 提交者: Jens Axboe

blk-cgroup: properly pin the parent in blkcg_css_online

blkcg_css_online is supposed to pin the blkcg of the parent, but
397c9f46 refactored things and along the way, changed it to pin the
css instead.  This results in extra pins, and we end up leaking blkcgs
and cgroups.

Fixes: 397c9f46 ("blk-cgroup: move blkcg_{pin,unpin}_online out of line")
Signed-off-by: NChris Mason <clm@fb.com>
Spotted-by: NRik van Riel <riel@surriel.com>
Cc: <stable@vger.kernel.org> # v5.19+
Acked-by: NJohannes Weiner <hannes@cmpxchg.org>
Link: https://lore.kernel.org/r/20221114181930.2093706-1-clm@fb.comSigned-off-by: NJens Axboe <axboe@kernel.dk>
上级 df24560d
......@@ -1213,7 +1213,7 @@ static int blkcg_css_online(struct cgroup_subsys_state *css)
* parent so that offline always happens towards the root.
*/
if (parent)
blkcg_pin_online(css);
blkcg_pin_online(&parent->css);
return 0;
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册