提交 d2de4444 编写于 作者: X Xin Long 提交者: Jakub Kicinski

net: igbvf: use skb_csum_is_sctp instead of protocol check

Using skb_csum_is_sctp is a easier way to validate it's a SCTP CRC
checksum offload packet, and yet it also makes igbvf support SCTP
CRC checksum offload for UDP and GRE encapped packets, just as it
does in igb driver.
Signed-off-by: NXin Long <lucien.xin@gmail.com>
Reviewed-by: NAlexander Duyck <alexanderduyck@fb.com>
Signed-off-by: NJakub Kicinski <kuba@kernel.org>
上级 8bcf0203
...@@ -2072,15 +2072,6 @@ static int igbvf_tso(struct igbvf_ring *tx_ring, ...@@ -2072,15 +2072,6 @@ static int igbvf_tso(struct igbvf_ring *tx_ring,
return 1; return 1;
} }
static inline bool igbvf_ipv6_csum_is_sctp(struct sk_buff *skb)
{
unsigned int offset = 0;
ipv6_find_hdr(skb, &offset, IPPROTO_SCTP, NULL, NULL);
return offset == skb_checksum_start_offset(skb);
}
static bool igbvf_tx_csum(struct igbvf_ring *tx_ring, struct sk_buff *skb, static bool igbvf_tx_csum(struct igbvf_ring *tx_ring, struct sk_buff *skb,
u32 tx_flags, __be16 protocol) u32 tx_flags, __be16 protocol)
{ {
...@@ -2102,10 +2093,7 @@ static bool igbvf_tx_csum(struct igbvf_ring *tx_ring, struct sk_buff *skb, ...@@ -2102,10 +2093,7 @@ static bool igbvf_tx_csum(struct igbvf_ring *tx_ring, struct sk_buff *skb,
break; break;
case offsetof(struct sctphdr, checksum): case offsetof(struct sctphdr, checksum):
/* validate that this is actually an SCTP request */ /* validate that this is actually an SCTP request */
if (((protocol == htons(ETH_P_IP)) && if (skb_csum_is_sctp(skb)) {
(ip_hdr(skb)->protocol == IPPROTO_SCTP)) ||
((protocol == htons(ETH_P_IPV6)) &&
igbvf_ipv6_csum_is_sctp(skb))) {
type_tucmd = E1000_ADVTXD_TUCMD_L4T_SCTP; type_tucmd = E1000_ADVTXD_TUCMD_L4T_SCTP;
break; break;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册