提交 d0294ed6 编写于 作者: K Kuniyuki Iwashima 提交者: Zheng Zengkai

sysctl: Fix data races in proc_douintvec_minmax().

stable inclusion
from stable-v5.10.132
commit e3a2144b3b6bf9ecafd91087c8b8b48171ec19df
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I5YS3T

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e3a2144b3b6bf9ecafd91087c8b8b48171ec19df

--------------------------------

[ Upstream commit 2d3b559d ]

A sysctl variable is accessed concurrently, and there is always a chance
of data-race.  So, all readers and writers need some basic protection to
avoid load/store-tearing.

This patch changes proc_douintvec_minmax() to use READ_ONCE() and
WRITE_ONCE() internally to fix data-races on the sysctl side.  For now,
proc_douintvec_minmax() itself is tolerant to a data-race, but we still
need to add annotations on the other subsystem's side.

Fixes: 61d9b56a ("sysctl: add unsigned int range support")
Signed-off-by: NKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
Acked-by: NXie XiuQi <xiexiuqi@huawei.com>
上级 11dc0fb8
...@@ -1031,7 +1031,7 @@ static int do_proc_douintvec_minmax_conv(unsigned long *lvalp, ...@@ -1031,7 +1031,7 @@ static int do_proc_douintvec_minmax_conv(unsigned long *lvalp,
(param->max && *param->max < tmp)) (param->max && *param->max < tmp))
return -ERANGE; return -ERANGE;
*valp = tmp; WRITE_ONCE(*valp, tmp);
} }
return 0; return 0;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册