提交 ca1f3ae3 编写于 作者: G Gustavo A. R. Silva 提交者: Linus Walleij

gpio: msic: fix error return code in platform_msic_gpio_probe()

platform_get_irq() returns an error code, but the gpio-msic driver
ignores it and always returns -EINVAL. This is not correct, and
prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.
Signed-off-by: NGustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
上级 e2c3c196
...@@ -265,8 +265,8 @@ static int platform_msic_gpio_probe(struct platform_device *pdev) ...@@ -265,8 +265,8 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
int i; int i;
if (irq < 0) { if (irq < 0) {
dev_err(dev, "no IRQ line\n"); dev_err(dev, "no IRQ line: %d\n", irq);
return -EINVAL; return irq;
} }
if (!pdata || !pdata->gpio_base) { if (!pdata || !pdata->gpio_base) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册