提交 bbb5bda1 编写于 作者: R Randy Dunlap 提交者: sanglipeng

net: mlx5: eliminate anonymous module_init & module_exit

stable inclusion
from stable-v5.10.166
commit 31f63c62a8e81911c65d83837c75ca81e508aa42
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7TH9O

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=31f63c62a8e81911c65d83837c75ca81e508aa42

--------------------------------

[ Upstream commit 2c1e1b94 ]

Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.

Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.

Example 1: (System.map)
 ffffffff832fc78c t init
 ffffffff832fc79e t init
 ffffffff832fc8f8 t init

Example 2: (initcall_debug log)
 calling  init+0x0/0x12 @ 1
 initcall init+0x0/0x12 returned 0 after 15 usecs
 calling  init+0x0/0x60 @ 1
 initcall init+0x0/0x60 returned 0 after 2 usecs
 calling  init+0x0/0x9a @ 1
 initcall init+0x0/0x9a returned 0 after 74 usecs

Fixes: e126ba97 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Signed-off-by: NRandy Dunlap <rdunlap@infradead.org>
Cc: Eli Cohen <eli@mellanox.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org
Reviewed-by: NIra Weiny <ira.weiny@intel.com>
Reviewed-by: NLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: NSaeed Mahameed <saeedm@nvidia.com>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: Nsanglipeng <sanglipeng1@jd.com>
上级 2a7c5269
...@@ -1642,7 +1642,7 @@ static void mlx5_core_verify_params(void) ...@@ -1642,7 +1642,7 @@ static void mlx5_core_verify_params(void)
} }
} }
static int __init init(void) static int __init mlx5_init(void)
{ {
int err; int err;
...@@ -1667,7 +1667,7 @@ static int __init init(void) ...@@ -1667,7 +1667,7 @@ static int __init init(void)
return err; return err;
} }
static void __exit cleanup(void) static void __exit mlx5_cleanup(void)
{ {
#ifdef CONFIG_MLX5_CORE_EN #ifdef CONFIG_MLX5_CORE_EN
mlx5e_cleanup(); mlx5e_cleanup();
...@@ -1676,5 +1676,5 @@ static void __exit cleanup(void) ...@@ -1676,5 +1676,5 @@ static void __exit cleanup(void)
mlx5_unregister_debugfs(); mlx5_unregister_debugfs();
} }
module_init(init); module_init(mlx5_init);
module_exit(cleanup); module_exit(mlx5_cleanup);
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册