clk: Skip clk provider registration when np is NULL
commit 6579c8d9 ("clk: Mark fwnodes when their clock provider is added") revealed that clk/bcm/clk-raspberrypi.c driver calls devm_of_clk_add_hw_provider(), with a NULL dev->of_node, which resulted in a NULL pointer dereference in of_clk_add_hw_provider() when calling fwnode_dev_initialized(). Returning 0 is reducing the if conditions in driver code and is being consistent with the CONFIG_OF=n inline stub that returns 0 when CONFIG_OF is disabled. The downside is that drivers will maybe register clkdev lookups when they don't need to and waste some memory. Fixes: 6579c8d9 ("clk: Mark fwnodes when their clock provider is added") Fixes: 3c9ea428 ("clk: Mark fwnodes when their clock provider is added/removed") Reported-by: NMarek Szyprowski <m.szyprowski@samsung.com> Tested-by: NGuenter Roeck <linux@roeck-us.net> Tested-by: NNathan Chancellor <nathan@kernel.org> Reviewed-by: NStephen Boyd <sboyd@kernel.org> Reviewed-by: NSaravana Kannan <saravanak@google.com> Reviewed-by: NNicolas Saenz Julienne <nsaenz@kernel.org> Signed-off-by: NTudor Ambarus <tudor.ambarus@microchip.com> Link: https://lore.kernel.org/r/20210426065618.588144-1-tudor.ambarus@microchip.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Showing
想要评论请 注册 或 登录