提交 b887df52 编写于 作者: A Andi Shyti 提交者: Dmitry Torokhov

Input: raydium_i2c_ts - use managed devm_device_add_group

Commit 57b8ff07 ("driver core: add devm_device_add_group() and
friends") has added the managed version for creating sysfs group files.

Use devm_device_add_group instead of sysfs_create_group and remove the
action that cleans the sysfs file when exiting the driver.
Signed-off-by: NAndi Shyti <andi@etezian.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>
上级 4c16f82e
...@@ -943,13 +943,6 @@ static const struct attribute_group raydium_i2c_attribute_group = { ...@@ -943,13 +943,6 @@ static const struct attribute_group raydium_i2c_attribute_group = {
.attrs = raydium_i2c_attributes, .attrs = raydium_i2c_attributes,
}; };
static void raydium_i2c_remove_sysfs_group(void *_data)
{
struct raydium_data *ts = _data;
sysfs_remove_group(&ts->client->dev.kobj, &raydium_i2c_attribute_group);
}
static int raydium_i2c_power_on(struct raydium_data *ts) static int raydium_i2c_power_on(struct raydium_data *ts)
{ {
int error; int error;
...@@ -1120,7 +1113,7 @@ static int raydium_i2c_probe(struct i2c_client *client, ...@@ -1120,7 +1113,7 @@ static int raydium_i2c_probe(struct i2c_client *client,
return error; return error;
} }
error = sysfs_create_group(&client->dev.kobj, error = devm_device_add_group(&client->dev,
&raydium_i2c_attribute_group); &raydium_i2c_attribute_group);
if (error) { if (error) {
dev_err(&client->dev, "failed to create sysfs attributes: %d\n", dev_err(&client->dev, "failed to create sysfs attributes: %d\n",
...@@ -1128,15 +1121,6 @@ static int raydium_i2c_probe(struct i2c_client *client, ...@@ -1128,15 +1121,6 @@ static int raydium_i2c_probe(struct i2c_client *client,
return error; return error;
} }
error = devm_add_action(&client->dev,
raydium_i2c_remove_sysfs_group, ts);
if (error) {
raydium_i2c_remove_sysfs_group(ts);
dev_err(&client->dev,
"Failed to add sysfs cleanup action: %d\n", error);
return error;
}
return 0; return 0;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册