提交 b25b8958 编写于 作者: J Julia Lawall 提交者: Mauro Carvalho Chehab

[media] m5mols: introduce missing initialization

The result of one call to a function is tested, and then at the second call
to the same function, the previous result, and not the current result, is
tested again.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression ret;
identifier f;
statement S1,S2;
@@

*ret = f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S1
... when any
*f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S2
// </smpl>
Signed-off-by: NJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: NMauro Carvalho Chehab <mchehab@redhat.com>
上级 780d6170
......@@ -937,7 +937,7 @@ static int __devinit m5mols_probe(struct i2c_client *client,
if (!ret)
ret = m5mols_init_controls(sd);
m5mols_sensor_power(info, false);
ret = m5mols_sensor_power(info, false);
if (!ret)
return 0;
out_me:
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册