提交 af6f8529 编写于 作者: H Heinrich Schuchardt 提交者: Greg Kroah-Hartman

usb: musb: gadget: misplaced out of bounds check

musb->endpoints[] has array size MUSB_C_NUM_EPS.
We must check array bounds before accessing the array and not afterwards.
Signed-off-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: NBin Liu <b-liu@ti.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
上级 be9cae24
...@@ -89,15 +89,19 @@ static int service_tx_status_request( ...@@ -89,15 +89,19 @@ static int service_tx_status_request(
} }
is_in = epnum & USB_DIR_IN; is_in = epnum & USB_DIR_IN;
if (is_in) { epnum &= 0x0f;
epnum &= 0x0f; if (epnum >= MUSB_C_NUM_EPS) {
handled = -EINVAL;
break;
}
if (is_in)
ep = &musb->endpoints[epnum].ep_in; ep = &musb->endpoints[epnum].ep_in;
} else { else
ep = &musb->endpoints[epnum].ep_out; ep = &musb->endpoints[epnum].ep_out;
}
regs = musb->endpoints[epnum].regs; regs = musb->endpoints[epnum].regs;
if (epnum >= MUSB_C_NUM_EPS || !ep->desc) { if (!ep->desc) {
handled = -EINVAL; handled = -EINVAL;
break; break;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册