提交 a7ea1992 编写于 作者: D David Herrmann 提交者: Matthew Garrett

Platform: Fix error path in samsung-laptop init

samsung_init() should not return success if not all devices are initialized.
Otherwise, samsung_exit() will dereference sdev NULL pointers and others.
Signed-off-by: NDavid Herrmann <dh.herrmann@googlemail.com>
Cc: stable <stable@kernel.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: NMatthew Garrett <mjg@redhat.com>
上级 bee460be
......@@ -781,7 +781,7 @@ static int __init samsung_init(void)
sabi_iface = ioremap_nocache(ifaceP, 16);
if (!sabi_iface) {
pr_err("Can't remap %x\n", ifaceP);
goto exit;
goto error_no_signature;
}
if (debug) {
printk(KERN_DEBUG "ifaceP = 0x%08x\n", ifaceP);
......@@ -833,7 +833,6 @@ static int __init samsung_init(void)
if (retval)
goto error_file_create;
exit:
return 0;
error_file_create:
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册