提交 a77bdbb4 编写于 作者: F Fangrui Song 提交者: Zheng Zengkai

riscv module: remove (NOLOAD)

stable inclusion
from stable-v5.10.110
commit 785a53373c22e3b75afcaffb99cbc9484dae9276
bugzilla: https://gitee.com/openeuler/kernel/issues/I574AL

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=785a53373c22e3b75afcaffb99cbc9484dae9276

--------------------------------

commit 60210a3d upstream.

On ELF, (NOLOAD) sets the section type to SHT_NOBITS[1]. It is conceptually
inappropriate for .plt, .got, and .got.plt sections which are always
SHT_PROGBITS.

In GNU ld, if PLT entries are needed, .plt will be SHT_PROGBITS anyway
and (NOLOAD) will be essentially ignored. In ld.lld, since
https://reviews.llvm.org/D118840 ("[ELF] Support (TYPE=<value>) to
customize the output section type"), ld.lld will report a `section type
mismatch` error (later changed to a warning). Just remove (NOLOAD) to
fix the warning.

[1] https://lld.llvm.org/ELF/linker_script.html As of today, "The
section should be marked as not loadable" on
https://sourceware.org/binutils/docs/ld/Output-Section-Type.html is
outdated for ELF.

Link: https://github.com/ClangBuiltLinux/linux/issues/1597
Fixes: ab1ef68e ("RISC-V: Add sections of PLT and GOT for kernel module")
Reported-by: NNathan Chancellor <nathan@kernel.org>
Signed-off-by: NFangrui Song <maskray@google.com>
Signed-off-by: NPalmer Dabbelt <palmer@rivosinc.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NYu Liao <liaoyu15@huawei.com>
Reviewed-by: NWei Li <liwei391@huawei.com>
Signed-off-by: NZheng Zengkai <zhengzengkai@huawei.com>
上级 cde893f3
...@@ -2,8 +2,8 @@ ...@@ -2,8 +2,8 @@
/* Copyright (C) 2017 Andes Technology Corporation */ /* Copyright (C) 2017 Andes Technology Corporation */
#ifdef CONFIG_MODULE_SECTIONS #ifdef CONFIG_MODULE_SECTIONS
SECTIONS { SECTIONS {
.plt (NOLOAD) : { BYTE(0) } .plt : { BYTE(0) }
.got (NOLOAD) : { BYTE(0) } .got : { BYTE(0) }
.got.plt (NOLOAD) : { BYTE(0) } .got.plt : { BYTE(0) }
} }
#endif #endif
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册